Jump to content

Community

Ryan H.

Advanced Tags & Prefixes - IPS 4.x

Recommended Posts

Posted (edited)

See

I'm having the exact same issue - when trying to do a lookup on "Add Tag" for a forum configured w/ closed tags, it just spins forever.

I'm testing in Firefox/Win10 and using the default theme; error logged is:
image.thumb.png.821f6bce50f5b32af229e4f358e3a832.png

@Kevin Carwile any ideas?

Edited by djpretzel

Share this post


Link to post
Share on other sites
Posted (edited)

image.thumb.png.336084a78ad219837d72b7d670babc09.png

 

I would like to populate settings to all forums, instead of setting them up individually per each forum.

However, settings mass copy seems not to work properly on 4.4.2. 

Any idea if that be a problem of IPB? or the AT&P application itself?

 

 

Edited by DJ_Tomcat

Share this post


Link to post
Share on other sites

Hello!

im confused a bit. Why is the first letter by Other and Photo capital and video lower case? I deleted the video prefix and copied the Photo and renamed. Same issue.

 

1.JPG.560c7e6c7560c7c85d3c341b4627edab.JPG2.thumb.JPG.44639beb8f8aff4d369fa39ab9f83d0f.JPG

Share this post


Link to post
Share on other sites

Very dumb to all this coding and what not. How do I keep all tags capitalized? 

 

ROLEPLAY instead of roleplay

INTERVIEW instead of interview.

 

Thanks for the help.

Share this post


Link to post
Share on other sites

@Kevin Carwile, since you're the guy for this app now: are plans still in the works to extend this app's full functionality to blogs, pages, and other Invision components?

Pretty close to buyin this app but would like to know if this is planned.  Thanks!

Share this post


Link to post
Share on other sites

Hi,

 

Are you going to be adding a feature to edit a thread prefix through moderation options rather than having to edit the post? Thanks!

Share this post


Link to post
Share on other sites
Posted (edited)

@Kevin Carwile Here's a quick bug report after I upgraded the application to 3.2.0 on a site I manage for someone:

PHP Warning: Declaration of IPS\Content\advancedtagsprefixes_hook_addPrefixToForm::tagsFormField($item, $container) should be compatible with IPS\Content\_Item::tagsFormField($item, $container, $minimized = false) in 141 on line 407

 

The fix is to simply update line 233 in the hook from:

public static function tagsFormField( $item, $container )

to:

public static function tagsFormField( $item, $container, $minimized = FALSE )

and also line 260 from:

parent::tagsFormField( $item, $container )

to:

parent::tagsFormField( $item, $container, $minimized )

 

👍

Edited by teraßyte

Share this post


Link to post
Share on other sites

@Kevin Carwile Found a few more errors on the front-end this time around (the one above was in ACP). Here's a list below (all missing root namespaces - also IPS is custting down on call_user_func_array & func_get_args as well):

Whoops\Exception\ErrorException thrown with message "You have used a function (in_array) that should be called from the root namespace for performance reasons (applications/advancedtagsprefixes/hooks/forumLastPostPrefix.php::270)."

if ( isset( static::$contentItemClass ) and \IPS\Settings::i()->tags_enabled and in_array( 'IPS\Content\Tags', class_implements( static::$contentItemClass ) ) )

====

Whoops\Exception\ErrorException thrown with message "You have used a function (is_null) that should be called from the root namespace for performance reasons (applications/advancedtagsprefixes/hooks/nodeModel.php::66)."

There are 2 "is_null" instances on the same line here.

if ( static::isTaggable() === TRUE and !is_null( static::$permApp ) and !is_null( static::$permType ) )

===

Whoops\Exception\ErrorException thrown with message "You have used a function (in_array) that should be called from the root namespace for performance reasons (applications/advancedtagsprefixes/hooks/nodeModel.php::233)."

if ( isset( static::$contentItemClass ) and \IPS\Settings::i()->tags_enabled and in_array( 'IPS\Content\Tags', class_implements( static::$contentItemClass ) ) )

===

In the hook "applications/advancedtagsprefixes/hooks/forumLastPostPrefix.php" replace 3 instances of "call_user_func_array/func_get_args":

return call_user_func_array( 'parent::setLastComment', func_get_args() );

with:

return parent::setLastComment($comment);

===

In the hook "applications/advancedtagsprefixes/hooks/forumLastPostPrefix.php" replace 1 instance of "call_user_func_array/func_get_args/is_null":

			$result = call_user_func_array( 'parent::lastPost', func_get_args() );
			
			if( !is_null( $result ) )

with:

			$result = parent::lastPost();
			
			if( !\is_null( $result ) )

===

In the hook "applications/advancedtagsprefixes/hooks/forumLastPostPrefix.php" replace 1 instance of "is_array/in_array":

								is_array( \IPS\Member::loggedIn()->modPermission( 'forums' ) )
								and
								in_array( $this->_id, \IPS\Member::loggedIn()->modPermission( 'forums' ) )

with:

								\is_array( \IPS\Member::loggedIn()->modPermission( 'forums' ) )
								and
								\in_array( $this->_id, \IPS\Member::loggedIn()->modPermission( 'forums' ) )

 

Share this post


Link to post
Share on other sites
On 4/4/2019 at 9:39 AM, DJ_Tomcat said:

image.thumb.png.336084a78ad219837d72b7d670babc09.png

 

I would like to populate settings to all forums, instead of setting them up individually per each forum.

However, settings mass copy seems not to work properly on 4.4.2. 

Any idea if that be a problem of IPB? or the AT&P application itself?

 

 

It also doesn't work on v4.4.4 which is a real pain when you have lots of forums to populate with prefix options

Share this post


Link to post
Share on other sites

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...