Jump to content

Daniel F

Invision Community Team
  • Posts

    6,565
  • Joined

  • Days Won

    37

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Posts posted by Daniel F

  1. @TAMAN My merry Christmas weekend suggestion:

    Either update/delete such data when a forum is deleted, or wrap your code always into a try-catch block:) 
    To make it easier for the admin to see what's going on, you could e.g. use IPS\Log::log() to log an error inside the catch block, or with 4.4 you could also use our new admin notification system ( 

     ) to send a notification to the admin to notify him about the deleted node which is used in the footer..

  2. 26 minutes ago, Faqole said:

    It has been tested by the MP moderators before being approved.

    Sorry, that's not correct:) 

    We check in accordance with our guidelines, but it is not certifying that the resource is bug free. We ensure that it won't break anything in the core, we ensure that it moves uploaded files if the file storage changes, we ensure that it follows the rules from our guides like that you have to call the parent method and such stuff, but it's not our responsibility to test the functionality of MP submissions. We stopped this a while ago because some people abused the MP and the MP moderators as their free testers.

  3. 16 hours ago, Tripp★ said:

    Feature suggestion: Currently you are able to set the amount of clubs people can make, is there anyway of moving this to the usergroup permissions table at all, so we can set it per usergroup? For example normal members can create 4 clubs, premium members can create 10 clubs and staff can create unlimited clubs?

    That's already possible in IPS since IPS 4.3 ?

    Quote
    • Admins can set limits on number of Clubs per group.

     

  4. 22 minutes ago, GASR said:

    Does that mean I can no longer reset name changes without effecting other logged history?  We allow name changes once a year and sometimes that gets messed up when we add accounts manually.

    You can still do this!
    We have only changed the way how and where they're stored and how the changes are presented in the ACP. The presentation on the frontend profile and also all the permissions wasn't changed.

  5. 10 minutes ago, Upgradeovec said:

    This will show proper blog on your bad url address (better than get 404):

    173a633918464df88f764f4620a93e42.thumb.png.5504ade137c65f5fbecafa98c5977dca.png

     

    Of course, much better rewrite with 301. It can be done with your web server or some hook some file. If i need to do this i'll hook \IPS\Session\Front, read method. Because we need to redirect your ulr to correct place with 301 before something will start working in main engine. Something like that:

    
    public function read( $sessionId )
    {
        $url = \IPS\Request::i()->url()->data['path'];
        if (mb_strpos($url, '/blog/') === 0) {
            preg_match("/\/blog\/(\d+)?\/.+/", $url, $res);
            \IPS\Output::i()->redirect(\IPS\Http\Url::internal('app=blog&module=blogs&controller=entry&id='.$res[1], 'front'));
        }
        return call_user_func_array( 'parent::read', func_get_args() );
    }

    or the same in ready plugin file Blogs Redirection.xml

     

    P.S. Need to rename this topic to "Every SEO Q/A"  :lol:

    NOPE, please not! For the record, I'm not talking about your use case, only about your hook... Just a minor suggestion, please use  IPS\Application: convertLegacyParameters() instead of overriding the session class. This would be the "official" place for such redirect, this definitely doesn't belong into the session object!


    You can see some examples in the core or forums app:)

     

  6. This was a bug which I have fixed for IPS 4.3 ( The report and reportComment Form page returned response code 404 instead of 403 )

    6 hours ago, sadams101 said:

    This could be totally unrelated, but shortly after making these changes I got a notice from google about an increase in crawler errors:

    When looking at the errors I see they relate to the Report Comments Link, for example:

    https://www.celiac.com/gluten-free/topic/77816-is-kimchi-gluten-less/?do=reportComment&comment=676584

    and

    https://www.celiac.com/gluten-free/topic/29519-chocoholics-there-is-hope/?do=reportComment&comment=317896

    Here is the error:

     

    Would your changes cause this?

     

  7. Please change the error in the modules/admin/manage controller.

    You really shouldn't throw a logged exception If the admin has no permission to award somebody

     

     throw new \Exception(  \IPS\Member::loggedIn()->language()->get( 'awards_others_err' ) );

     

    Same with

     throw new \Exception( \IPS\Member::loggedIn()->language()->get( 'awards_obtainable_err' ) )

     

  8. There's a bug in the winners task

    Only subclasses of Dispatcher can be instantiated
    
    #0 /home/ing/public_html/forum/system/Theme/Theme.php(727): IPS\_Dispatcher::i()
    #1 /home/ing/public_html/forum/system/Theme/Theme.php(824) : eval()'d code(886): IPS\_Theme->getTemplate('global', 'core')
    #2 /home/ing/public_html/forum/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_raffles_front_view->memberRow(Object(IPS\raffles\Raffle), Object(IPS\Member), Array, 1)
    #3 /home/ing/public_html/forum/system/Theme/Theme.php(824) : eval()'d code(1730): IPS\Theme\_SandboxedTemplate->__call('memberRow', Array)
    #4 /home/ing/public_html/forum/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_raffles_front_view->raffleWinners(22, Array)
    #5 /home/ing/public_html/forum/system/Theme/Theme.php(824) : eval()'d code(720): IPS\Theme\_SandboxedTemplate->__call('raffleWinners', Array)
    #6 /home/ing/public_html/forum/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_raffles_front_submit->updateTopicWithWinners(22, 'giveaway', Array)
    #7 /home/ing/public_html/forum/applications/raffles/tasks/Winners.php(160): IPS\Theme\_SandboxedTemplate->__call('updateTopicWith...', Array)
    #8 /home/ing/public_html/forum/applications/raffles/tasks/Winners.php(104): IPS\raffles\tasks\_Winners->updateTopicWithResult(Object(IPS\raffles\Raffle), Array)
    #9 /home/ing/public_html/forum/system/Task/Task.php(248): IPS\raffles\tasks\_Winners->execute()
    #10 /home/ing/public_html/forum/system/Task/Task.php(217): IPS\_Task->run()
    #11 /home/ing/public_html/forum/applications/core/interface/task/task.php(60): IPS\_Task->runAndLog()
    #12 {main}

     

  9. Hi,

    Your app contains several language strings with the same key, as present in the core application, which is causing translation issues . At a quick glance, I've noticed "delete","quote", "guest".
    I would suggest to add an app specific prefix to the key or to reuse the existing langstrings from the core to avoid such issues in the future :)

  10. 10 hours ago, Adriano Faria said:

    @Cyboman, I'm on a borrowed laptop.

    The image on raffle view:

    
    {template="thumbImage" group="global" app="raffles" params="$raffle->image, $raffle->title, 'medium', '', '', '', 'raffles_Image'"}

    The extension name it's there (raffles_Image).

    The extensions:

    Capturar.png

    It appears in the ACP -> System -> Files -> Storage Settings:

    Capturar.png

     

    Honestly, it seems right to me and I always used like that in all apps (Tutorials, Classifieds, Links, Quizzes, etc).

    That's a bug in your app...

    The extensions class name is Image and you're using Images  in view.php

    \IPS\Output::i()->metaTags['og:image'] = \IPS\File::get( 'raffles_Images', $this->raffle->thumb )->url;

     

  11. 6 hours ago, Kevin Carwile said:

    I don't see of any way to import vb4 social groups to IPS clubs. Where are you seeing that?

     

    10 minutes ago, Keviee. said:

    I have not updated to 4.2 yet. Does this mean I cannot upgrade collaborations too?

     

    8 minutes ago, Adriano Faria said:

    Lindy said "they could look into that" in the Clubs article but nothing else has been said. 

    It's part of the converter app.

  12. There's a bug in this application which is causing a 500 error page   caused by this line in your hook:

    public function log( $status, $member )
    	{
    		if( \IPS\Dispatcher::i()->controllerLocation === 'front' AND \IPS\Settings::i()->llogs_groups == '*' OR $member->inGroup( explode( ',', \IPS\Settings::i()->llogs_groups ) ) )
    		{
    	

    you're not checking if $member is null or an instance of \IPS\Member which results in following fatal error:

    [22-Sep-2016 10:07:32 UTC] PHP Fatal error:  Call to a member function inGroup() on array in /home/zzzz/public_html/init.php(442) : eval()'d code on line 37

    So each time somebody tries to login with a not existing account, it results in a 500 error page

  13. 5 hours ago, Jirinex said:

    Hello,

    Maybe somebody can help me. We did the upgrade and everything went well, about an hour later (and with nothing changed from our side) all the css was gone and it's just loading in text mode. There are a lot of background processes still running, so I am not sure if I need to wait it out. Any ideas?

    CSS Shouldn't be vanished while the background processes run.

    Please submit a ticket and i'll take  a look :)

×
×
  • Create New...