Douglas Glover Posted January 6, 2021 Share Posted January 6, 2021 On 1/4/2021 at 3:46 PM, GTAPoliceMods said: I'll see what I can do. EDIT: If anyone wants to respond to this post with any info on a bug they're experiencing I can let you know if we encountered it and if so how we remedied it. I'd love to share everything we've patched altogether, but I couldn't tell you where the original author's code stops and where ours begins. Hey, since OP seems to not be responding and you seem well versed in this stuff (I have not done too much interacting w/ apps/plugins on here), maybe you'd be able to answer this for me. Is it possible to create a page that simply lists out all of the trophies and their icon, along with their description? I have a thread right now in which I list out all of them, but it's done manually, and as we add more and more it becomes difficult to maintain. A simple alphabetical list even would suffice, if I could make it a block or a separate page that'd be great. Any thoughts on this? Link to comment
GTAPoliceMods Posted January 8, 2021 Share Posted January 8, 2021 @RoleplayUK Seems like $this->_item is null, because the trophy or medal the app's trying to load can't be found. As a temporary fix, you can try wrapping the offending call in an if statement to check if the trophy or medal is loaded properly. On line ~245 of applications / trophies / sources / Trophy / MemberTrophy.php, try replacing: public function getItemImage($class = '', $sizeForFa = 2, $addTitle = FALSE, $menu = TRUE ) { return $this->_item->getItemImage($class, $sizeForFa, $addTitle, $menu); } with: public function getItemImage($class = '', $sizeForFa = 2, $addTitle = FALSE, $menu = TRUE ) { if ($this->_item) { return $this->_item->getItemImage($class, $sizeForFa, $addTitle, $menu); } } Hopefully that'll stop the errors from appearing. Keep in mind the trophy or medal that can't be loaded won't appear on postbits. @Douglas Glover That functionality already exists in the app. Can be found at example.com/trophies or example.com/index.php?app=trophies&module=items&controller=index , unless I'm misunderstanding. Douglas Glover and Trivorek 2 Link to comment
Douglas Glover Posted January 8, 2021 Share Posted January 8, 2021 @GTAPoliceMods Well damn, color me blind hah. Perfect, thanks! Link to comment
KPDub Posted January 8, 2021 Share Posted January 8, 2021 @GTAPoliceMods - have you had any joy using the expression feature? Apologies if this is a stupid question, but how do you use the expression feature? Is it PHP, SQL? Link to comment
EmpireKicking Posted January 9, 2021 Share Posted January 9, 2021 @Fosters Come back to us, We paid for a app that's not supported 😛 Link to comment
Dean_ Posted January 9, 2021 Share Posted January 9, 2021 It's not even bloody funny anymore. Since this change to the Marketplace in the ACP and the rules (whatever they've changed) has screwed up 90% of my apps/plugins now. I've disabled nearly all of them and gone back to a vanilla community which has ruined the whole essence of the forums and engagement. Along with pissing a lot of money away. Link to comment
KPDub Posted January 10, 2021 Share Posted January 10, 2021 19 hours ago, Dean_ said: It's not even bloody funny anymore. Since this change to the Marketplace in the ACP and the rules (whatever they've changed) has screwed up 90% of my apps/plugins now. I've disabled nearly all of them and gone back to a vanilla community which has ruined the whole essence of the forums and engagement. Along with pissing a lot of money away. I agree. Official support has gone downhill massively as well. I've got two tickets that have been open for over 2 months and only had one reply in that whole time. But back on topic, not sure if it's the Covid effect, the Marketplace change, the new version of the software or a combination of all of them, but support in general, save a very small minority of good devs has dropped off a cliff. I'm waiting til the end of Feb when my hosting is due for renewal and more than likely will be moving to Wordpress, it's free, okay it might not be as secure (that can be dealt with), but at least its well supported, including the free plugins which some are even more complicated than the premium ones on the IPB marketplace th3#afk 1 Link to comment
kims79 Posted January 11, 2021 Share Posted January 11, 2021 Hello, Does the latest version fix bugs for you? For me, nothing has changed ... Glad to see the author showing signs of life nonetheless! Link to comment
Fosters Posted January 11, 2021 Author Share Posted January 11, 2021 30 minutes ago, kims79 said: Hello, Does the latest version fix bugs for you? For me, nothing has changed ... What issues are you still facing? Link to comment
RoleplayUK Posted January 11, 2021 Share Posted January 11, 2021 @Fosters Hello welcome back! Unfortunately I removed the application and do not have it downloaded as I wanted to try the fix that @GTAPoliceMods kindly provided above. I was very happy to see your new update however I am unable to download this from the marketplace it says: This file is not currently available for purchase however I have already purchased it. Invision of course removed this from the marketplace meaning if you haven't got it installed at the moment there is no way downloading it. Link to comment
EmpireKicking Posted January 11, 2021 Share Posted January 11, 2021 12 minutes ago, Fosters said: What issues are you still facing? Glad to see the update and is it going to be available to buy in the future once out of beta? And I don't see a option to update this?? Why it's not saying there is a update available?? 4 minutes ago, RoleplayUK said: Invision of course removed this from the marketplace meaning if you haven't got it installed at the moment there is no way downloading it. Yes you can from your client purchase https://invisioncommunity.com/clients/purchases/ 🙂 Link to comment
kims79 Posted January 11, 2021 Share Posted January 11, 2021 23 minutes ago, Fosters said: What issues are you still facing? Hello, On the page: https://fallout-generation.com/trophies/ We still have display problems (same problem in profiles) And in additional action, "replace trophy" always generates an error: Quote TypeError: Argument 2 passed to IPS\membersshop\extensions\trophies\TrophyCriteria\_membersshop::memberMeetsCriteria() must be an instance of IPS\trophies\Trophy, instance of IPS\trophies\_Trophy given, called in /var/www/vhosts/fallout-generation.com/httpdocs/applications/trophies/sources/Trophy/Trophy.php on line 434 (0) #0 /var/www/vhosts/fallout-generation.com/httpdocs/applications/trophies/sources/Trophy/Trophy.php(434): IPS\membersshop\extensions\trophies\TrophyCriteria\_membersshop::memberMeetsCriteria() #1 /var/www/vhosts/fallout-generation.com/httpdocs/applications/trophies/sources/Trophy/Trophy.php(479): IPS\trophies\_Trophy->memberMeetsCriteria() #2 /var/www/vhosts/fallout-generation.com/httpdocs/applications/trophies/extensions/trophies/TrophyCriteria/Criteria.php(46): IPS\trophies\_Trophy::updateTrophiesForMember() #3 /var/www/vhosts/fallout-generation.com/httpdocs/applications/trophies/sources/Trophy/Trophy.php(233): IPS\trophies\extensions\trophies\TrophyCriteria\_Criteria::handleForm() #4 /var/www/vhosts/fallout-generation.com/httpdocs/system/Node/Controller.php(413): IPS\trophies\_Trophy->formatFormValues() #5 /var/www/vhosts/fallout-generation.com/httpdocs/system/Dispatcher/Controller.php(90): IPS\Node\_Controller->form() #6 /var/www/vhosts/fallout-generation.com/httpdocs/system/Node/Controller.php(62): IPS\Dispatcher\_Controller->execute() #7 /var/www/vhosts/fallout-generation.com/httpdocs/applications/trophies/modules/admin/trophies/trophy.php(54): IPS\Node\_Controller->execute() #8 /var/www/vhosts/fallout-generation.com/httpdocs/system/Dispatcher/Dispatcher.php(152): IPS\trophies\modules\admin\trophies\_trophy->execute() #9 /var/www/vhosts/fallout-generation.com/httpdocs/admin_fogen/index.php(14): IPS\_Dispatcher->run() #10 {main} On the other hand, the errors in the logs related to the calls for the trophy are they resolved, a big thank you! Link to comment
Steph40 Posted January 11, 2021 Share Posted January 11, 2021 I guess this is mor an IPS issue but I can't renew this app? Link to comment
INDIG0 Posted January 11, 2021 Share Posted January 11, 2021 Failed to update, displays a pop-up window with an error. Quote Something went wrong. Please try again. in the system log uncaught_exception RuntimeException: { "errorCode": "2S303\/N", "errorMessage": "NO_PERMISSION" } (401) #0 /var... Link to comment
EmpireKicking Posted January 11, 2021 Share Posted January 11, 2021 3 hours ago, Steph40 said: I guess this is mor an IPS issue but I can't renew this app? Same with another addon, I can't get a renewable bill. Waiting for a response from the support team Link to comment
Stuart Silvester Posted January 11, 2021 Share Posted January 11, 2021 1 hour ago, AlphaStar said: Failed to update, displays a pop-up window with an error. in the system log uncaught_exception RuntimeException: { "errorCode": "2S303\/N", "errorMessage": "NO_PERMISSION" } (401) #0 /var... You most likely need to renew your purchase 3 hours ago, Steph40 said: I guess this is mor an IPS issue but I can't renew this app? 6 minutes ago, EmpireKicking said: Same with another addon, I can't get a renewable bill. Waiting for a response from the support team Submit a ticket and we'll sort that out (I don't see a ticket from you @EmpireKicking so I'm unsure what you're waiting on) Link to comment
Steph40 Posted January 12, 2021 Share Posted January 12, 2021 1 hour ago, Stuart Silvester said: You most likely need to renew your purchase Submit a ticket and we'll sort that out (I don't see a ticket from you @EmpireKicking so I'm unsure what you're waiting on) Ticket sent. Link to comment
Steph40 Posted January 12, 2021 Share Posted January 12, 2021 11 hours ago, Steph40 said: Ticket sent. Fixed thank you Link to comment
INDIG0 Posted January 13, 2021 Share Posted January 13, 2021 Now everything works for me, though I had to wait 5 months, so if this post is actual, then I would like to get a license for Bookmarks On 11/4/2020 at 7:41 PM, Fosters said: It’s taking longer then expected but it’s coming 😞 everybody with an active license can contact me and will get a free license for any of our other apps as compensation. Link to comment
Noble~ Posted January 17, 2021 Share Posted January 17, 2021 On 7/13/2020 at 3:59 AM, Fosters said: removing trophies isn’t possible right now, but will be with the version for 4.5 I'm just testing this on a closed board did this one ever get implemented? Link to comment
wegorz23 Posted January 21, 2021 Share Posted January 21, 2021 How this trophies replacement works? I have trophies for 5, 10 and 15 years on forum. And set that one for 10 replace for 5, and one for 15 also replace (I have tried to set it to 5 and 10), but it is not working. I still see one for 10 and 15 years on profile. I should see only for 15 years. Link to comment
Fosters Posted January 25, 2021 Author Share Posted January 25, 2021 9 hours ago, wegorz23 said: Anyone please? It's working fine for me in my testing. Could I get ACP access to take a look at this? On 1/17/2021 at 8:14 AM, Noble~ said: I'm just testing this on a closed board did this one ever get implemented? No, this was removed because of some issues with the last implementation, but it's on the top priority list for the upcoming release. Link to comment
Noble~ Posted January 26, 2021 Share Posted January 26, 2021 Ok Thanks for the update Link to comment
wegorz23 Posted January 26, 2021 Share Posted January 26, 2021 (edited) 14 hours ago, Fosters said: It's working fine for me in my testing. Could I get ACP access to take a look at this? Of course. You have it on PM. It works fine, when I have only 2 trophies, and 2 replaces 1. When I have 3 and I set 2 to replace 1 it also works, but how to set it that 3 replace 2 and 1? Edited January 26, 2021 by wegorz23 Fosters 1 Link to comment
Recommended Posts