Jump to content

Daniel F

Invision Community Team
  • Posts

    6,568
  • Joined

  • Days Won

    37

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Posts posted by Daniel F

  1. Just a suggestion to save a really unnecessary DB query which is executed each time a topic is loaded: There's really no point in fetching the question inside the Topic::formElements hook for registered members. You can literally stop doing any further checks and return the parent method response  if the Member::loggedIn()->member_id check returns true 😉

     

  2. I would strongly advise to use an application once you have to deal with database tables.

    1. It's much easier to maintain the schema via the Application Dev Center, you'll literally only have to set up the fields and the framework will take care of everything else for you. There's no need to create manually any Install, upgrade and uninstall code, like for plugins.
    2. Our support tools will try to fix only applications database tables and ignore any broken plugin database tables.
     

  3. I have few suggestions for this:)
    REST API for ideas
    Fire a webhook when somebody votes on an item and also when an item gets marked as completed.
     

     

    BTW, why are you using the confirmedDelete method inside the markCompleted

    		\IPS\Session::i()->csrfCheck();
    
    		\IPS\Request::i()->confirmedDelete();

    There's really no need for this AND it's quite confusing when one gets the deletion confirmation message;) 

×
×
  • Create New...