Jump to content

Daniel F

Invision Community Team
  • Posts

    6,559
  • Joined

  • Days Won

    37

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Posts posted by Daniel F

  1. Yea, even if the code is present, it won't run if Request->id isn't present:)
     

    To give you more insight, that's my bug report from today morning:

    Quote

    Our current globalTemplate body element contains following code:

    {{if isset( \IPS\Request::i()->id )}}data-pageID='{expression="(int) \IPS\Request::i()->id"}'{{endif}}

    The problem with this approach is that Request->id is not always present, for example sometimes we're using a different param name for the primary item like page_id instead of only id, in other cases we have only a string which we use to fetch the record or page based on the path so it's again not setting the Request::I()->id resulting in the missing pageID parameter.

    I guess it would be a better approach to set this programatically when needed.

     

  2. 10 minutes ago, Ihia said:

    Hi Guys

    Our background processes started reindexing about 10 days ago.

    Rather than shrinking it seems to just be growing and is now at 47 pages in the queue with NONE of them seemingly moving

    The warning message does say it can take some time but as I said it been about 10 days now and hasnt moved at all.

    Many thanks

    Could you please submit a ticket so that we can take a look a this.

  3. Is your globalTemplate customised? It's already there:

    {{if isset( \IPS\Request::i()->id )}}data-pageID='{expression="(int) \IPS\Request::i()->id"}'{{endif}}

    My demo board output:

    body class="ipsApp ipsApp_front ipsJS_has ipsClearfix cCmsDatabase_articles" data-controller="core.front.core.app,core.front.widgets.manager"  data-message=""  data-pageapp="cms" data-pagelocation="front" data-pagemodule="pages" data-pagecontroller="page" data-pageid="7"   data-pagename="articles.html"

     

  4. Welcome to part 3 ( Part 1 & Part 2 ) of our series for 3rd party developers.
     

    Let's recap the interesting stuff:
    A new extension was added to the core app to allow 3rd party apps to extend the achievements.
    Content Items can be marked as anonymous
    We have cleaned up our code and have removed almost all the deprecated methods and variables!

     

    One if the most concerning changes for IN_DEV users will probably be our new ACP warning once the CSRF Key is being exposed in the ACP

    csrfkey.png

     

    That's nothing to worry about, it's only returned with enabled IN_DEV mode, but please take it serious and try to avoid any redirect to any URL containing the CSRF key and containing user generated content.

  5. 1 hour ago, Maxxius said:

    @AdlagoI wonder how could we completely remove the icomoon from IPS 4.4 version?

    Where that font is it used exactly?

    Time to upgrade! 😉

    From the 4.5 changelog:

    Quote

    - Removed icomoon dependency from css. The icons which were created using this font have been replaced with FontAwesome and pure css equivalents. The icomoon files are still present, so they can be imported using custom.css if necessary.


     

  6. 8 minutes ago, Ramsesx said:

    Never heard of this. For example, some years ago IPS removed the chat system. There are now three chat applications available in the marketplace...

    There's indeed a rule for this in our guidelines https://invisioncommunity.com/developers/submission-guidelines/

    Quote

    Your resource must not replicate any functionality that already exists in Invision Community or re-introduce functionality that has been removed, excluding inconsequential cosmetic changes that require no backend changes.

     

×
×
  • Create New...