teraßyte

This is the current construct method of the file: public function __construct( Url|string $url, string $languageString, string $css ='ipsMenu_item', array $dataAttributes = [], bool $opensDialog = FALSE, ?string $icon = NULL, string $id = NULL, string $identifier = '' ) { $this->url = $url; $this->title = $languageString; $this->css = $css; $this->dataAttributes = $dataAttributes; $this->icon = $icon; $this->menuItem = $identifier ?: $languageString; if( !$id ) { $id = 'menuLink_' . md5($languageString ) . '_' . $this->identifier; } $this->id = $id; if( $opensDialog ) { $this->opensDialog(); } $this->addAttribute( 'data-menuItem', $languageString); } Here's a list of issues: The $this->identifier variable is always empty when used to create a missing $id. The last line that adds the data-menuItem attribute should use $this->menuItem rather than $languageString. [Not really a bug] After the class values are set at the top you should use those rather than the function variables. Here's the updated code with all the changes if you want to copy/paste it. 😋 public function __construct( Url|string $url, string $languageString, string $css ='ipsMenu_item', array $dataAttributes = [], bool $opensDialog = FALSE, ?string $icon = NULL, string $id = NULL, string $identifier = '' ) { $this->url = $url; $this->title = $languageString; $this->css = $css; $this->dataAttributes = $dataAttributes; $this->icon = $icon; $this->identifier = $identifier; $this->menuItem = $this->identifier ?: $this->title; if( !$id ) { $id = 'menuLink_' . md5($this->title ) . '_' . $this->identifier; } $this->id = $id; if( $opensDialog ) { $this->opensDialog(); } $this->addAttribute( 'data-menuItem', $this->menuItem ); }

The guide states: https://invisioncommunity.com/developers/docs/other-features/commerce/using-the-license-key-api-in-commerce-r75/ However, setting the setIdentifier variable to 1 sets the identifier value to 1 because it uses the setIdentifier value itself instead of the provided identifier value: $identifier = $this->getIdentifier( $key ); $providedIdentifier = isset( Request::i()->identifier ) ? Request::i()->identifier : NULL; if ( isset( Request::i()->setIdentifier ) and Request::i()->setIdentifier ) { if ( $identifier != $providedIdentifier ) { if ( $identifier or in_array( $key->identifier, array( 'name', 'email', 'username' ) ) ) { throw new ApiException( 'BAD_KEY_OR_ID', 101 ); } else { $cfields = $key->purchase->custom_fields; $cfields[ $key->identifier ] = Request::i()->setIdentifier; $key->purchase->custom_fields = $cfields; $key->purchase->save(); } } } elseif( $identifier != $providedIdentifier ) { throw new ApiException( 'BAD_KEY_OR_ID', 101 ); } The problem is on line 160: $cfields[ $key->identifier ] = Request::i()->setIdentifier; For it to work as the guide describes, it should be changed to: $cfields[ $key->identifier ] = $providedIdentifier;

Here are the steps to reproduce: Create a product Custom Field with the following settings Field Type: URL Leave all the other Yes/No settings disabled. Create a new product that generates a License Key and assign the custom field from #1 as the Identifier value. (I used a maximum of one use, but it shouldn't matter.) Now purchase the new product from the front end. View the purchase in ACP => It throws the following exception: Whoops\Exception\ErrorException thrown with message "trim(): Passing null to parameter #1 ($string) of type string is deprecated" Stacktrace: #5 Whoops\Exception\ErrorException in \applications\nexus\modules\admin\customers\purchases.php:128 #4 trim in \applications\nexus\modules\admin\customers\purchases.php:128 #3 IPS\nexus\modules\admin\customers\purchases:view in \system\Dispatcher\Controller.php:128 #2 IPS\Dispatcher\Controller:execute in \applications\nexus\modules\admin\customers\purchases.php:87 #1 IPS\nexus\modules\admin\customers\purchases:execute in \system\Dispatcher\Dispatcher.php:169 #0 IPS\Dispatcher:run in \admin\index.php:15 View the purchase on the front end => It throws the following exception: TypeError thrown with message "IPS\Helpers\Form::addDummy(): Argument #2 ($value) must be of type string, null given, called in \applications\nexus\sources\Package\Package.php on line 2507" Stacktrace: #10 TypeError in \system\Helpers\Form\Form.php:437 #9 IPS\Helpers\Form:addDummy in \applications\nexus\sources\Package\Package.php:2507 #8 IPS\nexus\Package:clientAreaPage in \applications\nexus\extensions\nexus\Item\Package.php:822 #7 IPS\nexus\extensions\nexus\Item\Package:clientAreaPage in \applications\nexus\sources\Purchase\Purchase.php:884 #6 IPS\nexus\Purchase:clientAreaPage in \system\Theme\Theme.php:3706 #5 IPS\Theme\theme_nexus_front_clients_purchase in \system\Theme\Dev\Template.php:151 #4 IPS\Theme\Dev\Template:__call in \applications\nexus\modules\front\clients\purchases.php:140 #3 IPS\nexus\modules\front\clients\purchases:view in \system\Dispatcher\Controller.php:128 #2 IPS\Dispatcher\Controller:execute in \applications\nexus\modules\front\clients\purchases.php:100 #1 IPS\nexus\modules\front\clients\purchases:execute in \system\Dispatcher\Dispatcher.php:169 #0 IPS\Dispatcher:run in \index.php:16

This is what I see when viewing a purchase info page in ACP: The invoices box needs some spacing from the custom fields box.

I was testing an AccountSettings extension in my application and I disable it based on a specific value. Disabling it means I return NULL inside getTab() based on the value, however, if the URL is accessed directly the page throws an exception instead of a proper error: Whoops\Exception\ErrorException thrown with message "Undefined variable $output" Stacktrace: #5 Whoops\Exception\ErrorException in \applications\core\modules\front\system\settings.php:152 #4 Whoops\Run:handleError in \applications\core\modules\front\system\settings.php:152 #3 IPS\core\modules\front\system\settings:manage in \system\Dispatcher\Controller.php:139 #2 IPS\Dispatcher\Controller:execute in \applications\core\modules\front\system\settings.php:104 #1 IPS\core\modules\front\system\settings:execute in \system\Dispatcher\Dispatcher.php:169 #0 IPS\Dispatcher:run in \index.php:16 The code should return an error if the tab is not accessible. Additionally, I'd like you to add a new extension function so we can override it and define a custom error for our needs.

As mentioned in the title, the class \IPS\Helpers\Menu\Link defines the $extraHtml variable but it's not used anywhere: public string $extraHtml = ''; I thought I could use it to add an image to my link, but the variable itself is only defined and not called/used anywhere (PHP or template).

Trying to use the License Key API throws this exception: TypeError thrown with message "Api::error(): Argument #1 ($code) must be of type int, string given, called in \applications\nexus\interface\licenses\index.php on line 334" Stacktrace: #1 TypeError in \applications\nexus\interface\licenses\index.php:48 #0 Api:error in \applications\nexus\interface\licenses\index.php:334 This happens because the call to the error() function on line 332 has the code and message variables switched: catch ( ApiException $e ) { $api->error( $e->getMessage(), $e->getCode() ); } It must be changed to: $api->error( $e->getCode(), $e->getMessage() );

Clicking on the + Create New button for a new product's Custom Field throws this exception: Whoops\Exception\ErrorException thrown with message "explode(): Passing null to parameter #2 ($string) of type string is deprecated" Stacktrace: #8 Whoops\Exception\ErrorException in \applications\nexus\sources\Package\CustomField.php:153 #7 explode in \applications\nexus\sources\Package\CustomField.php:153 #6 IPS\nexus\Package\CustomField:form in \system\Node\Controller.php:567 #5 IPS\Node\Controller:_addEditForm in \system\Node\Controller.php:464 #4 IPS\Node\Controller:form in \system\Dispatcher\Controller.php:128 #3 IPS\Dispatcher\Controller:execute in \system\Node\Controller.php:117 #2 IPS\Node\Controller:execute in \applications\nexus\modules\admin\store\fields.php:56 #1 IPS\nexus\modules\admin\store\fields:execute in \system\Dispatcher\Dispatcher.php:169 #0 IPS\Dispatcher:run in \admin\index.php:15 Based on Whoops debug code, the issue is that the $this->packages variable on line 153 is NULL: foreach ( array_filter( explode( ',', $this->packages ) ) as $id ) { try { $packages[] = Package::load( $id ); } catch ( OutOfRangeException ) { } } === P.S.: Merry Christmas! 🎅🎄🤶 I'll be posting a few more bugs as your gift! 😋

The ACP page to manage moderator permissions is okay, but the one to manage administrator permissions needs some styling:

Version 4.7.19: Version 5 Beta 9: While v4 is fast and reactive, the v5 tooltips are extremely slow and lag behind the cursor's position.

Version 4 had a fixed size that fit 3 button controls regardless of how many were displayed: Version 5 pushes everything to the very right without a minimum width for the control buttons: I'm not sure if you'll accept this as a bug or call it feedback, but I prefer similar things (text + badges in this case) all aligned in the same column instead of being all over the place.