teraßyte

After upgrading a test v4 database with some PHP blocks in it. I tried editing them on v5 but received this error when I tried to open the category they were into: Whoops\Exception\ErrorException: preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated (8192) #0 [internal function]: Whoops\Run->handleError(8192, 'preg_match_all(...', '\\applications\\...', 1063) #1 \applications\cms\sources\Blocks\Block.php(1063): preg_match_all('/\\{block="(.+?)...', NULL, Array) #2 \applications\cms\sources\Blocks\Block.php(1140): IPS\cms\Blocks\Block::getBlockMapping() #3 \system\Theme\Theme.php(3709) : eval()'d code(21): IPS\cms\Blocks\Block->getPages() #4 \system\Theme\Dev\Template.php(151): IPS\Theme\theme_cms_admin_blocks_rowHtml(Object(IPS\cms\Blocks\Block)) #5 \applications\cms\modules\admin\pages\blocks.php(140): IPS\Theme\Dev\Template->__call('rowHtml', Array) #6 \system\Node\Controller.php(301): IPS\cms\modules\admin\pages\blocks->_getRowHtml(Object(IPS\cms\Blocks\Block)) #7 \system\Node\Controller.php(352): IPS\Node\Controller->_getRow('s.7') #8 \system\Helpers\Tree\Tree.php(149): IPS\Node\Controller->_getChildren('s.7') #9 \system\Node\Controller.php(147): IPS\Helpers\Tree\Tree->__toString() #10 \applications\cms\modules\admin\pages\blocks.php(103): IPS\Node\Controller->manage() #11 \system\Dispatcher\Controller.php(139): IPS\cms\modules\admin\pages\blocks->manage() #12 \system\Node\Controller.php(117): IPS\Dispatcher\Controller->execute() #13 \applications\cms\modules\admin\pages\blocks.php(67): IPS\Node\Controller->execute() #14 \system\Dispatcher\Dispatcher.php(169): IPS\cms\modules\admin\pages\blocks->execute() #15 \admin\index.php(15): IPS\Dispatcher->run() #16 {main}

I upgraded a 4.x database with some pages that had no wrapper and a single PHP block in them. After the upgrade to v5, it's impossible to edit the page because the page editor HTML/JS is unavailable. For such pages, there should be another way to edit them other than using the Page Editor option on the front end since it obviously won't work without the proper HTML/JS. Unlike in v4, where we had a Content tab, v5 defaults to editing the content on the frontend in all cases.

I'm talking about the user menu available in ACP: Change My Details Theme AdminCP Language When you're using the language menu (#3): The mouse cursor indicates a click action (pointer) The entire row you're over is highlighted However, when using the theme menu (#2), neither is available (pointer cursor or highlighted row). === Another thing I don't like about the menu itself is that options #1 (details) and #3 (language) are shown in 2 rows, with the second row's text showing below the icon, instead of a single row. It makes the text less readable. If you're not going to make the menu larger, I see no reason to apply the ipsMenu_narrow class, the text should at least be aligned properly. Plus, the icon should ideally show in the middle of the vertical space rather than at the top. But I guess this is more feedback rather than a bug.

The text in the image below is supposed to be a badge: HTML code: <span class="ipsBadge ipsBadge--style7">Contains database: Articles</span>

The form to add a new achievement rule has a few issues, both when adding and editing a rule. === Adding a new rule (Location problem) Create a new rule Select the following options: When: Reaction is Given Click on all 3 links without changing any value: +Add a location condition +Add a milestone condition +Add a type condition Select a random choice from the Location box. (I used Album for this test.) Click on the +Add a category filter link. Issues: Close all 4 boxes without doing anything else and it will result in the +Add a category filter link being the only remaining one. The correct result here is that all 3 initial links should have reappeared and the category filter should have been hidden until the location box is reopened instead. === Adding a new rule (Location & Category filter problem) Create a new rule Select the following options: When: Reaction is Given Location: any value will work When changing the value in this dropdown a +Add a category filter link will appear. Issues: the +Add a category filter links should appear together with the Location box based on the dropdown's first value. This is not the case. If you close the Location box after changing its value, the +Add link won't reappear. If you add a category filter and edit the Location field afterward, the category filter box disappears. Closing also the Location box will still result in its +Add link not reappearing, either. This issue is always reproducible when you change any value in the Location box. === Adding a new rule (Milestone problem) Create a new rule Select the following options: When: Reaction is Given Milestone: enter a number for the reactions field (or change the dropdown value without adding a number) Type: simply click the + Add a type condition link without doing anything else. Issues: If you close the Milestone & Type boxes, the +Add links won't reappear. If you add a category filter and edit the Location field afterward, the category filter box disappears. Closing also the Location box will still result in its +Add link not reappearing, either. This issue is always reproducible when you change any value in the Milestone box (either dropdown or reactions value). If you skip opening the Type box after opening the Milestone one, the Type box/link will still work without issues. === Editing a rule Edit the default rule: Comment/reply posted is the user's 1st comment/reply First Post badge To the user making the post Issue: The edit form has no Milestone box/link from the start, so making any changes is impossible. === Other combinations can break the rule form in other ways, but the whole thing needs a good check overall. 🙄

When adding widgets on the page, if you search for a word that returns multiple results, clicking on the star to add the widget as a favorite the search results are reset. You have to search again the same term (even just adding a space) to make the results show up again. The results shouldn't be reset when clicking the star icon. === The opposite, removing a favorite, works just fine instead. The results are NOT reset if you click the star icon to disable it.