Jump to content

TSP

Clients
  • Posts

    6,678
  • Joined

  • Last visited

  • Days Won

    9

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Posts posted by TSP

  1. I'm moving the search box to be on the same line as the top breadcrumb. When doing so I noticed a difference in the HTML markup between the list items that were already there and added by javascript when you click "More options…"

    When you open the search on this community, the first item is:

    <li>
      <span class="ipsSideMenu_item ipsSideMenu_itemActive" data-ipsmenuvalue="all">
        <input type="radio" name="type" value="all" checked="" id="elQuickSearchRadio_type_all">
        <label for="elQuickSearchRadio_type_all" id="elQuickSearchRadio_type_all_label">Everywhere</label>
      </span>
    </li>

    And the Topics-item has the same HTML.

    However, when you click "More options" other options become available. Here is the HTML for one of them: 

    <li>
      <a href="#" class="ipsSideMenu_item" data-ipsmenuvalue="cms_pages_pageitem">
        <input type="radio" name="type" value="cms_pages_pageitem" id="elQuickSearchRadio_type_cms_pages_pageitem">
        <label for="elQuickSearchRadio_type_cms_pages_pageitem" id="elQuickSearchRadio_type_cms_pages_pageitem_label">Pages</label>
      </a>
    </li>

     

    The difference to note here is that for the first items there is a <span>-tag wrapping the items, while in the ones added by JS it's a <a>-element. 

    I presume this is a bug as I can't think of a reason it would be intentional. 

  2. I've had a custom widget where the code for the configuration-method contains a header. This works in 4.4, but in 4.5 it fails (at least when IN_DEV is active).

    <?
    	public function configuration( &$form=null )
    	{
     		if ( $form === null )
    		{
    	 		$form = new \IPS\Helpers\Form;
     		}
    
     		$form->add(  )
    		
     		$form->addHeader('livefeed_forumsettings');
    		$form->add(  );
    		
    		return $form;
     	}


    The error is: Trying to get property 'name' of non-object

    And is caused by the logic in applications/core/dev/html/front/widgets/formTemplate.phtml:

    {{if $input->name and \mb_substr( $input->name, 0, 12 ) != 'widget_adv__' and ! \in_array( $input->name, $visibilityFields )}}

    Fixing that specific check it'll fail other places though. 

    So some bugs for you to quash 🙂

    For now I guess I'll just remove the form header from the form, while I await your fix, unless you want us to sectionize widget settings in a different way than this. 

  3. I think it would be interesting to hear if there are any details you could share about what's been done in the background? What are some of these new processes etc. that have made things become better? I'm just genuinely curious, if there are any details/improvements you could talk about. 

    Anyway, welcome to the community forums as well, Olivia!

  4. 5 minutes ago, Paul E. said:

    I would like both these things as well. Is this possible, @TSP?

    Should be possible to achieve currently for future posts. 

    1) Make an account with the name Anonymous

    2) Choose this user account for the setting "Posts appear as posted by"

    3) In your language packs, find the string with key anon_poster_hash. Change it to whatever you'd like. If you wish for it to be removed, I think you can try to just translate it as &nbsp;

  5. Do people affected here by any chance have multiple memcache-servers defined? 

    I'm currently investigating some issues related to a lot of INSERT INTO core_store-queries with the same values being generated. One of the instances where this happens seems to be when one or multiple of the memcache-instances is unavailable. 

  6. 1 hour ago, bfarber said:

    Thanks, I've submitted a patch for review but I'll push off a fix for 4.5 given how low level the code is and how low priority and rare the issue itself is.

    While we are looking at this code. Why don't you just use isset instead of in_array? Seems to me it would be lighter in terms of performance. 

    Simply: if (isset($this->words[$k]))
    instead of: if (\in_array($k, array_keys($this->words)))

    Or am I missing some reason you use this approach, which to me seems like more overhead?

    I found a blog post on this: http://maettig.com/1397246220

    Quote

    The result really looks how you think it should look. Searching for a key in a hash table needs constant time, no matter how big the array is. That's exactly why we have hash tables, right? On the other hand, searching for a value in an array needs dramatically more time even on relatively small arrays with only 100 elements. For an array with 10000 elements in_array is more than 100 times slower.

    So never ever do in_array( $key, array_keys( $array ) ), that's just stupid.

    And some stackoverflow answers https://stackoverflow.com/questions/13483219/what-is-faster-in-array-or-isset

    I haven't looked any closer into this code, than just watching the video, but if $this->words contains all the language strings, then I would expect some performance improvement by changing to use isset or array_key_exists (if you need to account for that the value could be null). 

  7. New version available in Marketplace! The price of the plugin was also increased from 10 USD to 12,50 USD.

     

    1.2.1 - Only for Invision Community version 4.4 and later

    • New Behaviour: "Mark As Spammer" will now also hide/delete posts posted anonymously, if applicable. 
      This depends on your settings on the "Mark As Spammer"-tab in the Spam Prevention section of your Admin Control Panel.
       
      • New Setting: "Hide/delete their anonymous posts when member is marked as spammer" - (Default is ON)
        Please note: Changing the setting will not affect already queued background tasks to hide/delete a member content. 
         
    • New Behaviour: Anonymous posting will now count towards the members limit of posts per day and the flood control
      For example: If the Flood Control setting is set to 10 seconds, then a single member can't post a second post before it's been 10 seconds since their previous post. Previously the time value was not updated for the real author when they posted anonymously, meaning they could circumvent this flood control. This new behavior fixes this issue.
       
      • New setting: "Count anonymous posts against the real authors group settings for flood and posts per day control" - (Default is ON)
         
    • Fixed issue with the "All"-checkbox not working for the setting "Who can post anonymously"
    • Installing the plugin will now generate a value for the setting "Unique board anonymous key" (Not done on upgrade)
    • Removed hook on \IPS\Http\Url\Friendly, it was no longer needed after moving the function to check who posted anonymously
    • Removed some previous versions. The upgrade files for these versions didn't do anything and was therefor a waste of space.
    • Removed form field for post id on the "Check original author"-page
  8. An update has been released!

    1.2.0 - Only for Invision Community version 4.4 and later

    • The link for checking who posted anonymously has been changed. Uploading of a separate file is no longer needed. Just install/update the plugin.
      If you used a previous version and uploaded the an additional file, please feel free to delete it from your installation. Location of the file in your community folder: applications/core/extensions/core/ModCp/CheckAnon.php
       
    • New Feature: Force Anonymous Posting
      This lets you decide that members in certain forums will have no choice in whether posts will be posted anonymously. The checkbox to post anonymously will still be visible, but will be disabled and displayed as checked. There is also a different language string that explains why the checkbox is checked and disabled.
       
      • New Setting: "Force Anonymous Posting in" - Choose which forums to force anonymous posts in
        Please note: The selected forums will also need to have been selected in the setting: "Can Post Anonymously in"
         
      • New setting: "Groups that are not forced" - Choose member groups that can bypass anonymous posting
        The checkbox to post anonymously will still be checked by default in forums where anonymous posting is enforced, but members in these groups can choose to uncheck it. 
         
      • New setting: "Turn off 'Post Before Register' in forums where anonymous posting is enforced" (Default is ON)
        The plugin is not fully compatible with the "Post Before Register"-feature (PBR). Guests that write posts with the PBR will not be able to choose to post anonymously, neither would posts written with PBR, in a forum that force anonymous posting, be changed to an anonymous post upon completing the register process.
         
    • New Feature: Daily task to remove original author link after a certain number of days. (Default is never)
      The task also deletes some other data stored for debugging purposes.
    • Settings have been rearrangered and broken up into two sections: "Basic Settings" and "Advanced Settings".
       
    • The guest group is no longer selectable for group settings.
       
    • Fixed bug that made you unable to uncheck the "All"-checkbox on settings for groups and forums if you had previously checked it. 
      Circumventing the issue was possible by unchecking it, choosing some forums/groups. Save. Then uncheck the forums and save again.
       
    • Fixed logic that caused the Post Before Register-feature to break in forums where anonymous posting was enabled.
       
    • Fixed bug that caused issues with the moderator action to split a topic.
       
    • Large parts of the code was refactored. Mostly to improve readability of it for myself and do some minor improvements. 

     

     

  9. On 4/9/2019 at 12:51 AM, Gaius Kong said:

    I did try to use this way, but it didn't work -- 

    I created a user with an account name in the Mandarin Chinese language, not an account with an English name. 

    I would just wait for your plugin update. Thank you. 

    Could you clarify in what way it didn't work to do it that way? Could I get access to the admin panel for the installation to test myself?

    I can "only" reproduce an issue when the plugin is set up to let anonymous posts appear as guest posts, so if there is any other issue here, I would like to be aware, as I've not been able to reproduce issues with a dummy account in that setting. 

  10. On 4/6/2019 at 12:24 AM, Gaius Kong said:

    I just purchased and experience the same issue.

    Hope this gets resolved as soon as possible. Anonymous posting is interesting and useful. 

     

    You can circumvent the issue by creating a dummy account and choosing that account for the setting "Posts appear as posted by". 

    Once again sorry for the inconvenience. I've just started looking closer into the issue. 

  11. 2 hours ago, Donald Meek said:

    i got this then figured out i can not use it as is.. since i am on a cloud based invision plan they will not do the file upload

    so i am stuck

    can i get a refund?

    can you make it so it will work thru adminpan

     

    Hello, 

    Send them a ticket and ask nicely to do the file upload. As far as I’ve heard they are willing to do some uploads on request.

  12. @Brainy S. Sorry for my late reply. 

    I've noted this, but I'm not sure when I'll be able to spend time adding it. 

    If it is added I think it's going to be a setting whether it should remember that you posted anonymously previously in the topic or not. Currently it's intentional, as I don't want to reveal the identity of who posted anonymously, even in those cases where the person that posted something anonymously is the same person being logged in. (Which is also why I don't allow people to edit their own anonymous posts either etc.)

  13. Hello, 

    There is no indication in the mobile menu on which account you're logged into. There is no profile image or member name. 

    I suggest that you add the member name to the Sign Out-button, so it'll say for example: Sign Out TSP

    Alternatively you could have a small line at the top of the mobile user menu with the avatar and user name next to it, above the sign out-button or the message/notification/report-icons.

    Thanks for considering this small change that I feel will improve the mobile user experience.

  14. I've now released an update here: https://invisioncommunity.com/files/file/7862-post-anonymously-in-forums/

    These are the release notes: 

    1.1.0:

    • A new setting has been added that lets you log to the moderator log who have checked the identity behind anonymous posts
    • The "Check anonymous" link on posts have been moved from the IP address area to the post controls below the post
    • "Check anonymous" will now display the result inside an ipsDialog, so you don't leave the page upon left-clicking it
    • Some safe guards have been put in place in order to prevent issues elsewhere in the suite from causing a post to be double-posted or be posted as the actual user.

    I also changed some of the images on the file page. 

    Price for new customers has been increased from 7 USD to 10 USD. 

    This file is no longer 4.1 compatible or tested for 4.1. This version is made for 4.2.

     

    IPS42-PostAnonymously110-AnonPostCheckAnon.png

    5992ac1363f28_Skjermbilde2017-08-15kl_10_08_19.png.fc681df79f51eb195f93b60896e69cbb.png

    IPS42-PostAnonymously110-ModeratorLog.png

    IPS42-PostAnonymously110-CheckAnonInline.png

  15. On 13.6.2017 at 5:05 PM, Eerand Wright said:

    Any chance we can get this updated to 4.2? Will definitely pay additional. My forum depends on this plugin.

    Are you experiencing any issues on 4.2? It seems to work for me with some quick testing. 

  16. 1 hour ago, Shyuan said:

    Hi @TSP I tried creating a topic with anonymous function enabled, but it doesn't change the "Username" to "Guest xxxxx". I am using latest IPS version 4.1.17.1. Any similar report? Thank you in advanced. :)

    My plugin settings allows all member groups to post anonymously, only admin can see the real identity and can post anonymously in all forum sections. I can't see what's causing it to not working.

    If you could send me more details in a personal message with a link to a post like that on your forums, then that would be appreciated. :)

×
×
  • Create New...