[4.7.14] Bug in template core > front > global > siteSocialProfiles

[teraßyte]

In the latest 4.7.14 version, the template core > front > global > siteSocialProfiles was changed to add support for X (former Twitter) share link, but the <LI> element was mistakenly changed to an <A> element instead.

 

4.7.13 version:

<li class='cUserNav_icon'>

4.7.14 version:

<a class='cUserNav_icon'>

 

You can easily compare it in the Theme Differences tool, too: https://invisioncommunity.com/index.php?app=core&module=system&controller=plugins&do=diff

[Jim M]

Thank you for bringing this issue to our attention! I can confirm this should be further reviewed and I have logged an internal bug report for our development team to investigate and address as necessary, in a future maintenance release.

 

[sadams101]

Please also fix the missing alt tags on these images...something like this:

{{if \IPS\Settings::i()->site_social_profiles AND $links = json_decode( \IPS\Settings::i()->site_social_profiles, TRUE ) AND \count( $links )}}
	{{foreach $links as $profile}}
		<li class='cUserNav_icon'>
            {{if $profile['value'] == 'x'}}
            <a href='{$profile['key']}' target='_blank' class='cShareLink cShareLink_x' rel='noopener noreferrer' alt='Visit Us On X'><img src="{resource="logos/x.svg" app="core" location="global"}" width='13' height='12' style='vertical-align: middle'></a>
            {{else}}
			<a href='{$profile['key']}' target='_blank' class='cShareLink cShareLink_{$profile['value']}' rel='noopener noreferrer' alt='Visit Us On {$profile['value']}'><i class='fa fa-{$profile['value']}'></i></a>
		    {{endif}}
        </li>
	{{endforeach}}
{{endif}}

 

[sadams101]

After fixing this and clearing my cache, the Facebook logo is loading as the X logo, or the X logo is missing.

<li class='cUserNav_icon'>

The logo is in my resources, but for some reason is not loading properly. Any ideas on how to fix this?

[sadams101]

I just want to mention that the X logo was a white X, so it did not show up at all on the default white background my site uses. After changing it to black it worked.

[Jim M]

Our team will assess this in the bug report mentioned 🙂 . This is all likely related to certain CSS classes.

[Fast Lane!]

Let us know when updated.  Will hold off on updating until then :).

[Daniel F]

This was  patched yesterday

[Marc Stridgen]

This issue has been resolved in the recently released 4.7.15 version. Please update your site if you are still experiencing the issue, and let us know if you see any reoccurrence.