SoloInter Posted January 10, 2018 Posted January 10, 2018 (edited) I get a new issue. This is what I did : 1. Go on a topic who just have 1 post. 2. Tried to merge the only one post of this topic with an other topic. So I copy past the url of the topic. 3. I also check the box to have a link in the old category. After confirm all of that I get a crash : Désolé, il y a un problème Quelque chose s’est mal passé.Veuillez réessayer. Code d’erreur EX0 Cette erreur est probablement causée par l’application Trophées & Médailles. Si le problème persiste, désactivez-la et contactez son auteur pour obtenir du support. OutOfRangeException: (0) #0 /var/www/internazionale.fr/www/forums/applications/trophies/sources/Trophy/MemberTrophy.php(86): IPS\Patterns\_ActiveRecord::load(24) #1 /var/www/internazionale.fr/www/forums/system/Patterns/ActiveRecord.php(307): IPS\trophies\Trophy\_MemberTrophy->get_item() #2 /var/www/internazionale.fr/www/forums/system/Theme/Theme.php(824) : eval()'d code(174): IPS\Patterns\_ActiveRecord->__get('item') #3 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_trophies_front_global->postbit(Object(IPS\Member)) #4 /var/www/internazionale.fr/www/forums/system/Theme/Theme.php(824) : eval()'d code(1809): IPS\Theme\_SandboxedTemplate->__call('postbit', Array) #5 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_forums_front_topics->postContainer(Object(IPS\forums\Topic), Object(IPS\forums\Topic\Post), Array, '') #6 /var/www/internazionale.fr/www/forums/system/Theme/Theme.php(824) : eval()'d code(3938): IPS\Theme\_SandboxedTemplate->__call('postContainer', Array) #7 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_forums_front_topics->topic(Object(IPS\forums\Topic), Array, NULL, Array, NULL, '\n\n\t\n\t<ul class=...', Array) #8 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(408): IPS\Theme\_SandboxedTemplate->__call('topic', Array) #9 /var/www/internazionale.fr/www/forums/system/Dispatcher/Controller.php(96): IPS\forums\modules\front\forums\_topic->manage() #10 /var/www/internazionale.fr/www/forums/system/Content/Controller.php(50): IPS\Dispatcher\_Controller->execute() #11 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(39): IPS\Content\_Controller->execute() #12 /var/www/internazionale.fr/www/forums/system/Dispatcher/Dispatcher.php(146): IPS\forums\modules\front\forums\_topic->execute() #13 /var/www/internazionale.fr/www/forums/index.php(12): IPS\_Dispatcher->run() #14 {main} Topic still existing and post still inside. Nothing change. But I can't get the content anymore. I have this same error if I want to go inside the topic. Edited January 10, 2018 by Archimed
SoloInter Posted January 10, 2018 Posted January 10, 2018 (edited) An other issue finded when I click this link : https://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=125&tab=comments#comment-1224037 OutOfRangeException: (0) #0 /var/www/internazionale.fr/www/forums/applications/trophies/sources/Trophy/MemberTrophy.php(86): IPS\Patterns\_ActiveRecord::load(24) #1 /var/www/internazionale.fr/www/forums/system/Patterns/ActiveRecord.php(307): IPS\trophies\Trophy\_MemberTrophy->get_item() #2 /var/www/internazionale.fr/www/forums/uploads/template_16_29022196a31af0d1392014b921f5828b_global.php(175): IPS\Patterns\_ActiveRecord->__get('item') #3 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\Cache\class_trophies_front_global->postbit(Object(IPS\Member)) #4 /var/www/internazionale.fr/www/forums/uploads/template_16_7a734b11232065691bc1176040cb26ad_topics.php(1810): IPS\Theme\_SandboxedTemplate->__call('postbit', Array) #5 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\Cache\class_forums_front_topics->postContainer(Object(IPS\forums\Topic), Object(IPS\forums\Topic\Post), Array, '') #6 /var/www/internazionale.fr/www/forums/uploads/template_16_7a734b11232065691bc1176040cb26ad_topics.php(3939): IPS\Theme\_SandboxedTemplate->__call('postContainer', Array) #7 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\Cache\class_forums_front_topics->topic(Object(IPS\forums\Topic), Array, NULL, Array, Object(IPS\forums\Topic), '\n\n\t\n\t<ul class=...', Array) #8 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(408): IPS\Theme\_SandboxedTemplate->__call('topic', Array) #9 /var/www/internazionale.fr/www/forums/system/Dispatcher/Controller.php(96): IPS\forums\modules\front\forums\_topic->manage() #10 /var/www/internazionale.fr/www/forums/system/Content/Controller.php(50): IPS\Dispatcher\_Controller->execute() #11 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(39): IPS\Content\_Controller->execute() #12 /var/www/internazionale.fr/www/forums/system/Dispatcher/Dispatcher.php(146): IPS\forums\modules\front\forums\_topic->execute() #13 /var/www/internazionale.fr/www/forums/index.php(12): IPS\_Dispatcher->run() #14 {main} But this link is ok : page 1 until 123 is okhttps://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=123 after it doesn't work :https://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=124https://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=125 Edited January 10, 2018 by Archimed
Fosters Posted January 11, 2018 Author Posted January 11, 2018 (edited) 16 hours ago, Archimed said: I get a new issue. This is what I did : 1. Go on a topic who just have 1 post. 2. Tried to merge the only one post of this topic with an other topic. So I copy past the url of the topic. 3. I also check the box to have a link in the old category. After confirm all of that I get a crash : Désolé, il y a un problème Quelque chose s’est mal passé.Veuillez réessayer. Code d’erreur EX0 Cette erreur est probablement causée par l’application Trophées & Médailles. Si le problème persiste, désactivez-la et contactez son auteur pour obtenir du support. OutOfRangeException: (0) #0 /var/www/internazionale.fr/www/forums/applications/trophies/sources/Trophy/MemberTrophy.php(86): IPS\Patterns\_ActiveRecord::load(24) #1 /var/www/internazionale.fr/www/forums/system/Patterns/ActiveRecord.php(307): IPS\trophies\Trophy\_MemberTrophy->get_item() #2 /var/www/internazionale.fr/www/forums/system/Theme/Theme.php(824) : eval()'d code(174): IPS\Patterns\_ActiveRecord->__get('item') #3 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_trophies_front_global->postbit(Object(IPS\Member)) #4 /var/www/internazionale.fr/www/forums/system/Theme/Theme.php(824) : eval()'d code(1809): IPS\Theme\_SandboxedTemplate->__call('postbit', Array) #5 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_forums_front_topics->postContainer(Object(IPS\forums\Topic), Object(IPS\forums\Topic\Post), Array, '') #6 /var/www/internazionale.fr/www/forums/system/Theme/Theme.php(824) : eval()'d code(3938): IPS\Theme\_SandboxedTemplate->__call('postContainer', Array) #7 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\class_forums_front_topics->topic(Object(IPS\forums\Topic), Array, NULL, Array, NULL, '\n\n\t\n\t<ul class=...', Array) #8 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(408): IPS\Theme\_SandboxedTemplate->__call('topic', Array) #9 /var/www/internazionale.fr/www/forums/system/Dispatcher/Controller.php(96): IPS\forums\modules\front\forums\_topic->manage() #10 /var/www/internazionale.fr/www/forums/system/Content/Controller.php(50): IPS\Dispatcher\_Controller->execute() #11 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(39): IPS\Content\_Controller->execute() #12 /var/www/internazionale.fr/www/forums/system/Dispatcher/Dispatcher.php(146): IPS\forums\modules\front\forums\_topic->execute() #13 /var/www/internazionale.fr/www/forums/index.php(12): IPS\_Dispatcher->run() #14 {main} Topic still existing and post still inside. Nothing change. But I can't get the content anymore. I have this same error if I want to go inside the topic. 12 hours ago, Archimed said: An other issue finded when I click this link : https://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=125&tab=comments#comment-1224037 OutOfRangeException: (0) #0 /var/www/internazionale.fr/www/forums/applications/trophies/sources/Trophy/MemberTrophy.php(86): IPS\Patterns\_ActiveRecord::load(24) #1 /var/www/internazionale.fr/www/forums/system/Patterns/ActiveRecord.php(307): IPS\trophies\Trophy\_MemberTrophy->get_item() #2 /var/www/internazionale.fr/www/forums/uploads/template_16_29022196a31af0d1392014b921f5828b_global.php(175): IPS\Patterns\_ActiveRecord->__get('item') #3 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\Cache\class_trophies_front_global->postbit(Object(IPS\Member)) #4 /var/www/internazionale.fr/www/forums/uploads/template_16_7a734b11232065691bc1176040cb26ad_topics.php(1810): IPS\Theme\_SandboxedTemplate->__call('postbit', Array) #5 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\Cache\class_forums_front_topics->postContainer(Object(IPS\forums\Topic), Object(IPS\forums\Topic\Post), Array, '') #6 /var/www/internazionale.fr/www/forums/uploads/template_16_7a734b11232065691bc1176040cb26ad_topics.php(3939): IPS\Theme\_SandboxedTemplate->__call('postContainer', Array) #7 /var/www/internazionale.fr/www/forums/system/Theme/SandboxedTemplate.php(56): IPS\Theme\Cache\class_forums_front_topics->topic(Object(IPS\forums\Topic), Array, NULL, Array, Object(IPS\forums\Topic), '\n\n\t\n\t<ul class=...', Array) #8 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(408): IPS\Theme\_SandboxedTemplate->__call('topic', Array) #9 /var/www/internazionale.fr/www/forums/system/Dispatcher/Controller.php(96): IPS\forums\modules\front\forums\_topic->manage() #10 /var/www/internazionale.fr/www/forums/system/Content/Controller.php(50): IPS\Dispatcher\_Controller->execute() #11 /var/www/internazionale.fr/www/forums/applications/forums/modules/front/forums/topic.php(39): IPS\Content\_Controller->execute() #12 /var/www/internazionale.fr/www/forums/system/Dispatcher/Dispatcher.php(146): IPS\forums\modules\front\forums\_topic->execute() #13 /var/www/internazionale.fr/www/forums/index.php(12): IPS\_Dispatcher->run() #14 {main} But this link is ok : page 1 until 123 is okhttps://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=123 after it doesn't work :https://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=124https://www.internazionale.fr/forums/index.php?/topic/91-bienvenue-aux-nouveaux/&page=125 Thank you for notifying us of the issue. We will look into the problem. In the meantime, please deactivate the application until we can push out a new release. In the future, we would appreciate that you contact us for bugs before you post a review. Edited January 11, 2018 by Fosters
SoloInter Posted January 11, 2018 Posted January 11, 2018 How long for fix this issue ? 1 week ? 1 month ? 1 year ? I post a review because if I saw that before, that there are still some bugs on the app, I would not purchased it right now. I think, people who spend money in these app need to know if it's not working correctly. Don't worry, if you fix bugs, I will write something beautiful and delete my last review.
Fosters Posted January 11, 2018 Author Posted January 11, 2018 (edited) I'm sorry to see that you have so many problems with this app. Have you deleted any trophies direct in the database? Or have you deleted any categories in the ACP? All the "different" errors have the same reason: At least one of your members has a trophy or medal, which was deleted, without deleting the associated data. Could we probably get ACP access credentials to investigate this over the weekend? Edited January 11, 2018 by Fosters
SoloInter Posted January 11, 2018 Posted January 11, 2018 (edited) @Fosters I found several entries in ibf_trophies_members with an trophy_id who doesn't exist anymore. I delete all of this entries ? Edit : I deleted all records with a trophy id who doesn't exist anymore. And issue fixed ! THANKS. I will update my review. Edited January 11, 2018 by Archimed Fosters 1
Fosters Posted January 11, 2018 Author Posted January 11, 2018 Thanks, I'm still worried that this happened at all(if it's a valid bug we have to fix it) and can't reproduce it. Did you delete the trophy within the ACP? Or direct in the database via phpMyAdmin? If it was via the ACP, did you get any errormessage?
SoloInter Posted January 11, 2018 Posted January 11, 2018 (edited) I will try to summarize the different actions that I undertook and that generated these bugs. 1. Download and install 2. I tried to create my first trophy 3. I realized that I had just created a trophy category 4. I deleted the category and then created a new one called "Trophies" 5. I created trophies by choosing a FA icon About that, when creating a trophy, it is active directly and notifications rain. When copying a trophy, it creates a trophy that is disabled. Normal since it has the same information. I think it's convenient, it allows you to edit the trophy several times without it actually exists in the eyes of members, as long as it has not been activated. All this to say that it would be convenient to have a button "active / disabled" when creating a trophy or a medal, allowing to finalize the action later. 6. Visible trophies on the profiles, I create others. 7. At this point, I may have deleted one or two to redo them. They could have been assigned to members before they were deleted. 8. I want to change the FA icon into custom images. The edition of existing trophies does not work, I am obliged to delete them and recreate them by indicating the image that I wish. Like that, it works. 9. So I create everything again, everything is clean and the trophies are distributed blithely. 10. I realize that I have too many trophies, I want to modify the behavior of some of them so that they can be replaced one by one. 11. I edit the different trophies, I specify the trophies to replace. But members still have the old trophies previously acquired, displayed on their profile when posting a message. 12. So I delete all the trophies again to recreate everything properly as I wanted. From there, I did not touch it anymore. I had to change the display size maybe, but the bug appeared a few days later. Here are the manipulations I made a few moments before: 1. I am in a forum reserved to the staff of the site. I correct an article posted as a topic by one of my editors. 2. I want to move his message to an existing topic. So I check the message, choose the function "merge" and I copy / paste the URL of the topic. 3. I validate and there I already have an error like the one I posted in this topic. 4. Later, I click on page 125 which is displayed as a button in the "Last active topics" area and I have this similar error that appears. After deleting the data that had a trophy not present in the trophy table, from the ibf_trophies_members table, everything works again. I have not tested to move / merge at the moment. Edited January 11, 2018 by Archimed Fosters 1
The Old Man Posted January 11, 2018 Posted January 11, 2018 Not had these issues myself yet. A rebuild tool to quickly remove all automatic awards from all members or selected groups and reallocate again would be really handy, especially if you've changed the rules or for peace of mind if unsure whether some members got awards unintentionally whilst you were in the process of creating them. Fosters and SoloInter 2
Fosters Posted January 12, 2018 Author Posted January 12, 2018 6 hours ago, The Old Man said: Not had these issues myself yet. A rebuild tool to quickly remove all automatic awards from all members or selected groups and reallocate again would be really handy, especially if you've changed the rules or for peace of mind if unsure whether some members got awards unintentionally whilst you were in the process of creating them. We like this idea and added this to our roadmap. We don't have a timeframe on when it might be released. The Old Man and SoloInter 1 1
The Old Man Posted January 12, 2018 Posted January 12, 2018 Also I've been setting up some Font Awesome trophies etc but didn't want to reveal them to my community yet so I've only allowed Admin group to access Trophies for now in the ACP Applications Settings. However, I've just realised that the awards are visible to guests who can see them in member profiles, so I'm assuming they're visible to members too; aargh! Some of my members appearing to have been award awards for say posting 25 topic, even though they are new members or haven't posted. What's the best option, should I delete all the awards and start again, or wait until the rebuild tool is available to correct any unintentional awards whilst I was creating and editing them. Many thanks!
Fosters Posted January 12, 2018 Author Posted January 12, 2018 (edited) 8 hours ago, The Old Man said: Also I've been setting up some Font Awesome trophies etc but didn't want to reveal them to my community yet so I've only allowed Admin group to access Trophies for now in the ACP Applications Settings. However, I've just realised that the awards are visible to guests who can see them in member profiles, so I'm assuming they're visible to members too; aargh! Some of my members appearing to have been award awards for say posting 25 topic, even though they are new members or haven't posted. What's the best option, should I delete all the awards and start again, or wait until the rebuild tool is available to correct any unintentional awards whilst I was creating and editing them. Many thanks! We don't have any timeline on the rebuild tool, so I would encourage you to re-make your awards in the meantime. Unfortunately, we've been extremely busy with our day job. Can you do us a favor and verify the bug that Members can actually see Trophies that should only be accessed by Admins? If you're able to confirm bug, please initiate a Support Ticket on our website Fosters.Tech for us to track the issue. FostersJ Edited January 12, 2018 by Fosters
Fosters Posted January 12, 2018 Author Posted January 12, 2018 (edited) On 12/29/2017 at 7:02 PM, jinnie said: Is there a way to display 4 medals/trophies in a row on the postbit instead of 3? As a follow-up to you @jinnie, please make sure you are using the latest version of Trophies & Medals. We included a feature to allow multiple trophies and medals based upon your settings. Edited January 12, 2018 by Fosters
The Old Man Posted January 13, 2018 Posted January 13, 2018 6 hours ago, Fosters said: We don't have any timeline on the rebuild tool, so I would encourage you to re-make your awards in the meantime. Unfortunately, we've been extremely busy with our day job. Can you do us a favor and verify the bug that Members can actually see Trophies that should only be accessed by Admins? If you're able to confirm bug, please initiate a Support Ticket on our website Fosters.Tech for us to track the issue. FostersJ Hi, Okay thanks. I've been able to confirm the bug, I've just created a dummy test account with members permisssions to test with, and like guests, it can view all the trophies in any members profile, despite only the Admin group having access to the Trophy modules. Fosters 1
Fosters Posted January 13, 2018 Author Posted January 13, 2018 3 hours ago, The Old Man said: Hi, Okay thanks. I've been able to confirm the bug, I've just created a dummy test account with members permisssions to test with, and like guests, it can view all the trophies in any members profile, despite only the Admin group having access to the Trophy modules. That's correct. There's no check implemented, nobody of us had this scenario in mind. I have implemented this for the next bugfix release. The Old Man 1
Fosters Posted January 13, 2018 Author Posted January 13, 2018 On 5.12.2017 at 11:48 PM, evandixon said: I found and fixed a race condition that results in trophies being awarded to members who do not meet the criteria. The issue is in /sources/Trophy/Trophy.php on line 193, inside the function formatFormValues. #$this->crdata = $data; $values['crdata'] = $data; $this->faicon = $values['faicon']; if ( !$this->id ) { $this->save(); } // ... return $values The problem is that `$this->crdata` is not being set before `$this->save()` is called. IPS will later use the results of this function (`$values`) to update the model, but not before an active background task can assign the trophy. The simplest fix is to simply uncomment the line of code on line 193. I have not encountered this issue after applying this fix, but because of the way race conditions work, that doesn't necessarily prove anything. Is this still the case? I can't reproduce this.
The Old Man Posted January 13, 2018 Posted January 13, 2018 3 hours ago, Fosters said: That's correct. There's no check implemented, nobody of us had this scenario in mind. I have implemented this for the next bugfix release. Awesome, thank you!
Fosters Posted January 16, 2018 Author Posted January 16, 2018 (edited) We've spent the weekend focusing on several applications to address bug fixes that were brought up in the IPS Support Topics. We'd like to thank everyone for their patience while we get back into groove of things. Trophies & Medals: 6 bugs, 1 enhancement, 1 new feature [Enhancement] Move delete button to the end [Bug] No check on View permission [New Feature] New tab for all notifications such as inline notifications, PM, and email [Bug] Fix notification from user as reported by IPS user @evandixon [Bug] Deprecate submit navbar tab [Bug] Cannot change icon from png to fa as reported by IPS user @Archimed [Bug] Merge topic as reported by IPS user @Archimed [Bug] High pagecount as reported by IPS user @Archimed We are planning for a release date in about a week for further testing, but please follow the Marketplace file and you will be notified.j Edited January 16, 2018 by Fosters The Old Man and SoloInter 2
evandixon Posted January 16, 2018 Posted January 16, 2018 On 1/13/2018 at 2:13 AM, Fosters said: Is this still the case? I can't reproduce this. Applying that change in production fixed the issue on the previous version. I haven't added any new trophies or medals since upgrading to the latest version, but I did see that you applied that change.
leonovich_J Posted January 18, 2018 Posted January 18, 2018 Hello How to delete or add rewards through a user profile Neither I nor the moderators see any buttons, although all permissions are given
Fosters Posted January 19, 2018 Author Posted January 19, 2018 6 hours ago, leonovich_J said: Hello How to delete or add rewards through a user profile Neither I nor the moderators see any buttons, although all permissions are given Hi, do you see the following button: You can also use the +Create menu to award medal. Make sure you also set the Moderators permission in ACP > Members > Staff - Moderators. Click on "Medals" tab > Can award Medals to members? Let me know if that works. Thanks!j SoloInter and leonovich_J 1 1
Fosters Posted January 20, 2018 Author Posted January 20, 2018 A new version was released fixing the icon and permission issue The Old Man 1
The Old Man Posted January 20, 2018 Posted January 20, 2018 (edited) Thanks for this! Each time it fails to download the tar for me, it keeps saying Download Failed. Downloading fine, now! Edited January 20, 2018 by The Old Man
Recommended Posts