evandixon

I updated my site's Google Analytics integration today and noticed that the change wasn't logged in the Administrator Logs. Any changes to this can impact all pages, so it would be useful to have this logged in the event someone were to add a problematic script.

I have a test instance of 4.5.1 inaccessible to the web, requiring HTTP Basic Auth for everything except /api. When I try to use the new "Sign into Marketplace" feature, I get this error message: This is most likely a result of the basic auth, but I'm unable to find what specific endpoint the marketplace server is hitting. Anyone know if there's an endpoint I can exclude from basic auth to make this work?

Applying that change in production fixed the issue on the previous version. I haven't added any new trophies or medals since upgrading to the latest version, but I did see that you applied that change.

I found and fixed a race condition that results in trophies being awarded to members who do not meet the criteria. The issue is in /sources/Trophy/Trophy.php on line 193, inside the function formatFormValues. #$this->crdata = $data; $values['crdata'] = $data; $this->faicon = $values['faicon']; if ( !$this->id ) { $this->save(); } // ... return $values The problem is that `$this->crdata` is not being set before `$this->save()` is called. IPS will later use the results of this function (`$values`) to update the model, but not before an active background task can assign the trophy. The simplest fix is to simply uncomment the line of code on line 193. I have not encountered this issue after applying this fix, but because of the way race conditions work, that doesn't necessarily prove anything.

Fixed this myself with a manual code change, by setting ~/extensions/core/Notifications/TrophyAndMedal.php line 58 to be equal to line 69. Old value: 'author' => \IPS\Member::load( 1 ), // [Optional] The user whose photo should be displayed for this notification New value: 'author' => \IPS\Member::load( \IPS\Settings::i()->trophy_notification_sender ), // [Optional] The user whose photo should be displayed for this notification

I set the Notification Sender to a specific user, but when Trophies are awarded, the resulting notifications show as being from the user with ID 1. Medal notifications are working properly. I'd appreciate assistance in getting this working.