Jump to content

Pages SuperGrid support


opentype

Recommended Posts

Posted

In Test Validation Html5, a recurring error occurs

Error: Element div not allowed as child of element h2 in this context. (Suppressing further errors from this subtree.)

From line 1087, column 5; to line 1087, column 31

	↩			↩				<div class='ipsType_break'>

Example - from my source code

<h2 class='ipsSpacer_both'>
				
				
			
				<div class='ipsType_break'>
					<a href="https://nophelet.com/advice/ltime/%D0%B1%D1%8F%D0%BB-%D0%B3%D1%8A%D0%BB%D1%8A%D0%B1-r12/" title="Read more about Бял гълъб">
						Бял гълъб
					</a>
				</div>
</h2>
  

How can I remove this error validation html5?

Posted

PS. When editing a  div - span class in the developer Chrome browser tool - it looks like it will work - but will it have no side effect?

747915939_Screenshotat2018-09-09195200.thumb.png.2ebe70881679dc92ae4b99b53c5a3373.png

Posted

In Database Templates - Supergrid Frontpage - entry I edit this (only div -> span)

<h2 class='ipsSpacer_both'>
				{{if $record->prefix()}}
					{template="prefix" group="global" app="core" params="$record->prefix( TRUE ), $record->prefix()"}
				{{endif}}
				{{if $record->isFutureDate() || $record->mapped('pinned') || $record->mapped('featured') || $record->hidden() === -1 || $record->hidden() === 1}}
					{{if $record->isFutureDate()}}
					<span class="ipsBadge ipsBadge_icon ipsBadge_warning" data-ipsTooltip title='{$record->futureDateBlurb()}'><i class='fa fa-clock-o'></i></span>
					{{elseif $record->hidden() === -1}}
					<span class="ipsBadge ipsBadge_icon ipsBadge_small ipsBadge_warning" data-ipsTooltip title='{$record->hiddenBlurb()}'><i class='fa fa-eye-slash'></i></span>
					{{elseif $record->hidden() === 1}}
					<span class="ipsBadge ipsBadge_icon ipsBadge_small ipsBadge_warning" data-ipsTooltip title='{lang="pending_approval"}'><i class='fa fa-warning'></i></span>
					{{endif}}
				{{endif}}
			
				<span class='ipsType_break'>
					<a href="{$record->url()}" title="{lang="read_more_about" sprintf="$record->_title"}">
						{$record->_title}
					</a>
				</span>
</h2>
  

Everything on my page works correctly and test validation is OK:smile:

https://validator.w3.org/nu/?doc=https%3A%2F%2Fnophelet.com%2Fadvice%2F

Posted
5 hours ago, Gauravk said:

How can I reduce that by half at least, as we have long articles that ended up being extra long due to this generous spacing?

Plus 1 to this - we could really do with a solution to this too.

Thanks in advance

Posted

There are no plans to do anything about the whitespace in the display template. If you really don’t like it, you are free to not use the SuperGrid display template and just switch to the default one for just the display view. 

The site shown last is a good example. The layout actually creates a very good column width, which improves the legibility significantly – making the articles easier to read than long texts in this fluid forum for example. So it’s a feature, not a bug. I won’t compromise on such matters of legibility. I won’t make things worse, not even when I’m asked to. 

Posted
6 hours ago, opentype said:

There are no plans to do anything about the whitespace in the display template. If you really don’t like it, you are free to not use the SuperGrid display template and just switch to the default one for just the display view. 

The site shown last is a good example. The layout actually creates a very good column width, which improves the legibility significantly – making the articles easier to read than long texts in this fluid forum for example. So it’s a feature, not a bug. I won’t compromise on such matters of legibility. I won’t make things worse, not even when I’m asked to. 

Hi just need to clarify. 

I am interested in this app. Are you saying I can use super grid to display the fancy article's list, then choose other template to display the bog itself?

I like how your app display the article list but I don't like the forum style with gap article view.

Let me know thanks 

 

Posted
2 hours ago, beats23 said:

I am interested in this app. Are you saying I can use super grid to display the fancy article's list, then choose other template to display the bog itself?

Not sure what a bog is, but yes, you can pick and choose per database which of the templates are being used. 

Posted

I'm really not sure @opentype if you are seeing this in the desktop the way I'm seeing it.

There's def "out of proportion" space hugely wasted on the left side, should have been adjusting with S M L XL member image and not have double the size of that column.

Please check in the desktop: https://carnity.com/advice/offroad/top-3-off-road-mistakes-in-desert-mountain-r51/

And give some custom edit option even if you still convince with this idea, so that I can trim this space down as I really like your template for adding the hero image, that adds life to any articles we do.

image.thumb.png.f7be09673b67b4a12b83c2a675b9b953.png

Posted (edited)
2 hours ago, Gauravk said:

I'm really not sure @opentype if you are seeing this in the desktop the way I'm seeing it.

Yes, I am seeing what you are seeing and what I talk about is the text column. The number of characters per line is perfect the way it is. Making the text column wider makes it harder to read. Reading isn’t about “not wasting space”. That’s why books have whitespace since 500 years. 

opJRSxq.png

Edited by opentype
Posted

Hi, I got your app. It's a great app.

Just a thought, say I wanted to place an advert banner under the post author's avatar. Can you tell me the method I would need to use to put it there?

Example, what files would I need to edit, and do you think this is complicated to achieve?

demo pic attached.

Thanks 

advert-idea.thumb.jpg.8e32ab5219acd5acbcffc3472b35f929.jpg

Posted

Good idea @beats23 , that shows that many of the users are concerned with that generous white space, instead of 500-year-old book presentation that developer believes in. 

To be honest, to my eyes it's an out of proportion white space that is bothering me, even if developer split that white space to be balanced on both sides without changing the text width, I'm fine at least it will balance the layout like in books.

The current style looks like page moved to the extreme right as an error of codes, leaving space of 200 px on the left and 20 px on right. 

@opentype can you please make 100 px on both sides please, like in book example you shown?

19 hours ago, Gauravk said:

image.thumb.png.f7be09673b67b4a12b83c2a675b9b953.png

 

 

  • 2 weeks later...
Posted (edited)

Hi, 

I recently upgraded my site from 4.3.5 to 4.3.6 and SuperGrid seemed fine, but upon doing a FRESH install of 4.3.6 (on my test site) then immediately installing the supergrid templates and plugin, I ran into this error on the articles front page (/index.php?/articles.html/):

Error: Call to undefined method IPS\cms\Records1::reputation() (0)
#0 /home/testsite/public_html/applications/cms/sources/Theme/Theme.php(610) : eval()'d code(697): IPS\Theme\class_cms_database_Supergrid_FrontPage->entry(Object(IPS\cms\Records1), Object(IPS\cms\Databases))
#1 /home/testsite/public_html/applications/cms/modules/front/database/index.php(142): IPS\Theme\class_cms_database_Supergrid_FrontPage->index(Object(IPS\cms\Databases), Object(IPS\Patterns\ActiveRecordIterator), Object(IPS\Http\Url\Friendly), Array)
#2 /home/testsite/public_html/applications/cms/modules/front/database/index.php(51): IPS\cms\modules\front\database\_index->view()
#3 /home/testsite/public_html/system/Dispatcher/Controller.php(96): IPS\cms\modules\front\database\_index->manage()
#4 /home/testsite/public_html/applications/cms/sources/Databases/Dispatcher.php(325): IPS\Dispatcher\_Controller->execute()
#5 /home/testsite/public_html/applications/cms/widgets/Database.php(130): IPS\cms\Databases\_Dispatcher->run()
#6 /home/testsite/public_html/applications/cms/sources/Pages/Page.php(1257): IPS\cms\widgets\_Database->render()
#7 /home/testsite/public_html/applications/cms/sources/Pages/Page.php(2191): IPS\cms\Pages\_Page->getWidgets()
#8 /home/testsite/public_html/applications/cms/modules/front/pages/page.php(73): IPS\cms\Pages\_Page->output()
#9 /home/testsite/public_html/applications/cms/modules/front/pages/page.php(43): IPS\cms\modules\front\pages\_page->view()
#10 /home/testsite/public_html/system/Dispatcher/Controller.php(96): IPS\cms\modules\front\pages\_page->manage()
#11 /home/testsite/public_html/applications/cms/modules/front/pages/page.php(33): IPS\Dispatcher\_Controller->execute()
#12 /home/testsite/public_html/system/Dispatcher/Dispatcher.php(146): IPS\cms\modules\front\pages\_page->execute()
#13 /home/testsite/public_html/index.php(13): IPS\_Dispatcher->run()
#14 {main}

also this one here /index.php?/articles.html/articles/:
 

Error: Call to undefined method IPS\cms\Records1::reputation() (0)
#0 /home/testsite/public_html/applications/cms/sources/Theme/Theme.php(610) : eval()'d code(779): IPS\Theme\class_cms_database_supergrid_listing->recordRow(Object(IPS\Helpers\Table\Content), Array, Array)
#1 [internal function]: IPS\Theme\class_cms_database_supergrid_listing->categoryTable(Object(IPS\Helpers\Table\Content), Array, Array, NULL, true)
#2 /home/testsite/public_html/system/Helpers/Table/Table.php(548): call_user_func(Array, Object(IPS\Helpers\Table\Content), Array, Array, NULL, true)
#3 /home/testsite/public_html/applications/cms/modules/front/database/category.php(533): IPS\Helpers\Table\_Table->__toString()
#4 /home/testsite/public_html/applications/cms/modules/front/database/category.php(40): IPS\cms\modules\front\database\_category->view()
#5 /home/testsite/public_html/system/Dispatcher/Controller.php(96): IPS\cms\modules\front\database\_category->manage()
#6 /home/testsite/public_html/applications/cms/sources/Databases/Dispatcher.php(325): IPS\Dispatcher\_Controller->execute()
#7 /home/testsite/public_html/applications/cms/widgets/Database.php(130): IPS\cms\Databases\_Dispatcher->run()
#8 /home/testsite/public_html/applications/cms/sources/Pages/Page.php(1257): IPS\cms\widgets\_Database->render()
#9 /home/testsite/public_html/applications/cms/sources/Pages/Page.php(2191): IPS\cms\Pages\_Page->getWidgets()
#10 /home/testsite/public_html/applications/cms/modules/front/pages/page.php(73): IPS\cms\Pages\_Page->output()
#11 /home/testsite/public_html/applications/cms/modules/front/pages/page.php(43): IPS\cms\modules\front\pages\_page->view()
#12 /home/testsite/public_html/system/Dispatcher/Controller.php(96): IPS\cms\modules\front\pages\_page->manage()
#13 /home/testsite/public_html/applications/cms/modules/front/pages/page.php(33): IPS\Dispatcher\_Controller->execute()
#14 /home/testsite/public_html/system/Dispatcher/Dispatcher.php(146): IPS\cms\modules\front\pages\_page->execute()
#15 /home/testsite/public_html/index.php(13): IPS\_Dispatcher->run()
#16 {main}

Can anyone else corroborate this?  Fresh 4.3.6 install (using utf8mb4 if it matters), then installing ONLY the supergrid templates and plugin (and assigning the templates to the default database).

Thanks!

Edited by IPCommerceFan
added second error
Posted
4 hours ago, IPCommerceFan said:

Hi, 

I recently upgraded my site from 4.3.5 to 4.3.6 and SuperGrid seemed fine, but upon doing a FRESH install of 4.3.6 (on my test site) then immediately installing the supergrid templates and plugin, I ran into this error on the articles front page (/index.php?/articles.html/):

Your templates are out of date. You need to use the latest release of SuperGrid. 

Posted

I'm using IP pages for the car business listing section for two years, developed by some other programmer. Recently installed supergrid and loved its entire look and feel but first two header row shifting images to right instead of center.

I tried editing the record image field in display option coding to center images, but it didn't work.

Appreciate if anyone can please help on this regard, as what I am missing or what code went wrong in the past.......?

Thanks in advance

https://carnity.com/business_listing/

image.thumb.png.d9ab7edad157d3d48501211e13168e34.png

 

Image field - display code

<br><div class="ipsClearfix">
{{foreach $value as $image}}
  <img style="height: 160px; width: 240px;" align="center" src='{file="$image" extension="cms_Records"}'>
{{break;}}{{endforeach}}
</div>

 

  • 3 weeks later...
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...