possible bug/error - event container now has hard coded monthly view

[sound]

in the latest version of calendar (4.7.3)  $event->container()->url() appears to be hard coded to always use the '?view=month'  url no matter what the default calendar view is set to

in /sources/calendar/calendar.php the previous version had

public static $urlBase = 'app=calendar&module=calendar&controller=view&id=';

in the latest version it is set to

public static $urlBase = 'app=calendar&module=calendar&controller=view&view=month&id=';

[Jim M]

Please be advised I have tagged this as a dev to confirm if this is intended or not.

[Andy Millne]

Yes this is intended. There is no container specific filtering on the overview page.

[sound]

3 hours ago, Andy Millne said:

Yes this is intended. There is no container specific filtering on the overview page.

thanks for the reply Andy @Andy Millne

ok understand that working as above is fine and should be intended if you are indeed using the 'overview' as per the selected option

however if you are not using the 'overview' as the default selection, say you select the 'week view' as default then  every event will have a link that will  now send viewers to the 'month' page and the same for any calendars using  'day view'

which to someone using the week or day view as 'default' choice does bring in major usability issues along with seo  ones

 

Could you not add a 'if \IPS\Settings::i()->calendar_default_view== overview add the ?view=month ' and if not..

then leave the static url as generic so that the week, and day views choices as default are then respected and followed?

thanks

 

 

Edited October 31, 2022 by sound

[Andy Millne]

Thanks for clarifying. I have added a bug report for this issue as I can see the problem in that scenario.

[Andy Millne]

A fix for this has been submitted for review and inclusion in an upcoming release.

[Marc Stridgen]

This has now been resolved in our latest 4.7.6 release. Please upgrade to that release if you are seeing this issue. If you have the same problem after upgrading, please let us know.