teraßyte Posted November 21, 2022 Posted November 21, 2022 Steps to reproduce: Visit a member's profile in ACP and click the Ban button in the Warnings & Restrictions box. Setup any ban option you want except for the Move to option so the member remains in the same group. Once you click the Save button this new log shows up in the member's account activity: Quote Group manually changed by admin from Members to Members. This happens because of this code below in /applications/core/modules/admin/members/members.php on lines 2867~2871: if ( isset( $values['member_ban_group'] ) ) { $member->logHistory( 'core', 'group', array( 'type' => 'primary', 'by' => 'manual', 'old' => $member->member_group_id, 'new' => $values['member_ban_group'] ) ); $member->member_group_id = $values['member_ban_group']; } The fix is to change the IF check to use this code in order to skip it when the group ID is the same instead: if ( isset( $values['member_ban_group'] ) AND $values['member_ban_group'] != $member->member_group_id ) Afrodude and SeNioR- 2
Solution Daniel F Posted November 21, 2022 Solution Posted November 21, 2022 Thanks, I have fixed this for an upcoming release SeNioR- 1
teraßyte Posted November 21, 2022 Author Posted November 21, 2022 @Daniel F Great! While you're at it can you guys give a good look at this forum and check the other bugs? I've posted several ones (even easy ones like this one) and they were never acknowledged nor fixed. Here's some random ones: https://invisioncommunity.com/forums/topic/468507-bug-470-cannot-setup-extra-fields-in-downloads-to-be-included-in-topics/ https://invisioncommunity.com/forums/topic/468498-bug-470-the-setting-send-diagnostic-data-is-broken/ https://invisioncommunity.com/forums/topic/468464-bug-470-cms-database-setting-field-options-records-per-page-controls-also-comments-per-page/ https://invisioncommunity.com/forums/topic/468123-bug-470-blog-app-has-calendar-code-in-it/ These are just some recent ones. Martin A. and Afrodude 2
Recommended Posts