LiquidFractal Posted October 6, 2020 Share Posted October 6, 2020 18 hours ago, Adriano Faria said: Which code fix? I tested this in Beta stage and didn’t notice it. Oh, I meant this fix (above): This got rid of the commas in the list, but online users are still displaying twice. Link to comment
Adriano Faria Posted October 6, 2020 Author Share Posted October 6, 2020 Yes, it's duplicated. I'll check it out to figure what has changed and fix it. Link to comment
Adriano Faria Posted October 7, 2020 Author Share Posted October 7, 2020 On 10/6/2020 at 12:33 AM, liquidfractal said: Oh, I meant this fix (above): This got rid of the commas in the list, but online users are still displaying twice. Btw, I didn't applied the fix and I got no commas in the lists: A new version was submitted to the marketplace. Follow the file to get notified when IPS review and approve it. 👍 LiquidFractal 1 Link to comment
LiquidFractal Posted October 8, 2020 Share Posted October 8, 2020 Thanks! I'll check it out. And for some reason I need that line in my custom.css in order to remove the commas on my test install (which is a fresh 4.5.3), but the line works so no issues there. 👍 Link to comment
nodle Posted March 10, 2022 Share Posted March 10, 2022 @Adriano Faria I just installed this and noticed that it duplicates the user. Basically it leaves both the avatar and username but only on one user. I have signed out/signed back in many times along with clearing all system caches a few times. Any ideas? Screenshot below: Link to comment
Adriano Faria Posted March 10, 2022 Author Share Posted March 10, 2022 23 minutes ago, nodle said: @Adriano Faria I just installed this and noticed that it duplicates the user. Basically it leaves both the avatar and username but only on one user. I have signed out/signed back in many times along with clearing all system caches a few times. Any ideas? Screenshot below: True, I can confirm. Something must have changed between the date I tested in 4.6.0 Beta and 4.6.11. Will fix and release a new version asap. nodle 1 Link to comment
nodle Posted March 14, 2022 Share Posted March 14, 2022 The new update works like a charm @Adriano Faria, thanks for the support! Adriano Faria 1 Link to comment
nodle Posted March 14, 2022 Share Posted March 14, 2022 Well, it worked fine all morning, came back from lunch and it looks like it's doing it again, so I uninstalled it. I tried both on mobile and desktop, logging in and out, and clearing caches. Any ideas? Link to comment
Adriano Faria Posted March 15, 2022 Author Share Posted March 15, 2022 3 hours ago, nodle said: Well, it worked fine all morning, came back from lunch and it looks like it's doing it again, so I uninstalled it. I tried both on mobile and desktop, logging in and out, and clearing caches. Any ideas? Did you clear cache? The “hook” is supposed to work all the time. Link to comment
nodle Posted March 15, 2022 Share Posted March 15, 2022 47 minutes ago, Adriano Faria said: Did you clear cache? The “hook” is supposed to work all the time. I sure did a few times in fact. Like I said I installed this morning, came back from lunch and it went back like the screenshot above. So logged out and tried again, and tried on mobile phone and same thing. I don't know what changed hours later. Link to comment
Adriano Faria Posted March 15, 2022 Author Share Posted March 15, 2022 1 hour ago, nodle said: I sure did a few times in fact. Like I said I installed this morning, came back from lunch and it went back like the screenshot above. So logged out and tried again, and tried on mobile phone and same thing. I don't know what changed hours later. I will leave it installed on my live board for a couple of days to see if I can reproduce it. nodle 1 Link to comment
nodle Posted March 15, 2022 Share Posted March 15, 2022 I am going to re-test this install @Adriano Faria, I was running php 8.1 which is not supported yet by Invision. I dropped it back down to php 8.0, and re-installed it, and will see if that had something to do with it. Adriano Faria 1 Link to comment
nodle Posted March 15, 2022 Share Posted March 15, 2022 @Adriano Faria an update. I came back from my lunch hour and the same thing as the screen shot above. So, it's not php version related. I don't really know what is causing it. It just seems like if you are logged out after a while and come back it doesn't work properly. Anyways let me know if you ever figure it out. Link to comment
Adriano Faria Posted March 15, 2022 Author Share Posted March 15, 2022 Thanks. Will try to reproduce. @CBA, can you reproduce the issue above in your install? Link to comment
Stuart Silvester Posted March 15, 2022 Share Posted March 15, 2022 2 hours ago, Adriano Faria said: Thanks. Will try to reproduce. @CBA, can you reproduce the issue above in your install? The viewing member is being added to the widget via JS if it does not see them listed (this can happen when the widget is cached). Take a look at JS: core.front.core.onlineUsersWidget Adriano Faria 1 Link to comment
nodle Posted March 25, 2022 Share Posted March 25, 2022 Did you ever find a fix for this @Adriano Faria? Link to comment
Adriano Faria Posted March 25, 2022 Author Share Posted March 25, 2022 Not yet. Still on it. nodle 1 Link to comment
Adriano Faria Posted March 28, 2022 Author Share Posted March 28, 2022 On 3/15/2022 at 8:00 PM, Stuart Silvester said: The viewing member is being added to the widget via JS if it does not see them listed (this can happen when the widget is cached). Take a look at JS: core.front.core.onlineUsersWidget I see. I’ll have to use mixins but I’d have to replace the whole function. As with PHP, I can’t change stuff in the middle of a function (memberRowHtml). Is that ok or should I consider this resource dead? Link to comment
Nathan Explosion Posted March 28, 2022 Share Posted March 28, 2022 You could try an "after('initialize'..." targeting the specific LI for the viewing user (if it exists)? Adriano Faria 1 Link to comment
Stuart Silvester Posted March 28, 2022 Share Posted March 28, 2022 You could use a template hook to remove the data-controller attribute, or change it for your own controller. Adriano Faria 1 Link to comment
Adriano Faria Posted April 11, 2022 Author Share Posted April 11, 2022 What's New in Version 2.1.5: Fix: https://invisioncommunity.com/forums/topic/418256-profile-photo-in-online-lists/?do=findComment&comment=2885448 Link to comment
nodle Posted April 11, 2022 Share Posted April 11, 2022 @Adriano Faria this won't install through the ACP. Please see this post: Link to comment
Adriano Faria Posted April 11, 2022 Author Share Posted April 11, 2022 4 minutes ago, nodle said: @Adriano Faria this won't install through the ACP. Please see this post: Already replied there. 👍 Link to comment
Tripp★ Posted May 28, 2023 Share Posted May 28, 2023 (edited) Hello Adriano, hope you're having a great weekend. Sorry to drop in on you on a Sunday again. Is there any chance of getting it to target this plugin if it is installed? Cheers! Edited May 28, 2023 by Tripp★ Wrong link. Whoops. Link to comment
Adriano Faria Posted May 28, 2023 Author Share Posted May 28, 2023 Nope, as it is a 3rd-party resource and I don’t have access to it. Link to comment
Recommended Posts