Live Messenger

[Kirill Gromov]

Hello, the new version is pending approval, it contains some new features. Thanks for your suggestions!

[Afrodude]

I have this error whenever trying to open a pm. 

TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in /srv/forums/applications/core/sources/Messenger/Conversation.php:535
Stack trace:
#0 /forums/applications/core/sources/Messenger/Conversation.php(535): array_filter(NULL, Object(Closure))
#1 /forums/init.php(927) : eval()'d code(15): IPS\core\Messenger\_Conversation->get_activeParticipants()
#2 /forums/system/Content/Item.php(5278): IPS\core\Messenger\hook912->canCommentReview('reply', NULL, true)
#3 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(161): IPS\Content\_Item->canComment()
#4 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messageComment(Object(IPS\core\Messenger\Conversation), Object(IPS\core\Messenger\Message), 'messenger_comme...', 'core', 'messaging', 'core_Messenger_...')
#5 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(490): IPS\Theme\_SandboxedTemplate->__call('messageComment', Array)
#6 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messageItem(Object(IPS\core\Messenger\Conversation), Object(IPS\core\Messenger\Message))
#7 /forums/init.php(927) : eval()'d code(20): IPS\Theme\_SandboxedTemplate->__call('messageItem', Array)
#8 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(739): IPS\core\Messenger\livemessenger_hook_MessageModel->htmlMini()
#9 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messagesDisplay(Object(IPS\core\Messenger\Conversation), Object(IPS\Helpers\Form))
#10 /forums/applications/livemessenger/modules/front/chat/messenger.php(184): IPS\Theme\_SandboxedTemplate->__call('messagesDisplay', Array)
#11 /forums/system/Dispatcher/Controller.php(107): IPS\livemessenger\modules\front\chat\_messenger->getConversation()
#12 /forums/applications/livemessenger/modules/front/chat/messenger.php(25): IPS\Dispatcher\_Controller->execute()
#13 /forums/system/Dispatcher/Dispatcher.php(153): IPS\livemessenger\modules\front\chat\_messenger->execute()
#14 /forums/index.php(13): IPS\_Dispatcher->run()
#15 {main}

#0 /forums/system/Theme/SandboxedTemplate.php(71): IPS\_Log::log(Object(TypeError), 'template_error')
#1 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(490): IPS\Theme\_SandboxedTemplate->__call('messageComment', Array)
#2 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messageItem(Object(IPS\core\Messenger\Conversation), Object(IPS\core\Messenger\Message))
#3 /forums/init.php(927) : eval()'d code(20): IPS\Theme\_SandboxedTemplate->__call('messageItem', Array)
#4 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(739): IPS\core\Messenger\livemessenger_hook_MessageModel->htmlMini()
#5 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messagesDisplay(Object(IPS\core\Messenger\Conversation), Object(IPS\Helpers\Form))
#6 /forums/applications/livemessenger/modules/front/chat/messenger.php(184): IPS\Theme\_SandboxedTemplate->__call('messagesDisplay', Array)
#7 /forums/system/Dispatcher/Controller.php(107): IPS\livemessenger\modules\front\chat\_messenger->getConversation()
#8 /forums/applications/livemessenger/modules/front/chat/messenger.php(25): IPS\Dispatcher\_Controller->execute()
#9 /forums/system/Dispatcher/Dispatcher.php(153): IPS\livemessenger\modules\front\chat\_messenger->execute()
#10 /forums/index.php(13): IPS\_Dispatcher->run()
#11 {main}

 

[[Template livemessenger/front/global/messageComment is throwing an error. This theme may be out of date. Run the support tool in the AdminCP to restore the default theme.]]

Edited December 18, 2022 by Afrodude

[Kirill Gromov]

Hello, @Afrodude! How can I reproduce such an error? Perhaps this conversation has some properties? On which specific page are you getting this error?

[Afrodude]

@Kirill Gromov

Just sent another member a test message, and this is all what I see whenever open it. With errors I posted above from the ACP. 

I tried disabling all other apps and plugins, and I get same result. I removed this app completely and reinstalled it, and I get same results.

[Interferon]

Tried this out with IPB 4.7, did not seem to do anything at all. Nothing was different with it installed.

[Kirill Gromov]

1 hour ago, Interferon said:

Tried this out with IPB 4.7, did not seem to do anything at all. Nothing was different with it installed.

Hello, what do you mean? What needs to change?

[Interferon]

Shouldn't the application do something? I did not see anything different at all about the messenger system.

[Afrodude]

@Kirill Gromov still same error after 4.7.6 update 

 

The URL of page the error occurred on was https://mysite.com/index.php?app=livemessenger&module=chat&controller=messenger&do=getConversation&mid=146339&csrfKey=e5ce76812379a9c1666cd84962bc5d62

TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in /srv/forums/applications/core/sources/Messenger/Conversation.php:535
Stack trace:
#0 /forums/applications/core/sources/Messenger/Conversation.php(535): array_filter(NULL, Object(Closure))
#1 /forums/init.php(927) : eval()'d code(15): IPS\core\Messenger\_Conversation->get_activeParticipants()
#2 /forums/system/Content/Item.php(5278): IPS\core\Messenger\hook912->canCommentReview('reply', NULL, true)
#3 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(161): IPS\Content\_Item->canComment()
#4 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messageComment(Object(IPS\core\Messenger\Conversation), Object(IPS\core\Messenger\Message), 'messenger_comme...', 'core', 'messaging', 'core_Messenger_...')
#5 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(490): IPS\Theme\_SandboxedTemplate->__call('messageComment', Array)
#6 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messageItem(Object(IPS\core\Messenger\Conversation), Object(IPS\core\Messenger\Message))
#7 /forums/init.php(927) : eval()'d code(20): IPS\Theme\_SandboxedTemplate->__call('messageItem', Array)
#8 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(739): IPS\core\Messenger\livemessenger_hook_MessageModel->htmlMini()
#9 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messagesDisplay(Object(IPS\core\Messenger\Conversation), Object(IPS\Helpers\Form))
#10 /forums/applications/livemessenger/modules/front/chat/messenger.php(184): IPS\Theme\_SandboxedTemplate->__call('messagesDisplay', Array)
#11 /forums/system/Dispatcher/Controller.php(107): IPS\livemessenger\modules\front\chat\_messenger->getConversation()
#12 /forums/applications/livemessenger/modules/front/chat/messenger.php(25): IPS\Dispatcher\_Controller->execute()
#13 /forums/system/Dispatcher/Dispatcher.php(153): IPS\livemessenger\modules\front\chat\_messenger->execute()
#14 /forums/index.php(13): IPS\_Dispatcher->run()
#15 {main}

#0 /forums/system/Theme/SandboxedTemplate.php(71): IPS\_Log::log(Object(TypeError), 'template_error')
#1 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(490): IPS\Theme\_SandboxedTemplate->__call('messageComment', Array)
#2 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messageItem(Object(IPS\core\Messenger\Conversation), Object(IPS\core\Messenger\Message))
#3 /forums/init.php(927) : eval()'d code(20): IPS\Theme\_SandboxedTemplate->__call('messageItem', Array)
#4 /forums/uploads/cache/template_85_a858f5b396285b1389a0f9128b354d40_global.php(739): IPS\core\Messenger\livemessenger_hook_MessageModel->htmlMini()
#5 /forums/system/Theme/SandboxedTemplate.php(61): IPS\Theme\Cache\class_livemessenger_front_global->messagesDisplay(Object(IPS\core\Messenger\Conversation), Object(IPS\Helpers\Form))
#6 /forums/applications/livemessenger/modules/front/chat/messenger.php(184): IPS\Theme\_SandboxedTemplate->__call('messagesDisplay', Array)
#7 /forums/system/Dispatcher/Controller.php(107): IPS\livemessenger\modules\front\chat\_messenger->getConversation()
#8 /forums/applications/livemessenger/modules/front/chat/messenger.php(25): IPS\Dispatcher\_Controller->execute()
#9 /forums/system/Dispatcher/Dispatcher.php(153): IPS\livemessenger\modules\front\chat\_messenger->execute()
#10 /forums/index.php(13): IPS\_Dispatcher->run()
#11 {main}

 

Edited January 10, 2023 by Afrodude

[Kirill Gromov]

11 hours ago, Afrodude said:

The URL of page the error occurred on was https://mysite.com/index.php?app=livemessenger&module=chat&controller=messenger&do=getConversation&mid=146339&csrfKey=e5ce76812379a9c1666cd84962bc5d62

Hello. unfortunately, I am unable to reproduce this error on multiple installations. Maybe, you may have other applications or plugins installed that affect this, or you may have specific settings in your community. I'd love to take a closer look at this bug if I were granted access. 

On 12/31/2022 at 2:16 PM, Interferon said:

Shouldn't the application do something? I did not see anything different at all about the messenger system.

Most likely you need to enable settings: ACP > Members > Live Messenger > Settings

[Afrodude]

4 hours ago, Kirill Gromov said:

Hello. unfortunately, I am unable to reproduce this error on multiple installations. Maybe, you may have other applications or plugins installed that affect this, or you may have specific settings in your community. I'd love to take a closer look at this bug if I were granted access. 

I didn't think of that, and you are right the app works fine now. Yet the issue now is your app has a conflict on something with this plugin.

 

[EvanDC]

I've tried to install this today through the ACP and marketplace ... and each time it's thrown up an error and not worked. Could it be to do with the upgrade to IPS I ran yesterday when prompted? 

[Kirill Gromov]

36 minutes ago, EvanDC said:

I've tried to install this today through the ACP and marketplace ... and each time it's thrown up an error and not worked. Could it be to do with the upgrade to IPS I ran yesterday when prompted? 

I don't think so, what error did you have to see?

4 hours ago, Afrodude said:

I didn't think of that, and you are right the app works fine now. Yet the issue now is your app has a conflict on something with this plugin.

Thanks, I will work on this and fix it in the next version.

[EvanDC]

I've tried for the 4th time and it's working fine now. I'm sorry I didn't get screengrabs of the error messages. First it was in the ACP when I tried to go to the settings for the messenger. It has a red bar across the top of the screen and nothing else. Text in it, but I can't remember what the error was. 
Then I uninstalled it. Tried to reinstall it. I think the error was more apparent this time saying something like "couldn't load jsoc library" (I might have the jsoc bit wrong ... but it began with a J. That was on the install screen. 

 

[Afrodude]

@Kirill Gromov thanks for the recent update. 🙂 

[Grafidea]

I don't know why but it's not showing up on my forum despite the mode being turned on.

[Kirill Gromov]

13 hours ago, Grafidea said:

I don't know why but it's not showing up on my forum despite the mode being turned on.

Hello.

You must enable access for groups in the app settings. 

[Grafidea]

I did that and it still doesn't show up.

[Kirill Gromov]

4 minutes ago, Grafidea said:

I did that and it still doesn't show up.

Can you check this on the default theme?

[Grafidea]

Yes, on the default template it works.

[Princess Celestia]

This is a really nifty app! I love it! Some feedback:

1. Messages submitted through this app bypass the "merge concurrent posts" setting. Unclear if this is by design or intentional but it's inconsistent with how the built-in messenger works.
2. Being able to separately set the messenger to "bar mode" on desktop and "bubble mode" on mobile would be appreciated. I like the "bar" style better in desktop mode and "bubble" style more on mobile.
3. An easy way to insert line or paragraph breaks into a message would be fantastic. I recommend using shift+enter for this - that will be consistent with most chat programs.

Edited April 26, 2023 by Princess Celestia

[SeNioR-]

Idea: Hide the bar if the user has no messages.

[SeNioR-]

Small tweak to not load JS and CSS for guests as they don't have access to the Messenger anyway.

Hook cssFiles.php:

\IPS\Output::i()->cssFiles = array_merge( \IPS\Output::i()->cssFiles, \IPS\Theme::i()->css( 'livemessenger.css', 'livemessenger', 'front' ) );

to

if ( \IPS\Member::loggedIn()->member_id ) {
\IPS\Output::i()->cssFiles = array_merge( \IPS\Output::i()->cssFiles, \IPS\Theme::i()->css( 'livemessenger.css', 'livemessenger', 'front' ) );
}

and

\IPS\Output::i()->jsFiles = array_merge( \IPS\Output::i()->jsFiles, \IPS\Output::i()->js( 'front_livemessenger.js', 'livemessenger', 'front' ) );

to 

if ( \IPS\Member::loggedIn()->member_id ) {
\IPS\Output::i()->jsFiles = array_merge( \IPS\Output::i()->jsFiles, \IPS\Output::i()->js( 'front_livemessenger.js', 'livemessenger', 'front' ) );
}