Jump to content

Duplicate rel= in sharelinks templates


Gabriel Torres
 Share

Go to solution Solved by Daniel F,

Recommended Posts

Hi,

Validating our website with the W3 validator tool, I found a glitch in the core > front > sharelinks templates, where the tag "rel=" is duplicated (there is a rel="nofollow" and a rel='noopener'; they should be combined as rel="nofollow noopener"). For example, the twitter template is:

<a href="http://twitter.com/share?url={$url}" rel="nofollow" class="cShareLink cShareLink_twitter" target="_blank" data-role="shareLink" title='{lang="twitter_text"}' data-ipsTooltip rel='noopener'>
	<i class="fa fa-twitter"></i>
</a>

But it should be:

<a href="http://twitter.com/share?url={$url}" rel="nofollow noopener" class="cShareLink cShareLink_twitter" target="_blank" data-role="shareLink" title='{lang="twitter_text"}' data-ipsTooltip>
	<i class="fa fa-twitter"></i>
</a>

The same happens in the linkedin, pinterest, and reddit templates.

Cheers.

Link to comment
Share on other sites

  • Solution
30 minutes ago, SeNioR- said:

This wasn't fixed in 4.6.9 sometimes?

https://invisioncommunity.com/release-notes/

  • Fixed some missing rel=nofollow attributes on add new content links.
  • Fixed an issue where editing anonymous items could change the author.

Few instances were fixed, but this one was indeed missed.

Thanks for the report @Gabriel Torres, I have fixed it for an upcoming release:)

 

Link to comment
Share on other sites

 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...