After 4.2.2 upgrade there is a problem with internal links

[Duken]

Dear,

i upgraded to 4.2.2 today. But there is a problem with all the embeded links.
Case is created at IPB.

When i past a link like:

https://www.duken.nl/forums/nieuws/top-10-meest-gedownloade-films-van-7-augustus-tot-13-augustus-r208/

the embedded link will be: 

https://www.duken.nl/forums/nieuws/top-10-meest-gedownloade-films-van-7-augustus-tot-13-augustus-r208/?do=embed

Example: https://www.duken.nl/forums/topic/34820-links-met-handleidingen-en-informatie-voor-nieuwsgroepen-gebruikers/

All links are now with ?do=embed

Regards,

Jerry

[Adlago]

In some of your templates you have a missing "</ div>"

[Duken]

Thank you @adlago. 

Ill inform IPB with your reaction. But no other IPBers with 4.2.2 with this issue? I did not change the template.

 

[Duken]

I dont think that is it Adlago. But i need to check it out anyway. But thank you for the research.

[Adlago]

You can try this
-Remove cache on site
- Delete all files from a directory 'datastore'

[Duken]

No succes, lets wait for super IPB support

And lets hope Google spiders are on lunch break...

[Duken]

info for other users:

Also disabled all plugins etc as told on the "get support" no solution.

A weird thing: a few pages like:

 https://www.duken.nl/forums/nieuws/top-10-meest-gedownloade-films-van-31-juli-tot-6-augustus-r203/ 

have working visually embeds.

But these ones have none working embeds

https://www.duken.nl/forums/nieuws/aflevering-4-van-seizoen-7-van-game-of-thrones-gots7e4-is-te-downloaden-r206/

https://www.duken.nl/forums/topic/34819-links-met-handleidingen-en-informatie-voor-bittorrent-gebruikers/

https://www.duken.nl/forums/topic/34820-links-met-handleidingen-en-informatie-voor-nieuwsgroepen-gebruikers/

[Duken]

More info.

On the Internet explorer browser it gives a "blank page" on not working embeds. 

[DesignzShop]

16 minutes ago, Duken said:

More info.

On the Internet explorer browser it gives a "blank page" on not working embeds. 

There were a ton of embed updates in 4.2.2. Just look at theme differences tool to see that. You have a ticket into support,, they will sort it from there.

Regards

[Duken]

Thank you @DesignzShop but the issue occurs also with the default theme.

I'll wait ipb. Many there are other 4.4.2 users with the same issue.

 

[Adlago]

@DukenHave you seen your pages as a guest? Is there any difference with registered users?

[Duken]

Yes also guest and default theme have a embedded links "loop". 

[knightsystems]

I cannot confirm this issue on my board. 

[Adlago]

@DukenIn this link https://www.duken.nl/forums/topic/34820-links-met-handleidingen-en-informatie-voor-nieuwsgroepen-gebruikers/

I see this

Is there anything missing?

[Aiwa]

Dunken,

Have you submitted a support request to IPS via your Client Area?  This forum is not for official IPS Support.  You won't get a response from IPS in this topic.

[DesignzShop]

51 minutes ago, Duken said:

Thank you @DesignzShop but the issue occurs also with the default theme.

I'll wait ipb. Many there are other 4.4.2 users with the same issue.

 

Just as a fyi for your future use, the theme differences tool only references IPB's stock theme only. Not a custom theme. So when you use that tool you can see what the stock theme differences are from version to version. Themers use that tool to adjust our themes after we know the changes that occur in that theme diff tool. Not all the times it's used but in 95 percent of use it is  

As mentioned however, there are a lot of changes evident in 4.2.2 in regards to embeds so if a issue occurs, you'll see it all over the place, and the reason to report it to IPB through support like you have.

[opentype]

I can replicated it here on the site. The link boxes on this topic fail:

 

[Duken]

Hi @opentype.

The link box on this site looks to work in your reaction. But it looks like I am not the only one? Or could you replicate it on a other ipb site?

Thanks!

[opentype]

1 hour ago, Duken said:

Or could you replicate it on a other ipb site?

Thanks!

It is failing in @Mark’s link in the linked topic. 

[Duken]

Thank you Opentype. Ill inform IPB.

[Duken]

Well.... 2nd reaction of ipb. They don't see any issue and The do=embed, is not a bug, but by design....

I think it's a bit busy overthere. They need to read the case once more and check out the added screenshots.

Let's wait 

[Duken]

Still no reaction from support. Google bot does not like my pages with embed at the moment. 

Someone knows the page where bugs are added? I want to add this. Thanks

Regards,

 

[Duken]

On 8-8-2017 at 10:42 PM, Adlago said:

@DukenIn this link https://www.duken.nl/forums/topic/34820-links-met-handleidingen-en-informatie-voor-nieuwsgroepen-gebruikers/

I see this

Is there anything missing?

Sorry must your reaction.

The page is an example. All the embedded links on this page give the same problem. If you click on a embedded link you get in a loop. 

[ABGenc]

On ‎8‎.‎08‎.‎2017 at 11:28 PM, Duken said:

Yes also guest and default theme have a embedded links "loop". 

I also have a looping problem for DB records embedded in posts. 

When I inspect the element I get following

<a href="" target="_blank">MazdaClubTR bir kayıt oluşturdu : Sıkça Sorulan Sorular </a>

URL is blank...

Just submitted a ticket for this. Lets see what the response will be

[Duken]

Had a solution from IPB. It will be added in next update:

Please open 'applications/cms/sources/Records/Records.php
Search for
return \IPS\Theme::i()->getTemplate( 'global', 'cms' )->embedRecord( $this, $this->container(), $this->url()->setQueryString( $params ) );

replace it with

return \IPS\Theme::i()->getTemplate( 'global', 'cms' )->embedRecord( $this, $this->url()->setQueryString( $params ) );