-FP Posted May 25, 2017 Author Posted May 25, 2017 (edited) I'm updating this to version 3 tonight or tomorrow and hopefully make a few improvements. IPS 4.2 kinda has an option for this so It's mainly for the new styles. https://cookieconsent.insites.com/ Edited May 25, 2017 by -FP AndyF 1
-FP Posted May 25, 2017 Author Posted May 25, 2017 (edited) Alright, update is up. New styles and color options. By default it matches the suite scheme I removed the option to block the GA cookie... but I could bring it back if people actually used it. Edited May 25, 2017 by -FP
Qubabos Posted May 26, 2017 Posted May 26, 2017 (edited) updated 3.0 version breaks image scaling in Pages SuperGrid plugin : @opentype says that cookie plugin is broken : can you fix it @-FP ? previous cookie notice version working just fine. Edited May 26, 2017 by Qubabos
-FP Posted May 26, 2017 Author Posted May 26, 2017 (edited) I will take a look but it doesn't make much sense for what I've seen so far. When the cookie plugin is enabled, the CSS file that has the style for the "SG_record_image" class is not loaded. Again, it doesn't make sense to me for now because all my plugin is doing is inserting the code they instruct before the </head> element, it's just passing the plugin settings as the parameters. Maybe there's some conflict between both plugins css sheets. It's not fair to just say "it's the other broken" by the other developer, my plugin works just fine on its own, it would probably do the same if you implement the code manually without a plugin. Anyway, I will take a look later. Edited May 26, 2017 by -FP Qubabos 1
opentype Posted May 26, 2017 Posted May 26, 2017 Look at what is going on there. Instead of CSS, there is a whole website calling Github files and whatnot. It breaks my 4.2 site (I tested it on) completely. It’s not just Pages templates. Qubabos and -FP 1 1
-FP Posted May 26, 2017 Author Posted May 26, 2017 (edited) FAIL. I updated the sheet in the resources folder but for some reason left that one I downloaded incorrectly from the plugins github repository in the css folder. (https://github.com/insites/cookieconsent/) What's weird is that it was working just fine on my live site. Thanks. I just updated it to fix that @Qubabos Edited May 26, 2017 by -FP Qubabos 1
Joey_M Posted July 8, 2017 Posted July 8, 2017 @-FP this doesn't work on one of @ehren.'s themes, the 4.1 version is fine and I can confirm it works with the default skin on 4.2 but no others. Can you advice me please?
-FP Posted July 8, 2017 Author Posted July 8, 2017 (edited) @Joey_M Have you tried re-installing the plugin after installing the theme? I really don't know what the problem could be. But I will be able to take a look soon, I'm waiting for @ehren. to release the 4.2 update for the theme I use from him. Edited July 8, 2017 by -FP Joey_M 1
Joey_M Posted July 8, 2017 Posted July 8, 2017 Thank you, uninstalling it has made it reappear. -FP 1
Joey_M Posted August 7, 2017 Posted August 7, 2017 On 16/02/2017 at 0:00 AM, Donkerrood said: Would it be possible to defer the javascript to just before the </body> tag, if this setting is enabled in the theme settings? Right now, this is my only render-blocking javascript with google pagespeed. Thanks! @-FP Is this possible? I'm desperately trying to increase my sites performance, and this is one the things @Adlago mentioned trying to do.
-FP Posted August 8, 2017 Author Posted August 8, 2017 (edited) 10 hours ago, Joey_M said: @-FP Is this possible? I'm desperately trying to increase my sites performance, and this is one the things @Adlago mentioned trying to do. I tried doing that but I can't get it to work if placed before </body>. This is based on the code by Insites and their instructions are to place it before </head>: https://cookieconsent.insites.com/download/ I will keep looking into it but if anyone has a solution just ping me. Edited August 8, 2017 by -FP
-FP Posted August 8, 2017 Author Posted August 8, 2017 Ignore what I said above this. I got it working (lol), I will update a new version later today. Joey_M, Qubabos and Donkerrood 3
-FP Posted August 8, 2017 Author Posted August 8, 2017 (edited) Do you want it to automatically inherit the theme settings for code placement, or do you prefer an override setting in the plugin options? Edited August 8, 2017 by -FP
Qubabos Posted August 8, 2017 Posted August 8, 2017 IMO override setting in the plugin options will be better.
Joey_M Posted August 8, 2017 Posted August 8, 2017 3 hours ago, -FP said: Do you want it to automatically inherit the theme settings for code placement, or do you prefer an override setting in the plugin options? I agree with @Qubabos, a plugin setting would be better.
Joey_M Posted August 8, 2017 Posted August 8, 2017 (edited) 7 hours ago, -FP said: Update is up. How do I remove the opacity? I don't like it but changing the value up and down makes no difference it seems. Cache needed clearing. Thank you for the update. Edited August 9, 2017 by Joey_M
Qubabos Posted August 13, 2017 Posted August 13, 2017 @-FP with 3.0.4 and today update 3.0.5 disabling me opacity. How to restore this ? Even "Fixed issue changing opacity. Now plugin's CSS cache is cleared after changing settings" doesnt help much. Loaded JavaScript From Developer Site also doesnt help? Cloudflare could be an issue ? Runing with dev mode also no luck here...
-FP Posted August 13, 2017 Author Posted August 13, 2017 (edited) @Qubabos you can't change the opacity you mean? I tested 3.0.5 in 2 of my live sites and the opacity change is working. If you want send me over PM access to your ACP, I can take a look. Edited August 13, 2017 by -FP
Qubabos Posted August 13, 2017 Posted August 13, 2017 (edited) 3 minutes ago, -FP said: you can't change the opacity you mean? change opacity level or even turn this on... Its always off, no matter what value I put in opacity settings. I prefer to not giving an access into ACP Edited August 13, 2017 by Qubabos
Qubabos Posted August 13, 2017 Posted August 13, 2017 9 minutes ago, -FP said: What happens if you set it to 1? Absolutely nothing, whatever I set there it always looks the same. I try from 0.6 to 1.0 with no change at all.
-FP Posted August 13, 2017 Author Posted August 13, 2017 (edited) 20 minutes ago, Qubabos said: Absolutely nothing, whatever I set there it always looks the same. I try from 0.6 to 1.0 with no change at all. Try uninstalling the plugin, clearing the cache in the ACP support tool and/or browser, and then reinstall. Edited August 13, 2017 by -FP Qubabos 1
Qubabos Posted August 13, 2017 Posted August 13, 2017 30 minutes ago, -FP said: Try uninstalling the plugin, clearing the cache in the ACP support tool and/or browser, and then reinstall. Already did that with your mentioned order with no luck. I even check all available browsers so right now have no clue what was the issue, maybe cloudflare shrinks this opacity setting.
-FP Posted August 13, 2017 Author Posted August 13, 2017 Well it might be that, no idea I have no experience with cloudflare, and without being able to take a look myself I really don't know how to help you Qubabos 1
Recommended Posts