All Astronauts

Then, as others pointed out, you'll need to be careful with the scanner flagging out apps with no longer in use source and interface stuff that's just lying around, and I'll make a point to be sure when I'm dumping structure like that to be sure on my end not to forget about the namespacing hooks that might be still calling them 🤪

1.2.0 Submitted! 

• Task changed from 5 minutes to 1 minute so users appear more quickly
• Hedge against no users / mods online being returned on low traffic sites
• Protection against disabled plugin or ??? having task throwing errors into system log
• FIX! Malformed array return in certain situations now mitigated.

This is not about the app scanner specifically, sort of... It's more the case of the App Scanner exposing a long-term issue (it's not been a real problem until now).

Given how long the 4 series has been out in the wild, there is a LOT of relic code laying about. I'm talking about applications with sources directories/files that are no longer used and leftover stuff in the interface directories.

Naturally, the App Scanner is now flagging a lot of this stuff - at least at the log level. That's not a big deal but the hitch is this: If I remove interface files and directories, or source files and directories, from my application and upload the new version, the upgrade process does not iterate through what's in the updated app versus what's on the server. So the relic directories and files remain, and the scanner is finding them and flagging them (again, just logs for now as far as I can tell).

Self-hosted people can deal with this easily enough - just get on the server and delete the files and directories. That's not a viable solution for CIC users.

If you want us to write out the code on upgrades to nuke these things I'm sure we can do that. I'm equally sure that's the last thing you want us to code up and throw at your CIC infrastructure.

Thoughts?

First come, first served. PMs only. And I will need ACP access and your ears and eyes. Maybe a bit o' brain too. The thing covers the plugins and this app but I would like a volunteer for testing before submitting. If what I just wrote is confusing, you are probably not who I am looking for...

Version 15 Submitted!

• DateTime screwy-ness dealt with
• New preview options in ACP
• Month Day, Year option is now relative for early days. Then you get Month Day, then you get the full ride. If there is a hew and cry I'll add in a hard M D, Y option.

If you've been paying attention around these forums you've seen more than a few date time buggy type things happening and this was (probably) caught up in all that so I'm just battening down until we get all up in the PHP 8's for real and waiting for this storm to pass.

Haven't forgot the requested adds - just slammed right now with impending PHP 8 stuff + real life whatevers.

Upgrade when it appears in the MP. Thanks to @Genestoy for pointing out the wack.

Support topic for both. PMs fine as well.

Most, if not all of that is inbound but I'm getting slammed with requests for old stuff to be rebuilt right now so I'm parceling out time as I get some - not to mention all the other projects that have been waylaid.

Just want to put this bug in your ears, especially with the code checker now in place and the possibility it will get strict along these lines in the future. Apologies if this has already been noted recently (or way in the past) - have not looked too deeply here.

I've noticed more than a few instances of functions defined as static public instead of public static in code; mine and yours. Your source files have a couple (4?), your apps more, but I was more puzzled why my app and plugin hooks had a bunch as this isn't a thing I normally do.

As an example, a hook on baseCss() is routinely static public in the hook. So I looked and your method is clearly public static. So to test I just opened up the dev center and added a baseCss() hook, and it appends into the hook as static public.

I've probably never given this a moment's notice but with the checker forcing us to really work over the syntax it's kinda all jumps out now. Yes, I know, you are allowed to do this, it's 
"fine", but it's also not PSR kosher and if you start forcing this level of strictness through with the checker - well, at least give everyone fair warning before turning that on.

I'm changing them as I find them but having the dev center push these functions into the hooks correctly would be nice to have eventually.

There will be something, this is still hacky btw. Also what I release will prob be a paid thing (albeit cheap) that includes ACP widgets monitoring some of the external service statuses like so:

FWIW I re-engineered this this evening. Just about, if not, every username link, and userphoto can be targeted with CSS via data attributes [data-online="online"] and [data-online="offline"]

This will allow you guys who can do CSS to do things - even more so once the :has pseudo class gets supported (this will allow you to format a parent item that has a child with x,y or z - but this will still be awhile before we see this in wide support)

Anyways, I'm going to try and add some of the requests in and then we can talk about what's possible.

Note that if the userphoto or userlinks in this new system are generated with data (userLinkFromData, userPhotoFromData templates specifically) the online status is determined by a task running every five minutes to get that status. Given how online status is determined, and how it lingers, I doubt this is a big deal - just FYI.

Looking at the orig. plugin it didn't do most of that.

It did PMs (that's an easy add), but none of the other stuff you listed that I can tell. In fact, my supporting all application comment and review areas already far exceeds what the original did, unless I'm missing something.

So, what you are looking for is support on the content items themselves? Some of that is doable but it is all one at a time stuff by and large. Not only that but due to how activity stream and search results are pushed out, there would be (under the current model) loading the member objects for the members for each item to check if they are online or not (those links are not member objects but just created on the fly with basic data such as member id, member name, etc.)

I can see a somewhat universal (like, possibly everywhere) way around this though but still would need some thought. Especially if the solution to hooking everything everywhere is to just target the basic user photo and user link templates but that risks spillover in places unwanted. Not a lot of engineering at all, but it would be a sideways approach different than all the usual stuff we've done with this. Hmmm...

Shoot me a PM with some specific screenshots - I'm going to try and tackle some of the earlier requests here first, plus people are coming out of the wood work with "recreate this please!" requests due to all this old stuff going dark in a month or two (including two or three plugins that are required on a site I'm currently doing work for that I had no idea were in that pile so...)

11 minutes ago, Tripp★ said:

limited in scope, in comparison

What's missing? Aside from the adds already inbound based on earlier remarks.

50 minutes ago, Tripp★ said:

status blocks

Specifically? I just woke up so maybe mah brain ain't great right now.

54 minutes ago, Tripp★ said:

it kind of works

??? - unless you are on an early version of PHP 8.1 in which case you need to upgrade to PHP 8.1.10 or better to fix things (see these forums for the topic on this)

1. ✔️

2. ✔️

3.  but also ✔️

How badly do you want offline indicators? For the badge option it would be a horrible idea (just unnecessary distracting noise).

Let me get the support topic up so this thread can die. 

Only getting my morning coffee now,  support topic will be up shortly.

And @Genestoy that other thing will be submitted in a few hours.  Might be the tightest, most efficient, plugin I've done.

This was already submitted - sans Font Awesome - I'll add that as an option. Otherwise out of the gate it has dot next to name, outline user avatar, or online badge style next to the three dot post menu bit (where the author badge shows up)

FYI this is not just forums. Covers all commenting and reviews areas across the suite, and likely 3rd party apps as well if they are using (directly, not copying) the default templates involved there. 

Extra FYI: when it shows up in the MP it will be called Online Status

Where would you put the FA icon? Replace the dot? Replace the badge? Both?

52 minutes ago, Anawa said:

There was only an icon and date next to it. Something similar as it is now with posts and solutions count.

So literally just an icon, and then the date - so this?

[icon] 10/1/2022 (and on hover Joined October 1st, 2022)

Or, maybe a better look here since this is all minimal, just the year:

[icon] 2022 (and on hover Joined October 1st, 2022)

I think the latter would look better and make more sense.

I'll jab CJ with a pointed stick for you guys (tomorrow...)

	public static function roundedDiffFromSeconds( $seconds, $memberOrLanguage=NULL )
	{
		$now 	= static::ts( time() );
		$then	= static::ts( time() - $seconds );
		return $now->roundedDiff( $then, $memberOrLanguage );
	}

Don't panic! This is not related to all the other DateTime shenanigans going on. Just a small bug with a big return - routinely 52 years.

The problem is having $then calculated as time() - $seconds. That needs to just be seconds:

$then = static::ts($seconds);

You only use this in one spot (admin\stats\timeToSolved.phtml) that I can see so probably just been overlooked for a while.

Full Explained working on something not quite two minutes old:

$now: 1663390800
$then:  1663390800 - 1663390700 = 100
$now->roundedDiff ($then);

roundedDiff then immediately calculates its own difference:

$this->diff($date) which in this case is $this->diff(100) which is the difference between right now and 100 seconds after January 1, 1970 midnight UTC.
 

Based on that plugin what formatting do you want? This is just a few minutes of work, if that. 

Version 14 submitted!

• 4.7 compatible
• Changed hook points in post templates
• "Month Day, Year" format now actually "Month Day, Year" instead of IPS relative.

The hook points needed changing to account for newer structure there. The first option to force it to the bottom remains as is. The other two options, above or below post count, are now technically, above and below the data-role="stats" section which contains the post count stuff. Within that is another UL list and it is all flex based so rather than deal with all that I'm just staying out of it.

And yes, the former MDY option was just IPS relative style so you probably had 1 year ago, 2 years ago, and so on there. This is patched now. If there is a want/need for the relative style just yell, it's just a few minutes to add to the template and an additional setting.

Available in the MP when approved.

On 10/2/2020 at 12:13 PM, Anawa said:

Any possibility to add this as one of the options? I actually enjoyed that formating (without additional text - only icon and date + tooltip).

Care to remind me exactly what this was?