Group Mention

[kRSB]

On 11/5/2021 at 8:02 AM, Afrodude said:

Hi @kRSB just wanted to report that groups mention doesn't work with IPS new feature anonymous post. 

 

Whenever you have time no need to rush, please check it out. 

Hey @Afrodude, I took another look at this:

As you know Group mentions are only allowed for certain groups which can be configured in the settings of ACP. So when someone posts a group mention I check if the user is in the allowed groups, however when that person posts as "Anonymous" IPB returns a Guest account for the author, here is the code piece below:

if( $this->isAnonymous() )
{
   $guest = new \IPS\Member;
   $guest->name = \IPS\Member::loggedIn()->language()->addToStack( "post_anonymously_placename" );
   return $guest;
}

So I can't check if that user is in the allowed groups, so the only way to make this work would be to allow everyone who posts as Anonymous to use group mentions but that doesn't sound like a good idea to me 😛 

[Afrodude]

I see @kRSB thank you for your time looking into it. 

[Armbian_Werner]

Hey there,

 

we just installed this addon but had to notice for some reason when trying to add a mention for a group their name is blank:

When I click on one of the results there is a blank @

Any idea what's wrong?

Cheers

Werner

 

Edited January 30, 2022 by Armbian_Werner

[kRSB]

3 hours ago, Armbian_Werner said:

Hey there,

 

we just installed this addon but had to notice for some reason when trying to add a mention for a group their name is blank:

When I click on one of the results there is a blank @

Any idea what's wrong?

Cheers

Werner

 

Hey,

is the color of your group white perhaps? it shows it in the color of the group:

But it's strange that you get an empty @ though, can you try it on the default theme?

[Armbian_Werner]

1 hour ago, kRSB said:

Hey,

is the color of your group white perhaps? it shows it in the color of the group:

 

Our groups do not have colors assigned.

 

Quote

But it's strange that you get an empty @ though, can you try it on the default theme?

I tried with three different themes including default.

 

Cheers

Werner

[kRSB]

7 minutes ago, Armbian_Werner said:

Our groups do not have colors assigned.

 

I tried with three different themes including default.

 

Cheers

Werner

Ah damn, I first thought it would be related to a group having no color but that also seems to work for me:

 

To be 100% sure it's not related to the color, could you try giving 1 of your groups a color and check if that shows up?

[Armbian_Werner]

4 minutes ago, kRSB said:

To be 100% sure it's not related to the color, could you try giving 1 of your groups a color and check if that shows up?

Sure thing. Just tried that but unfortunately no change.

 

Cheers

Werner

[Ravion]

Nice work, useful.

[kRSB]

20 hours ago, Armbian_Werner said:

Sure thing. Just tried that but unfortunately no change.

 

Cheers

Werner

Do you mind sharing ACP info via PM? I would need to have a closer look if none of the above solves it.

Edited January 31, 2022 by kRSB

[bradl]

In my test "group of one" the mention returns the test member if group membership is primary; if group membership is secondary hovering reports: " No members found in this group"

Same for a group of 8 (Officers and Board, secondary group) "No members found in this group" — both groups have permission to mention and be mentioned. 

IPS 4.6.9 / GM 1.0.8

Edited January 31, 2022 by bradl

[kRSB]

21 hours ago, bradl said:

In my test "group of one" the mention returns the test member if group membership is primary; if group membership is secondary hovering reports: " No members found in this group"

Same for a group of 8 (Officers and Board, secondary group) "No members found in this group" — both groups have permission to mention and be mentioned. 

IPS 4.6.9 / GM 1.0.8

submitted a new version for approval which will fix this

On 1/15/2022 at 6:04 PM, Nakamura0114 said:

Using 4.6.9. 

I reproduced by editing an article on a custom page.

With Articles you mean a Pages Database right? Let me see if I can hook into that to prevent notifications on edit

[Nakamura RTS]

14 hours ago, kRSB said:

submitted a new version for approval which will fix this

With Articles you mean a Pages Database right? Let me see if I can hook into that to prevent notifications on edit

Yep that's right, page DBs.

[LiquidFractal]

Thanks for the recent update!  However, I do have a question.

I notice that when you mouse over the mentioned group name there's a pop-up window listing all the members of that group.  Is it possible to limit this in case you are addressing a group in which some members might not want their membership known for privacy reasons?

[kRSB]

On 2/2/2022 at 11:14 AM, Nakamura0114 said:

Yep that's right, page DBs.

Sorry for the late reply, I thought I already replied to this. But unfortunately mentions works differently for Pages Content, Right now it's not possible to hook into this code. I'll try get in contact with an IPS Dev to see if they make this function more hookable in the future so I can dd this.

On 2/3/2022 at 9:49 PM, LiquidFractal said:

Thanks for the recent update!  However, I do have a question.

I notice that when you mouse over the mentioned group name there's a pop-up window listing all the members of that group.  Is it possible to limit this in case you are addressing a group in which some members might not want their membership known for privacy reasons?

Do you want an option for members to disable it theirselves (for example on their profile). Or for admins to select a complete group to not show the members in the group listing?

------------------------------------------------------------------------------------------------------

Also update for 4.7 has been pushed, waiting on mod review now 🤞

Edited July 22, 2022 by kRSB

[LiquidFractal]

On 7/23/2022 at 6:06 AM, kRSB said:

for admins to select a complete group to not show the members in the group listing

This would be exactly what I had in mind.  Thanks for listening! 👍

[Birgit Schultz]

Hi, 

I just saw the notice regarding the new 4.7.2.1 update of ipboard and wonder whether Group Mention will be compatible with PHP 8. 

Edited September 16, 2022 by Birgit Schultz

[kRSB]

On 9/16/2022 at 2:34 PM, Birgit Schultz said:

Hi, 

I just saw the notice regarding the new 4.7.2.1 update of ipboard and wonder whether Group Mention will be compatible with PHP 8. 

Worked fine on my local install so should normally be safe. Let me know if you run into any issues

[Douglas Glover]

On 9/18/2022 at 1:23 PM, kRSB said:

Worked fine on my local install so should normally be safe. Let me know if you run into any issues

Hi, I'm seeing an issue with some plugin but I can't pinpoint which exactly. Invision has advised I should reach out to plugin authors to ask them to update compatibility.

Users are getting erroneous emails and all I can do is to disable all plugins which haven't been updated specifically for the latest PHP to try and determine the cause.

[Afrodude]

@kRSB Hi,

Whenever someone reported that groups will receive new notification on editing the topic, and then you released a new version to fix this issue. Now this issue causing anther issue that if you want to edit your post and add a new mention to a member or group it wouldn't send any notifications, and you must create a new post in order to mention a new member or group.

[kRSB]

On 12/8/2022 at 11:09 PM, Afrodude said:

@kRSB Hi,

Whenever someone reported that groups will receive new notification on editing the topic, and then you released a new version to fix this issue. Now this issue causing anther issue that if you want to edit your post and add a new mention to a member or group it wouldn't send any notifications, and you must create a new post in order to mention a new member or group.

Ok thanks for reporting. I'll take a look

[kRSB]

On 12/8/2022 at 11:09 PM, Afrodude said:

@kRSB Hi,

Whenever someone reported that groups will receive new notification on editing the topic, and then you released a new version to fix this issue. Now this issue causing anther issue that if you want to edit your post and add a new mention to a member or group it wouldn't send any notifications, and you must create a new post in order to mention a new member or group.

Hey @Afrodude,

I was trying to reproduce it this weekend but I didn't manage to, the way I tested:

1) Create a new topic where I mention group X

2) Login as a member of group X 

3) Member gets the notification

4) Edit the topic and also mention group Y

5) Login as member of group Y

6) Member gets the notification

7) Edit the topic and also mention Member "Test"

8 ) Login as member "Test"

9) Member "Test" gets the notification

10) Edit the topic and also mention member "Test2"

11) Login as member "Test2"

12) Member "Test2" gets the notification

13) Edit the topic and also mention group Z

14) Login as member of group Z

15) Member gets the notification

I assume you are running latest version of groupmention and IPB? I think there might be another plugin or app that is conflicting

 

[Afrodude]

6 hours ago, kRSB said:

I assume you are running latest version of groupmention and IPB? I think there might be another plugin or app that is conflicting

Yes, I am. I will test again, and I will report back. Thank you.

[Gesundheit]

Post deleted.

 

Edited January 24, 2023 by Gesundheit

[kRSB]

New update: fixed issue with PHP 8.1 and the queuing of the notifications