Quoted spoiler bug

[bchan009]

It seems like if you quote a post with a spoiler in it you can get unwanted behavior.

If you open the spoiler before expanding the quote it is fine.

If you expand the quote and then try to open the spoiler, it overflows the quote box.

 

This happens on the 4.5 default theme. I have replicated it on a live site as well as a local testing site.

 

EDIT: I have found the potential source of the problem.

Normally a truncated quote has a set height of 168px. 

<div class="ipsQuote_contents ipsClearfix ipsTruncate" 
     data-ipstruncate="true" 
     data-ipstruncate-type="hide" 
     data-ipstruncate-size="7 lines" 
     data-ipstruncate-expandtext="Expand" 
     style="position: relative; height: 168px;">

When you click 'Expand' the height is supposed to change to 'auto' -- but in certain situations, the height is still hard-coded to 168px.  Here is an example where the user clicks 'Expand' but the height property is not changing like it should:

<div class="ipsQuote_contents ipsClearfix" 
     data-ipstruncate="true" 
     data-ipstruncate-type="hide" 
     data-ipstruncate-size="7 lines" 
     data-ipstruncate-expandtext="Expand" 
     style="position: relative; height: 168px;">

Because the expanded quote is still hard-coded with a 168px height, the spoiler inside will now overflow from its boundaries:

Again this only happens if you click 'Expand' on the quote BEFORE you open the spoiler.  If you open the spoiler first then everything is fine.

Edited October 23, 2020 by bchan009

[bfarber]

We have an open internal bug report on this issue already. 

[idioteque]

I got a problem with the spoiler tag. It doesn't work

Edited July 13 by idioteque

[SeNioR-]

12 hours ago, idioteque said:

. It doesn't work

What do you mean by that? How does it not work?

Edited July 14 by SeNioR-

[13.]

  Working spoiler

It works.

@idioteque, explain your problem in more detail.

[Nathan Explosion]

13 hours ago, idioteque said:

I got a problem with the spoiler tag. It doesn't work

By tag, do you mean the bbcode?

[spoiler]TEST[/spoiler]

If so, then BBCODE parsing is being deprecated in the software and is disabled by default on a new installation of 4.5.x onwards (if upgrading from an earlier version then a choice to leave  enabled/disable is presented when upgrading)

If you wish to turn it back on: