jcdesign Posted March 20, 2018 Posted March 20, 2018 Download Plus is not working properly with the new IPS 4.3. I have deactivted this to the next update. ?
CodingJungle Posted March 20, 2018 Author Posted March 20, 2018 4 minutes ago, jcdesign said: Download Plus is not working properly with the new IPS 4.3. I have deactivted this to the next update. ? 4.3 is in beta, i don't support the beta releases. Sirmadsen 1
SJ77 Posted March 20, 2018 Posted March 20, 2018 2 hours ago, CodingJungle said: 4.3 is in beta, i don't support the beta releases. oh no.. I think it might be a good idea to get download plus working sooner than later. I doubt much will be changing from beta to final release. I need download plus ready to go when 4.3 launches. Are you able to help? Thank you
CodingJungle Posted March 20, 2018 Author Posted March 20, 2018 1 minute ago, SJ77 said: oh no.. I think it might be a good idea to get download plus working sooner than later. I doubt much will be changing from beta to final release. I need download plus ready to go when 4.3 launches. Are you able to help? Thank you with no time table from IPS when 4.3 will go from beta to finale (it really seems to be on a cats meow when they make that decision), i myself can't be certain if downloads plus will be available for the release of it (as i haven't even upgrade my development boards to 4.3, as i'm still working on apps for clients that are still in 4.2.7/8). It has also been in my experience, that i have had things working in beta 1 of a new release, only for it to go to finale and the app does not work or malfunctions on the last beta or the finale (so its usually not worth the time to get it working on the alpha's or the early beta's). so i usually wait till the finale is available before releasing anyway (due to the changes that i've seen happen from say like beta 8 with the next release being finale and my app not working or malfunctioning between to those 2 releases). SJ77 1
Unlucky Posted March 21, 2018 Posted March 21, 2018 On 19/03/2018 at 4:12 PM, CodingJungle said: Member->Admins How do I get to that section? Thanks
slushpuppeh Posted March 21, 2018 Posted March 21, 2018 (edited) Are there any plans to fix proxy class generation for Storm in 4.2? Edited March 21, 2018 by slushpuppeh
CodingJungle Posted March 21, 2018 Author Posted March 21, 2018 6 hours ago, Unlucky said: How do I get to that section? Thanks ACP->Members->Staff->Administrators 4 hours ago, slushpuppeh said: Are there any plans to fix proxy class generation for Storm in 4.2? you will have to be more specific, i just ran the proxyclass generator ins 4.2.8 in storm and it worked without any issues.
slushpuppeh Posted March 21, 2018 Posted March 21, 2018 13 minutes ago, CodingJungle said: ACP->Members->Staff->Administrators you will have to be more specific, i just ran the proxyclass generator ins 4.2.8 in storm and it worked without any issues. Thanks for the reply. Yes the class files are generated but methods are omitted.. so phpstorm doesn't recognize any methods to be called from the objects. This is a sample output using both your debug and main builds Quote class Topic extends _Topic{ public $tid = ''; public $title = ''; public $state = ''; public $posts = ''; public $starter_id = ''; public $start_date = ''; public $last_poster_id = ''; public $last_post = ''; public $starter_name = ''; public $last_poster_name = ''; public $poll_state = ''; public $last_vote = ''; public $views = ''; public $forum_id = ''; public $approved = ''; public $author_mode = ''; public $pinned = ''; public $moved_to = ''; public $topic_firstpost = ''; public $topic_queuedposts = ''; public $topic_open_time = ''; public $topic_close_time = ''; public $topic_rating_total = ''; public $topic_rating_hits = ''; public $title_seo = ''; public $moved_on = ''; public $topic_archive_status = ''; public $last_real_post = ''; public $topic_answered_pid = ''; public $popular_time = ''; public $featured = ''; public $question_rating = ''; public $topic_hiddenposts = ''; public $topic_meta_data = ''; }
CodingJungle Posted March 21, 2018 Author Posted March 21, 2018 its a proxy class it doesn't copy over the methods. the properties it creates are DB fields so when you reference them in your code like $this->title_seo it doesn't mark it as a warning and say property is generated dynamically. so since it's a proxy, it extends the realclass the one with the _ in front of it, it should read the methods that are inherited by the proxy. this video shows both the generated properties for the proxy class being used (the ones created for IPS\Settings) and the class methods being inherited to the proxy class for \IPS\forums\Forum from \IPS\forums\_Forums as well as it finding \IPS\Db and \IPS\Helpers\Table\Db. so it might be a configuration problem with your phpstorm, as i use phpstorm and it works as intended.
CodingJungle Posted March 21, 2018 Author Posted March 21, 2018 you might also want to check that the "proxyclass" folder is in your projects root and that its not "excluded", if it is, go to file->invaldiate caches/restart, this will force phpstorm to reindex the project (but you will loose localhistory when you do this).
CodingJungle Posted March 22, 2018 Author Posted March 22, 2018 On 3/20/2018 at 3:24 PM, SJ77 said: oh no.. I think it might be a good idea to get download plus working sooner than later. I doubt much will be changing from beta to final release. I need download plus ready to go when 4.3 launches. Are you able to help? Thank you loaded up 4.3 tonight, and installed dplus, it seems to be the only problem with it was they change \IPS\Content\ReportCenter interface to a \IPS\Content\Reportable trait. changed that, all seems to be working now. SJ77 1
Cyboman Posted March 26, 2018 Posted March 26, 2018 For Babble Chat Self Hosted: After I upgrade the babble app, do I have to also regenerate and replace the babble.js and package.json files each time? Currently I upgrade from 2.6.4 to 2.6.5: are new serverside files (^^) required after upgrade?
CodingJungle Posted March 26, 2018 Author Posted March 26, 2018 2 hours ago, Cyboman said: Currently I upgrade from 2.6.4 to 2.6.5: are new serverside files (^^) required after upgrade? just the babble.js is required on the 2.6.5 upgrade to be replaced.
TheJackal84 Posted March 28, 2018 Posted March 28, 2018 (edited) On 22/03/2018 at 6:06 AM, CodingJungle said: loaded up 4.3 tonight, and installed dplus, it seems to be the only problem with it was they change \IPS\Content\ReportCenter interface to a \IPS\Content\Reportable trait. changed that, all seems to be working now. Only testing upgrading the localhost from 4.2 - 4.3 I am getting errors on dPlus on the questions. In dev mode it throws Method IPS\dplus\Questions\Answers::__toString() must not throw an exception, caught Error: Undefined constant 'IPS\HTMLENTITIES' out of dev its a white page Fatal error: Method IPS\dplus\Questions\Answers::__toString() must not throw an exception, caught Error: Undefined constant 'IPS\HTMLENTITIES' in C:\xampp\htdocs\ips43\system\Theme\Theme.php(824) : eval()'d code on line 0 that is just opening the questions tab Seems to be in sources/questions/answers on line 70 public function get_ans(){ $answer = $this->_data['answer']; $length = 100; $file = $this->parentage()->parentage(); $url = $file->url()->setQueryString(['do' => 'readMoreAnswer', 'aid' => $this->id ] ); return htmlspecialchars( mb_substr( html_entity_decode( $answer ), 0, $length ), ENT_QUOTES | \IPS\HTMLENTITIES, 'UTF-8', FALSE ) . ( ( mb_strlen( html_entity_decode( $answer ) ) > $length ) ? "<a href='#' data-ipsDialog data-ipsDialog-url='{$url}'> ...Read More</a>" : '' ); } when replacing the return with return ''.mb_substr( $answer, $limit ).'<a href="'.$url.'" data-ipsDialog> ...Read More</a>'; it works fine Edited March 28, 2018 by TheJackal84
CodingJungle Posted March 28, 2018 Author Posted March 28, 2018 11 hours ago, TheJackal84 said: Only testing upgrading the localhost from 4.2 - 4.3 I am getting errors on dPlus on the questions. In dev mode it throws Method IPS\dplus\Questions\Answers::__toString() must not throw an exception, caught Error: Undefined constant 'IPS\HTMLENTITIES' out of dev its a white page Fatal error: Method IPS\dplus\Questions\Answers::__toString() must not throw an exception, caught Error: Undefined constant 'IPS\HTMLENTITIES' in C:\xampp\htdocs\ips43\system\Theme\Theme.php(824) : eval()'d code on line 0 that is just opening the questions tab Seems to be in sources/questions/answers on line 70 public function get_ans(){ $answer = $this->_data['answer']; $length = 100; $file = $this->parentage()->parentage(); $url = $file->url()->setQueryString(['do' => 'readMoreAnswer', 'aid' => $this->id ] ); return htmlspecialchars( mb_substr( html_entity_decode( $answer ), 0, $length ), ENT_QUOTES | \IPS\HTMLENTITIES, 'UTF-8', FALSE ) . ( ( mb_strlen( html_entity_decode( $answer ) ) > $length ) ? "<a href='#' data-ipsDialog data-ipsDialog-url='{$url}'> ...Read More</a>" : '' ); } when replacing the return with return ''.mb_substr( $answer, $limit ).'<a href="'.$url.'" data-ipsDialog> ...Read More</a>'; it works fine they use to have this in init.php: 'HTMLENTITIES' => ( version_compare( phpversion(), '5.4.0', '<' ) ) ? ENT_IGNORE : ENT_DISALLOWED, i guess they are clearing out the code for php 5.3 work around's they had in there for 4.0 when it was php 5.3+
TheJackal84 Posted March 28, 2018 Posted March 28, 2018 Just now, CodingJungle said: they use to have this in init.php: 'HTMLENTITIES' => ( version_compare( phpversion(), '5.4.0', '<' ) ) ? ENT_IGNORE : ENT_DISALLOWED, i guess they are clearing out the code for php 5.3 work around's they had in there for 4.0 when it was php 5.3+ Would be nice to see a list of changes / whats removed instead of us finding out the hard way lol. Hope that helps anyway when you start on the update, I have not come across any other errors with it while I been testing my dev board upgrade to 4.3 on localhost. And I still think this is the best app, I would not like to see my downloads pages without it, If anyone is thinking of buying it STOP THINKING and get it, its worth 4x the price
CodingJungle Posted March 28, 2018 Author Posted March 28, 2018 6 minutes ago, TheJackal84 said: its worth 4x the price you can buy it multiple times ya know ? Support tab will also explode cause of the ReportCenter being moved from a interface to a trait (which i think is called Reportable). that is what i've ran into mostly with my apps, is the reportcenter thing. on babble, emojis don't work at all, but that is just a matter of updating the code that handles it (as the JS and text parsing stuff has changed a bit).
jp Posted March 29, 2018 Posted March 29, 2018 (edited) Keywords Tooltips - how can i have an editor when writing the tooltip content/description? and add pictures etc like the editor you have when you post in forums etc, Edited March 29, 2018 by jp
jp Posted March 29, 2018 Posted March 29, 2018 Keyword Tooltip - only set the keywords menu to be visible to admins, only set the keywords member groups to be visible to administrators. added a tooltip and logged out and as a guest could see the tooltip in the activity stream!!!! and could click on it and was taken to the keywords page. This shouldn't happen! 2nd problem - keywords didn't actually work. i added one keyword, then went to a forum post and found that word and nothing. I checked that i had tooltips selected only for Topics which was what i was in. can you please fix. I am running IPS 4.2
CodingJungle Posted March 30, 2018 Author Posted March 30, 2018 17 hours ago, jp said: Keywords Tooltips - how can i have an editor when writing the tooltip content/description? and add pictures etc like the editor you have when you post in forums etc, there is no option for this, as a lot of people wanted a way to put in html/js (for ads ), the editor doesn't allow this. so a codemirror is what is used. you can use bbc code here if you don't want to use HTML. I don't see this changing anytime in the future. 17 hours ago, jp said: Keyword Tooltip - only set the keywords menu to be visible to admins, only set the keywords member groups to be visible to administrators. added a tooltip and logged out and as a guest could see the tooltip in the activity stream!!!! and could click on it and was taken to the keywords page. This shouldn't happen! i'm not sure i follow? keywords don't parse on the activity stream. if you mean the record is showing for the kw, that will be fixed in the next version as i'm removing it from activity streams. 17 hours ago, jp said: 2nd problem - keywords didn't actually work. i added one keyword, then went to a forum post and found that word and nothing. I checked that i had tooltips selected only for Topics which was what i was in. can you please fix. check your group settings, there is a "keywords" tab, keywords don't parse by default, you have to give the group the ability to see them being parsed (showing up in a topic).
jp Posted March 30, 2018 Posted March 30, 2018 (edited) 5 hours ago, CodingJungle said: there is no option for this, as a lot of people wanted a way to put in html/js (for ads ), the editor doesn't allow this. so a codemirror is what is used. you can use bbc code here if you don't want to use HTML. I don't see this changing anytime in the future. that is unbelievable, so you're saying that you made this app for people to put ads in tooltips! What about normal people that want to use it for actual tooltips! I want to write a page for each tooltip and currently not having an editor makes this app useless. if i had known I wouldn't have bought the app, especially considering it is one of the most expensive on the marketplace ? 5 hours ago, CodingJungle said: i'm not sure i follow? keywords don't parse on the activity stream. if you mean the record is showing for the kw, that will be fixed in the next version as i'm removing it from activity streams. well in my activity stream there was a entry for the new keyword i had just created for all the world to see, guests etc. i had it set that only Administrators could see the menu to the keywords app and also that no member groups could view keywords apart from administrators yet it was still visible in the activity stream and you could click on it and be taken to the keyword page when you shouldn't be able to see it as it should only be administrators. 5 hours ago, CodingJungle said: check your group settings, there is a "keywords" tab, keywords don't parse by default, you have to give the group the ability to see them being parsed (showing up in a topic). yes i forgot to mention that i did turn keywords on in all member groups as well, still no luck. Edited March 30, 2018 by jp
Sirmadsen Posted April 3, 2018 Posted April 3, 2018 (edited) Update for Dowloads Plus and IPS 4.3 coming? As it is now it breaks the entire files page. Edit- Never mind, didn't see your earlier answers about this. Eagerly waiting for 4.3 full release. Edited April 4, 2018 by Nesdam1981 Lazy
Sirmadsen Posted April 10, 2018 Posted April 10, 2018 Any cjance of this app adding support for chunked uploads or is that to difficult to implement in a app/plugin? SJ77 1
TheJackal84 Posted April 18, 2018 Posted April 18, 2018 @CodingJungle you didn't add the new divisions to the carousel's they are all broke, ( The screenshot and the other user's files ones ) under the <div class='ipsCarousel ipsClearfix' data-ipsCarousel data-ipsCarousel-showDots> you need to add <div class='ipsCarousel_inner'>
media Posted April 20, 2018 Posted April 20, 2018 Hey @CodingJungle Is Names to Avatar 4.3 compatible or not?
Recommended Posts