Referrals and guest cache

[LaCollision]

Hi Invision,

Something is bothering me with the new referral system on IPS 4.5.

In /Session/Front:

public function init()
{
	/* Get cached page if available */
	$this->checkCached();


	[…]

	/* Set a referral cookie */
	if( \IPS\Settings::i()->ref_on and isset( \IPS\Request::i()->_rid ) )
	{
		\IPS\Request::i()->setCookie( 'referred_by', \intval( \IPS\Request::i()->_rid ), \IPS\DateTime::create()->add( new \DateInterval( 'P1Y' ) ) );
	}

	[…]
}

 

Doesn't it look like that when a page is cached, the referral system doesn't work, as the page is sent before a cookie is set?

 

Thank you,

[bfarber]

Are you experiencing or reproducing a specific issue that we can investigate?

[LaCollision]

1 minute ago, bfarber said:

Are you experiencing or reproducing a specific issue that we can investigate?

Hi,

I can't unfortunately test it as guest cache is not activated on my installation, but I think it would be worth it if you took a look 🙂 

[Matt]

I've filed a bug report (5225) to check into this, thanks!