Suite Trader Feedback System

[7SiN]

Thanks, I'll let you know if it works.

Could I make a suggestion to this? Can you make it so that in the ACP options, there is an option so this mod is only enabled (to be used) in certain forums? I've got people leaving feedback in threads like they are giving someone +rep. I want to restrict it to our BST section(s).

[TheMorrigan]

Thanks, I'll let you know if it works.

Could I make a suggestion to this? Can you make it so that in the ACP options, there is an option so this mod is only enabled (to be used) in certain forums? I've got people leaving feedback in threads like they are giving someone +rep. I want to restrict it to our BST section(s).

Just purchased this and it's great - but can I second the above suggestion :D pretty please.. with cherries on top? ;)

[Novawave]

Thanks for the suggestion. I've added it to my list for the next version, which I'll try to release early next month.

[7SiN]

YAY! Thank you sooooo much! My users are abusing the crap out of it and will probably have to disable it until the next release.

<3

[sound]

Sounds like an error occurred, but error reporting is disabled?

It may be the notification issue. A small percentage of people seem to be affected by it. I asked in the contributor chat about it, and was directed to an IPB bug that might be the cause. Hopefully the next release resolves it.

In the mean time, here's a file edit to disable notifications: Comment out (//) lines 309-316 of /admin/applications_addon/other/feedback/modules_public/view/view.php. I'll post the edited file in the download area soon.

i had the blank screen problem

was resolved after I went into acp and saved the
Default Notifications Configuration options

[Novawave]

i had the blank screen problem

was resolved after I went into acp and saved the

Default Notifications Configuration options

Ah yeah, that's a better way to disable notifications, if you're having problems with them. I assume you unselected the options next to "Notify me when I receive feedback"?

Again, hopefully the issue will be resolved at the next IPB release.

[sound]

Ah yeah, that's a better way to disable notifications, if you're having problems with them. I assume you unselected the options next to "Notify me when I receive feedback"?

Again, hopefully the issue will be resolved at the next IPB release.

nope
I was getting the blank screen
then just visited the acp page and left the options as they already were (enabled) and just saved
this got rid of the blank screen and had limited success with inline notifications being sent


they were appearing in the inline notification table but not all columns are being filled

and maybe more importantly the member id seemed to be getting cut off


eg
member 1 - got inline notifications
member 6677 - did not as the member id was getting cut off to 6 in the inline notification table

a quick fix was to add this to view.php

$memberInfo = IPSMember::load( intval($userid) ); //added

					$classToLoad = IPSLib::loadLibrary( IPS_ROOT_PATH . '/sources/classes/member/notifications.php', 'notifications' );

					$notifyLibrary = new $classToLoad( $this->registry );

					$notifyLibrary->setMember($memberInfo); //changed

now seems to be getting inline notifications ok for members with ids greater than 9 - but have not fully tested yet

hope helps

[Novawave]

Interesting. Thanks for your insight! I've uploaded a new version of the script with this revision.

[ixps]

Haha, great mod, thank you. Maybe I'll buy!

[OurVQ.com]

There is a bug when a user tries to make a feedback on himself.

Could you fix this? Maybe have a not permitted redirect or something?

Thanks,

[Novawave]

What happens for you? It should display a permission denied error.

[OurVQ.com]

I got a server error...

[Novawave]

Could you post the error?

On my own installation, when leaving feedback for myself, it says "An Error Occurred - [#1] You do not have permission to perform this action"

[OurVQ.com]

I simply get 500 server error!

[OurVQ.com]

IPB 3.1.2 uses a different permission denied redirect technic.. Are you using that for your module?

[Novawave]

I'm running 3.1.2 as well. The code is as follows:

$this->registry->getClass('output')->showError($this->lang->words['noperms'], 1, false);

The docs mention the default HTTP status passed for showError() is 500. If you're seeing nothing but the 500 error, without the page content, I'd assume it's your server configuration. You can set the status code to 200 by making the following changes. I haven't tested it, but it should work.

$this->registry->getClass('output')->showError($this->lang->words['noperms'], 1, false, '', 200);

[OurVQ.com]

It is weird, because if I am not logged in, the permission denied works just fine. When I log in it doesnt work.. Give me server error.

here is the link I am testing:

http://www.ourvq.com/index.php?app=feedback&do=leave&u=1

[OurVQ.com]

OK, I forgot to change my Web Server configuration to not catch the access denied page. I will make that change and see if that fixes the problem.

I will let you know.

Thanks

[OurVQ.com]

Here is the error I get when trying to give feedback:

Fatal error: Uncaught exception 'Exception' with message 'BAD_NOTIFY_KEY' in c:websitesourvq.compwn_consolesourcesclassesmembernotifications.php:444 Stack trace: #0 c:websitesourvq.compwn_consoleapplications_addonotherfeedbackmodules_publicviewview.php(319): notifications->sendNotification() #1 c:websitesourvq.compwn_consoleapplications_addonotherfeedbackmodules_publicviewview.php(57): public_feedback_view_view->leave_feedback('5') #2 c:websitesourvq.compwn_consolesourcesbaseipscontroller.php(296): public_feedback_view_view->doExecute(Object(ipsRegistry)) #3 c:websitesourvq.compwn_consolesourcesbaseipscontroller.php(101): ipsCommand->execute(Object(ipsRegistry)) #4 c:websitesourvq.compwn_consolesourcesbaseipscontroller.php(65): ipsController->handleRequest() #5 C:Websitesourvq.comindex.php(26): ipsController::run() #6 {main} thrown in c:websitesourvq.compwn_consolesourcesclassesmembernotifications.php on line 444

[Novawave]

Check some previous posts for info on this error. If you have 1.0.3 uploaded, simply do this in the ACP, under Notification Defaults:

then just visited the acp page and left the options as they already were (enabled) and just saved

this got rid of the [error] screen

[OurVQ.com]

I have 1.0.0... I didn't know there was an update? I purchased it Wednesday and this is the version it downloaded. Where can I get this upgrade?

[Novawave]

The version in the admin control panel shows 1.0.0, because there's no need to run the upgrader.

The download on http://novascripts.com is currently 1.0.3. You just need to upload the files and you'll be up-to-date.

[OurVQ.com]

I uploaded the 1.0.3 version and I still get that error when trying to send someone a feedback.

If I go back to the user's feedback, I can see my feedback. It is only when I submit a new feedback that I get the PHP error.

Can you help?

[Novawave]

Did you also follow the instructions above with the admin panel?

[OurVQ.com]

I don't quite understand exactly what needs to be done in the admin panel. Can you elaborate?

Thanks,