AndyF Posted December 29, 2009 Share Posted December 29, 2009 I thought about a bug report, but decided its probably WAI, hence this topic. :) I wonder if its possible to have differing error messages for disabled parts of the board when Performance Mode is enabled, reason simply being new (to IP.Board) admins may be confused as to the cause. As an example from a recent topic, the messenger was disabled. We worked through the usual causes (group permission / members had not disabled their messenger / checked the db to ensure members_disable_pm was at 0) The cause was because performance mode was enabled, although the error message (code 10227) simply indicated the member has disabled their messenger...if ( $this->member->getProperty('members_disable_pm') ) { $this->registry->getClass('output')->showError( 'messenger_disabled', 10227 ); } Unless I have misunderstood the code snippet. Anyway my suggestion: Separate errors for disabled areas when its due to performance mode (assuming its reasonably feasible and not a security risk) , simply as due to the error code generated Performance Mode was not one of the first places I would of looked... :) Link to comment Share on other sites More sharing options...
bfarber Posted December 29, 2009 Share Posted December 29, 2009 Performance mode was a relatively easy feature to implement in it's current state. To do what you are talking about however, would be a lot of work lol. Not hard, mind you, but adding a lot of code to various parts of the board to determine if performance mode is on and whether that's the cause of the setting being disabled. Link to comment Share on other sites More sharing options...
AndyF Posted December 29, 2009 Author Share Posted December 29, 2009 Fair enough. Can see that as we'd need to do an additional check and then throw a slightly different error message. Was just a quick thought really. :) Maybe something to consider for a future (3.2 maybe?) release. Link to comment Share on other sites More sharing options...
Amy T Posted December 29, 2009 Share Posted December 29, 2009 I like this idea would make it easier to find out why members are saying they are getting an error. Link to comment Share on other sites More sharing options...
Lewis P Posted December 29, 2009 Share Posted December 29, 2009 Maybe a check in the showError method? If performance mode is on, just append the error number with a P or something. That way, it's different, but the main error number is the same for admins who don't know the difference? Link to comment Share on other sites More sharing options...
bfarber Posted December 29, 2009 Share Posted December 29, 2009 Maybe a check in the showError method? If performance mode is on, just append the error number with a P or something. That way, it's different, but the main error number is the same for admins who don't know the difference? That would be easy enough to do. Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.