Beta 1 - theme editing - 'navigation icons' effect on top-level menu items

Could you please clear your browser cache and check this again? Im seeing them no problem on my end

I always clear cache before submitting, so already done.

I know it’s a simple answer, but you’ve edited these icons in Menu Manager in the AdminCP right?

I know I had to do it when I upgraded to Beta 1 for this same reason. After choosing the Font Awesome icons, they displayed correctly.

Just now, Gary said:

I know it’s a simple answer, but you’ve edited these icons in Menu Manager in the AdminCP right?

Aware of that, yes but I'm reporting a bug with the front-end functionality - if the above is a requirement for it to display an icon correctly then the front-end should alert to that being a requirement.

Additionally, the ACP icon advice is:

"You may pick a custom icon for this menu item. If none is selected, a context relevant default icon may be used"

• "May" implies a choice
• "Must" would imply a requirement.

And as none is selected (because it isn't a requirement) then the 'context relevant default icon' should be a 'context relevant' icon, not what appears (to a layman) to be a broken FA icon (it's actually just the one indicated) considering that the sub-menu items all have a 'context relevant' icon.

I thought so, haha. Thanks for elaborating.

Something like this would be more logical than the existing image:

• eye
• list-ul (which is the one used for some of the 'Activity' sub-menu items)
• cart-shopping (which is the one used for the 'Store' sub-menu item)

Is it the standard store item being used, or an external link? Im asking as for me its showing

It's your menu manager, as-is.

If you're not seeing the issue, fine - I've reported it, I am happy.

I confirm this bug. And if you look at the code - a specific icon is missing...

PS. Also in drop-down menu icon My details is the same bug...

27 minutes ago, Marc said:

Is it the standard store item being used, or an external link? Im asking as for me its showing

@Marc - just spotting you specifically mentioning 'Store' there, and it appears you have been led easily by my indicator arrow.

I'm not only referring to the 'Store' here. Look at the icon to the left of each of the top-level menu items.

Without any added icons (just the defaults) the 'default' for them all is file-image

With me adding icons:

For reference only, if I do this IN_DEV then the store icon appears fine.

Adding a var_dump on navBarItems, the $roots for those 3 menu items are:

C:\wamp64\www\dev\ips_50_dev_a\system\Theme\Theme.php(3678) : eval()'d code:15:
array (size=3)
  1 => 
    object(IPS\core\extensions\core\FrontNavigation\CustomItem)[215]
      public string 'defaultIcon' => *uninitialized*
      protected ?array 'subItems' => null
      protected array 'configuration' => 
        array (size=2)
          'menu_custom_item_url' => string 'https://localhost/dev/ips_50_dev_a/' (length=35)
          'menu_custom_item_target_blank' => boolean false
      public ?int 'id' => int 1
      public array|string|null 'permissions' => string '*' (length=1)
      public string 'menuTypes' => string '*' (length=1)
      public ?array 'icon' => null
      public int 'parent' => int 0
  2 => 
    object(IPS\core\extensions\core\FrontNavigation\CustomItem)[251]
      public string 'defaultIcon' => *uninitialized*
      protected ?array 'subItems' => null
      protected array 'configuration' => 
        array (size=4)
          'menu_custom_item_url' => string 'app=core&module=discover&controller=streams' (length=43)
          'menu_custom_item_target_blank' => boolean false
          'internal' => string 'discover_all' (length=12)
          'seoTitles' => 
            array (size=0)
      public ?int 'id' => int 2
      public array|string|null 'permissions' => string '*' (length=1)
      public string 'menuTypes' => string '*' (length=1)
      public ?array 'icon' => null
      public int 'parent' => int 0
  16 => 
    object(IPS\nexus\extensions\core\FrontNavigation\Store)[248]
      public string 'defaultIcon' => string '\f07a' (length=5)
      protected ?array 'subItems' => null
      protected array 'configuration' => 
        array (size=0)
          empty
      public ?int 'id' => int 16
      public array|string|null 'permissions' => null
      public string 'menuTypes' => string '*' (length=1)
      public ?array 'icon' => null
      public int 'parent' => int 0

That last one is Store - and looking at that IPS\nexus\extensions\core\FrontNavigation\StoreFrontNavigation extension, there is a defaultIcon value that is cart-shopping

/**
	 * @var string Default icon
	 */
	public string $defaultIcon = '\f07a';

But the 'Browse' and 'Activity' roots are generated from IPS\core\extensions\core\FrontNavigation\CustomItem, and there is no defaultIcon value in them so the file-image icon will be used for them.

If you have manually added that as a submenu, then yes you would need to choose an appropriate icon, as the system wouldnt know what it is. However the default setup, does indeed show the store icon

9 minutes ago, Marc said:

If you have manually added that as a submenu

I haven't...it's your own menu manager as-is

9 minutes ago, Marc said:

However the default setup, does indeed show the store icon

I give up.

41 minutes ago, Nathan Explosion said:

 

I haven't...it's your own menu manager as-is

 

I give up.

OK, let me rephrase, as I realise you feel Im hung up on the store icon itself. By default it was showing browse icon, the activity icon, and the store icon at the top level (not the one under it), when I change to icons. I'm certainly not ignoring what you are saying, I simply wasnt seeing the issue.

That said, what I have realised is something must have changed from alpha to beta. As while when I switched them on they were all fine, if I then reset the menu to its defaults, they are then broken, and will report accordingly.

You should always test on current release and remove any customisations you have made...ahem.

15 hours ago, Nathan Explosion said:

You should always test on current release and remove any customisations you have made...ahem.