The button role is unnecessary for element button

[SeNioR-]

Hi. Another thing that can be improved for peace of mind 🤙 The button role is unnecessary for element button.

Warning:

Template: global/forms/button

[Jim M]

Thank you for bringing this issue to our attention! I can confirm this should be further reviewed and I have logged an internal bug report for our development team to investigate and address as necessary, in a future maintenance release.

 

[SeNioR-]

Please also include:

Template: editorAttachmentsPlaceholder 

Code:

Note: There is a duplicate ul element here, which is unnecessary.

Edit: There is a duplicate </li> element here as well.

{{elseif \IPS\Settings::i()->allow_remote_images }}
						<div>
							<ul class='ipsList_inline ipsClearfix'>
								<li class='ipsPos_right'>
									<a class="ipsButton ipsButton_veryLight ipsButton_verySmall" href='#' data-ipsDialog data-ipsDialog-forceReload data-ipsDialog-title='{lang="editor_insert_from_url"}' data-ipsDialog-url="{url="app=core&module=system&controller=editor&do=link&image=1&postKey={$editor}&editorId={$name}" csrf="1"}">{lang="editor_insert_from_url"}</a></li>
								</li>
							</ul>
						</div>
						{{endif}}

HotFix:

						{{elseif \IPS\Settings::i()->allow_remote_images }}
								<li class='ipsPos_right'>
									<a class="ipsButton ipsButton_veryLight ipsButton_verySmall" href='#' data-ipsDialog data-ipsDialog-forceReload data-ipsDialog-title='{lang="editor_insert_from_url"}' data-ipsDialog-url="{url="app=core&module=system&controller=editor&do=link&image=1&postKey={$editor}&editorId={$name}" csrf="1"}">{lang="editor_insert_from_url"}</a>
								</li>
						{{endif}}

Edited March 21 by SeNioR-

[Jim M]

Thank you for bringing this issue to our attention! I can confirm this should be further reviewed and I have logged an internal bug report for our development team to investigate and address as necessary, in a future maintenance release.