Jump to content

Patch: Avatar Gallery Dropdown and RSS Order


Guest frame

Recommended Posts

Hiya,

I wanted to post this for a long time, today is the day: :)

1. Avatar Gallery Dropdown fix

Make the Dropdown keep it's selection when a new gallery is picked:

--- sources/action_public/usercp.php (v2.1.7)
@@ -2790,9 +2790,9 @@
      
    $av_gals = "<select name='av_cat' class='forminput'>\n";

    foreach( $av_categories as $cat )
    {
-     $av_gals .= "<option value='".$cat[0]."'>".$cat[1]."</option>\n";
+     $av_gals .= "<option value='".$cat[0]."'".($cat[0] == urlencode($av_cat_selected)?' selected':'').">".$cat[1]."</option>\n";
    }
      
    $av_gals .= "</select>\n";

2. Maintain the RSS-Export order as defined in ACP If you define more than just one RSS feed to be exported from your website the order of the Feed is critical to define: Firefox only can 'subscribe' to the first feed, so do most browsers which detect embedded RSS support. The following fix here puts the feeds in the order you define. Note: you need to rebuild the RSS cache at the ACP in order to see your changes.

--- sources/action_admin/rssexport.php (v2.1.7)
@@ -150,7 +150,7 @@
    // Go loopy
    //--------------------------------------------
    
-   $this->ipsclass->DB->build_query( array( 'select' => '*', 'from' => 'rss_export' ) );
+   $this->ipsclass->DB->build_query( array( 'select' => '*', 'from' => 'rss_export', 'order' => 'rss_export_id' ) );
    $outer = $this->ipsclass->DB->exec_query();
    
    while( $row = $this->ipsclass->DB->fetch_row( $outer ) )



I hope both patches make it into the next release, since they are quite simple to integrate and fix two minor annoyances (well, for me they do :).

best,
frame

Link to comment
Share on other sites

I've never had any issues with FF and the IPB rss button @ the bottom of the forums. I have always been able to choose what ever feed I wanted to subscribe to.

Unless you are talking about the tool bar version of rss links or something....

Link to comment
Share on other sites

Hiya,

It's only about the order.. for both, Live-Bookmarks and the RSS-Button at the bottom of the board.

The ACP supports to order them (e.g. Corporate News first), the forum doesn't.

best,
frame

edit: at my first post I do indeed claim that FF only supports one feed, that's not true since.. well 1.5 .. i think??

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...