Jump to content

CodeWizard

Clients
  • Posts

    1
  • Joined

  • Last visited

CodeWizard's Achievements

  1. This is something I just cannot understand. All the bugs aside these two features introduce a whole new workflow of having to deal with requests, approvals and rejections. Who thought it's a good idea to release this without an option to opt-out? Not every community needs this and not everybody is ready. Communities that aren't ready to handle this are basically forced to stay on an older version and miss out on all other improvements. Both of those features should be configurable. I looked into disabling it via code hooks and things get even worse. While hooking \IPS\Member::canUseAccountDeletion does the trick for account deletion (proper backend checks + removes it from UI), same route just doesn't work for PII. \IPS\Member\PrivacyAction::canRequestPiiData/canDownloadPiiData can be hooked but UI elements will stay because of settingsPrivacy template. Buttons will be gone but whole div, header and description will stay. For account deletion whole div is wrapped properly: {{if \IPS\Member::loggedIn()->canUseAccountDeletion() }} ... {{endif}} Why same thing wasn't done for PII? This would do the trick: {{if \IPS\Member\PrivacyAction::canRequestPiiData() }} ... {{endif}} Now it's impossible to remove this without excessive trickery. Theme hooks won't really do the job as there is no way to select that specific div as it doesn't have a unique identifier (it's a generic div.ipsPadding). Documentation states that "you can use any of the selectors supported by jQuery" and that's simply wrong, actually not even a tiny fraction of selectors used by jQuery are supported. Only the most basic CSS selectors can be used and those don't allow to select e.g. parent elements. I didn't expect that a monthly update will turn into such a headache that a simple ACP option could easily fix. tl;dr Please make those features optional.
×
×
  • Create New...