Jump to content

Sly_Ripper

Clients
  • Posts

    187
  • Joined

  • Last visited

Recent Profile Visitors

4,897 profile views

Sly_Ripper's Achievements

  1. Local test update, the forum doesn't display and queue doesn't run due to this error. No 3rd party stuff enabled
  2. Additionally, when viewing a topic, all forums are loaded into memory: SELECT * FROM `forums_forums` LEFT JOIN `core_permission_index` ON core_permission_index.app='forums' AND core_permission_index.perm_type='forum' AND core_permission_index.perm_type_id=forums_forums.id LEFT JOIN `core_members` ON core_members.member_id=forums_forums.last_poster_id WHERE (sub_can_post=0 OR min_posts_view<=22) AND (( FIND_IN_SET(3,perm_view) OR FIND_IN_SET(4,perm_view) OR FIND_IN_SET('m1',perm_view) OR FIND_IN_SET('ca',perm_view) OR FIND_IN_SET('cm',perm_view) OR FIND_IN_SET('c1',perm_view) OR FIND_IN_SET('cm1',perm_view) ) OR perm_view='*' ) ORDER BY position
  3. Even with this enabled, the queries still pull ALL forums into memory ('club_id IS NULL' is needed). Can this be considered a bug now? SELECT * FROM `forums_forums` LEFT JOIN `core_permission_index` ON core_permission_index.app='forums' AND core_permission_index.perm_type='forum' AND core_permission_index.perm_type_id=forums_forums.id LEFT JOIN `core_members` ON core_members.member_id=forums_forums.last_poster_id WHERE (sub_can_post=0 OR min_posts_view<=21) AND (( FIND_IN_SET(3,perm_view) OR FIND_IN_SET(4,perm_view) OR FIND_IN_SET('m1',perm_view) OR FIND_IN_SET('ca',perm_view) OR FIND_IN_SET('cm',perm_view) OR FIND_IN_SET('c1',perm_view) OR FIND_IN_SET('cm1',perm_view) ) OR perm_view='*' ) ORDER BY position All permissions are loaded: SELECT perm_type_id FROM `core_permission_index` STRAIGHT_JOIN `forums_forums` ON forums_forums.min_posts_view<=22 AND core_permission_index.perm_type_id=forums_forums.id WHERE core_permission_index.app='forums' AND core_permission_index.perm_type='forum' AND (( FIND_IN_SET(3,perm_2) OR FIND_IN_SET(4,perm_2) OR FIND_IN_SET('m1',perm_2) OR FIND_IN_SET('ca',perm_2) OR FIND_IN_SET('cm',perm_2) OR FIND_IN_SET('c1',perm_2) OR FIND_IN_SET('cm1',perm_2) ) OR perm_2='*' )
  4. We have one sub-forum for discussion for each game, this is as expected from a forum. None of the releases fix this issue. MySQL 8 does not fix this issue as the issue is the queries used which loads every forum in the DB into memory to be processed by PHP. (Even club forums when you view the forum index.) This forum has the same issue but they’ve used your Pages app to render your forum code with the queries fixed. Which means keeping it updated for every release. All I’m asking for now is that sub-forums in clubs not be loaded on forum index for the main listing (and they’re possibly loaded to process breadcrumbs in topics.) Along with only loading sub-forums of a club that belong to that club. This would allow me to work around the main performance issue without you having to make any invasive changes.
  5. Imagine Steam wanting to convert their forum to Invision and your reply is “sorry, that’s not legitimate use.”
  6. It’s 1 request every 2 seconds for 12 hours. This will easy avoid any rate limits and any mods not checking every club multiple times a day. This isn’t the point. The point is this is a legitimate use case. The way the index loads all forums, even those in clubs is inefficient. The easiest solution is only load forums not part of a club, and on club pages only load the ones in that club. An intern can optimise this.
  7. It can be automated. At least prevent club forums from being loaded into memory on any page not requiring them? I can work around that and tie the sub-forums to clubs.
  8. Clubs allow forums to be added by users and as I posted earlier, they are also loaded on forum index. If clubs were enabled here, I could slowdown the entire forum. See below We don’t allow the listing of the sub-forums due to the performance. https://forum.psnprofiles.com/
  9. @Jim M is there any chance the performance of this is improved in version 5?
  10. Using OAuth while you’re already authenticated with the forum. If 2FA is enabled, after inputting user/pass you’re just redirected to the forum index instead of triggering 2FA/redirecting to the redirect URL set in the oauth app. Disabling 2FA or logging out of the forum first both work fine.
  11. Steps to reproduce Enable/set up 2FA Log into forum Attempt to log into external app with the forum's OAuth (/oauth/authorize/?client_id=client_id_here&response_type=code&scope=scopes&prompt=login) Upon logging in you will be redirected to the forum homepage, not the correct redirect url Disabling 2FA fixes this, as does logging out of the forum first
  12. When "show on member's profile" is set to "Do not show", it will also not show on content submissions when that's set to show. The content submission setting should either apply or be disabled Edit: actually, when content submissions was set to "show to all" it was being treated as "show to staff and profile owner"
  13. Yeah this needs fixing, or at least display a message to clear the cache
  14. Allow IN_DEV with designer's mode, huge pain in the ass
×
×
  • Create New...