[suggestion] Save a click, make the tabs intelligent in profiles

[W13]

Right now, if you see somebody's profile you'll notice a series of tabs, one says, "Blog" another says, "Gallery" - most of the times, the user doesn't have a blog, so after you click on "Blog" tab, you'll see, "No blog found". That's one click wasted :-(

I suggest: If there is no blog, dim the tab (so make it gray or something) and make unclickable. It'll save a click or more :-)

[Morrigan]

Perhaps have no tab?

[W13]

Perhaps have no tab?

I thought about that, but I prefer the dimming of the tab (i.e. change the background color to GRAY, to make it look 'inactive')

[Morrigan]

Well it still leads to needless clicking if something still thinks its an active tab. It would still be a needless click. ;)

[.Matt.]

Why would you click there if there is nothing to click? come on now. smart reply's please. :P

[henke37]

This would be a slight performance hit. Always showing them as active is free. Only showing them as active when they got contents requires one function call per module. And the modules will very likely do database queries to figure it out.
The question here is: Is it worth it?

[Michael]

Clearly IPS decided it wasn't worth it, and I tend to agree. :)

[beeman]

And the modules will very likely do database queries to figure it out.

The question here is: Is it worth it?

it woulnt require a db call, as in the members table (the whole table for the member is already queried for the profile bage) has 2 feilds "has_blog" and "has_gallery" so it woulnt even require even a function call, just 2 if/else statements (which at most would add 0.00000000000000000000000000001 seconds to page generation time).

[Brandon D]

Those fields are cached as well I believe.

[Guest]

But those modules aren't the only ones that provide tabs to the profile. A lot of third party components, that don't modify the members table, also have tabs there.

I don't think it is that worthwhile, though I personally kind of hope that the tab section of the profile disappears altogether, in favour of a more customisable profile in general.

[beeman]

But those modules aren't the only ones that provide tabs to the profile. A lot of third party components, that don't modify the members table, also have tabs there.

I don't think it is that worthwhile, though I personally kind of hope that the tab section of the profile disappears altogether, in favour of a more customisable profile in general.

well greying tabs for 3rd party mods (as always have been) would bee the mod makers job (though it would bee easy enough for the mod maker to add a simmilar feild to the members table "has_mod1" to make their mod work with greying tabs if nessary).

[Morrigan]

Why would you click there if there is nothing to click? come on now. smart reply's please. :P

He says greyed out, not inactive tab so yes, those that still see a link will still click regardless, just to find out why it is greyed out so don't mock my reply.

[Michael]

it woulnt require a db call, as in the members table (the whole table for the member is already queried for the profile bage) has 2 feilds "has_blog" and "has_gallery" so it woulnt even require even a function call, just 2 if/else statements (which at most would add 0.00000000000000000000000000001 seconds to page generation time).

Those fields are cached as well I believe.

has_blog and has_gallery only record if the user has a blog or has a gallery, not if they have any blog entries or gallery images.

[beeman]

has_blog and has_gallery only record if the user [i]has[/i] a blog or [i]has[/i] a gallery, not if they have any blog entries or gallery images.

you make a good point there, however scince theres no point in people having inactive blogs surly ipb should delete blogs/gallerys that have never been used i remember what i used blogs on my site at first EVERYONE went and opened a blog but only like 10% of them actually used them. so there were like 8 pages of inactive blogs.(though thats a suggestion for the blog/gallery side)

[Ziv Grosu]

Your idea is a good one. I hope this will be on IPB 3.0 > the next future board.
I've an additional suggestion, if you're going to profiles tab and then make a refresh, the tab cannot be saved, IPS should change this one at the next board.

[Guest]

I tend to agree with Michael in that the extra queries wouldn't be worth it.

Wouldn't be a bad feature though.

[beeman]

I tend to agree with Michael in that the extra queries wouldn't be worth it.

[b]it woulnt require a db call[/b], as in the members table (the whole table for the member is already queried for the profile bage) has 2 feilds "has_blog" and "has_gallery" so it woulnt even require even a function call, just 2 if/else statements (which at most would add 0.00000000000000000000000000001 seconds to page generation time).

no extra querys needed ;)

[Morrigan]

Well you are asking if their are no entries/images to not show it but if its simply if they do or do not have a gallery or blog then, no it wouldn't require an extra query. If you want to know if it has an entry/image it DOES require an extra query. ;)

[Michael]

no extra querys needed ;)

I pointed out above that has_blog and has_gallery don't tell if there is actually anything to display on those tabs, so yes, you would need an extra query to determine that. If they implement your idea to remove blogs and galleries for people that don't populate them, then yes, you would be right that you wouldn't need any extra queries, but that's not the way it works right now.