steve00 Posted September 27, 2017 Posted September 27, 2017 As per title What is purpose of this line in the html template <h2 class="ipsType_sectionTitle ipsHide ipsType_medium ipsType_reset ipsClear">5 topics in this forum</h2> If do not want it to show then why not remove it completely It just seems so silly, earlier versions it was showing but now you add the class .ipsHide If we alter the template to remove the .ipsHide then we have to revert template and remove the css from template with possibly every upgrade Unless someone can explain a good reason why it is now like that ?
aia Posted September 27, 2017 Posted September 27, 2017 +1, IPS should cleanup templates from unused obsolete code.
Management Charles Posted September 28, 2017 Management Posted September 28, 2017 20 hours ago, steve00 said: Unless someone can explain a good reason why it is now like that ? It remains there so if someone wants to display it they can remove the ipsHide element. It allows for flexibility for theme designers.
aia Posted September 28, 2017 Posted September 28, 2017 6 minutes ago, Mr 13 said: It remains there so if someone wants to display it they can remove the ipsHide element. It allows for flexibility for theme designers. In ths case it should be commented, not hidden via css (for seo reasons). Also why 99.9% of users should care about 0.1% of bad designers which possibly could use that(but in most cases will not) and can't do it on their own?
opentype Posted September 28, 2017 Posted September 28, 2017 10 minutes ago, Mr 13 said: In ths case it should be commented, not hidden via css (for seo reasons). I am curious: What should be the negative SEO effect?
steve00 Posted September 30, 2017 Author Posted September 30, 2017 On 28/09/2017 at 12:49 PM, Charles said: It remains there so if someone wants to display it they can remove the ipsHide element. It allows for flexibility for theme designers. But a bit of css will hide it anyway if not wanted without having to touch the template (otherwise may have to revert template for each upgrade and then re-do the change) It has always been there so why change something that isn't broke. Seems IPS coders spending more time doing these silly small not required changes to templates when there are more important issues that need resolving Just my two cents worth Have made that area viewable with css so no need to touch template but as said it could have been hidden by using css without you adding code to template if someone did not want it to show.
TheJackal84 Posted September 30, 2017 Posted September 30, 2017 1 hour ago, steve00 said: Have made that area viewable with css so no need to touch template but as said it could have been hidden by using css without you adding code to template if someone did not want it to show. but then how can we make it show, If you use { display: none } in the css then you will need to override the display with something, I think it would be easier for a hook to remove the ipsHide class then override a display via css For a themer it may be different but for apps and plugins its defo eaiser
steve00 Posted September 30, 2017 Author Posted September 30, 2017 3 hours ago, TheJackal84 said: but then how can we make it show, If you use { display: none } in the css then you will need to override the display with something, I think it would be easier for a hook to remove the ipsHide class then override a display via css For a themer it may be different but for apps and plugins its defo eaiser Not sure I understand what you mean to make the area I am referring to show then in custom.css (no idea of other areas without seeing the html/css used) .ipsApp.ipsApp_front .ipsType_sectionTitle.ipsHide { display: block; }
Tom S. Posted September 30, 2017 Posted September 30, 2017 3 hours ago, TheJackal84 said: but then how can we make it show, If you use { display: none } in the css then you will need to override the display with something, I think it would be easier for a hook to remove the ipsHide class then override a display via css For a themer it may be different but for apps and plugins its defo eaiser Where do you get this tool from?
steve00 Posted September 30, 2017 Author Posted September 30, 2017 1 hour ago, Tom S. said: Where do you get this tool from? what tool ? If meaning as per the screenshot then need developer tools
steve00 Posted September 30, 2017 Author Posted September 30, 2017 1 minute ago, Tom S. said: Was editing my post when you replied
Rikki Posted September 30, 2017 Posted September 30, 2017 On 9/28/2017 at 9:49 AM, Mr 13 said: In ths case it should be commented It was done via a CSS class so that people wouldn't need to edit the template to show it again if desired.
AlexWebsites Posted September 30, 2017 Posted September 30, 2017 I was wondering about this and saw it was missing in 4.2+. i just added it back with @steve00 custom css there...thanks!
Recommended Posts
Archived
This topic is now archived and is closed to further replies.