Jump to content

Steven W.

Clients
  • Posts

    8
  • Joined

Reputation Activity

  1. Like
    Steven W. got a reaction from Afrodude in [CMS App] Database Record Downloads   
    I've found the database app an interesting tool to build on.  Oddly, there is no ability to download records.  I thought about why this might be and looked at the database.  Is it because the cms_custom_database_n tables use the custom database field id in the column names instead of using the custom database field's field_key value?
    This block in applications/cms/sources/Fields/Fields.php would need to be updated to replace hyphens with underscores:
    if ( \is_array( $values['field_title'] ) ) { /* We need to make sure the internal pointer on the array is on the first element */ reset( $values['field_title'] ); $values['field_key'] = \IPS\Http\Url\Friendly::seoTitle( $values['field_title'][ key( $values['field_title'] ) ] ); } else { $values['field_key'] = \IPS\Http\Url\Friendly::seoTitle( $values['field_title'] ); }  
  2. Like
    Steven W. got a reaction from Afrodude in Speed Optimization: Embedded Iframes   
    I'm not sure if this has ever been implemented for some iframes, because the core -> global -> embed -> iframe template also doesn't have this, and is not related to the YouTube embed:
    <div class='ipsEmbeddedOther' contenteditable="false"> <iframe src="{$url|raw}" data-controller="core.front.core.autosizeiframe" {{if $embedId}}data-embedId='{$embedId}'{{endif}} allowfullscreen=''></iframe> </div> The same is true for Google Maps core -> global -> embed -> googleMaps:
    <div class='ipsEmbeddedOther' contenteditable="false"> <iframe height="450" {{if $mapType == 'place'}} src="https://www.google.com/maps/embed/v1/place?key={setting="google_maps_api_key"}&q={$q}" {{elseif $mapType == 'dir'}} {{if isset( $q['waypoints'] )}} src="https://www.google.com/maps/embed/v1/directions?key={setting="google_maps_api_key"}&origin={$q['origin']}&waypoints={$q['waypoints']}&destination={$q['destination']}" {{else}} src="https://www.google.com/maps/embed/v1/directions?key={setting="google_maps_api_key"}&origin={$q['origin']}&destination={$q['destination']}" {{endif}} {{elseif $mapType == 'search'}} src="https://www.google.com/maps/embed/v1/search?key={setting="google_maps_api_key"}&q={$q}" {{elseif $mapType =='coordinates'}} src="https://www.google.com/maps/embed/v1/view?key={setting="google_maps_api_key"}&center={$q}&zoom={$zoom}" {{endif}}> </iframe> </div> As well as Brightcove videos core -> global -> embed -> brightcove:
    <div class="ipsEmbeddedBrightcove"> <div class="ipsEmbeddedBrightcove_inner"> <iframe src="{$url|raw}" allowfullscreen webkitallowfullscreen mozallowfullscreen class="ipsEmbeddedBrightcove_frame"> </iframe> </div> </div> The plugin I made lazy loads all of these iframes.
  3. Like
    Steven W. reacted to Stuart Silvester in Speed Optimization: Embedded Iframes   
    Ah, I see. That looks like a bug that was introduced when we switched the domain to use youtube-nocookie.com. We'll get that fixed.
  4. Like
    Steven W. reacted to PanSevence in Speed Optimization: Embedded Iframes   
    I also noticed this type of issue when I add videos in topics, they are immediately downloaded instead of only after being opened, which causes the topics to take a very long time to load, we need a fix.
  5. Like
    Steven W. reacted to Rick Vasquez in Speed Optimization: Embedded Iframes   
    I was having this issue on some threads on my board, specifically where we talk about music and lots of youtube videos are linked. This plugin helped solve the problem immediately after installing. It seems like all the youtube videos attempting to load at the same time is crashing some memory limit in safari/webkit on iOS
  6. Like
    Steven W. got a reaction from AlexWebsites in Speed Optimization: Embedded Iframes   
    The OP is supposed to say "Embedded iframes (like YouTube videos)" -- but it is no longer editable.
  7. Like
    Steven W. got a reaction from AlexWebsites in Speed Optimization: Embedded Iframes   
    Recently, while administering a large board running IPS 4.x, I saw that there are a lot of performance optimizations already in place which is great.  I also saw a few instances of front and back-end performance issues, and in some cases, outright crashing; one of these boils down to 2 things:
    Embedded iframes (like tweets) do not use the deferred loading=lazy attribute, so on topics with many embeds, pages slow to a crawl or outright crash (esp. Apple devices) Embedded iframes seem to point to an iframe loader as a sort of internal proxy, which increases load on the server, particularly for large sites, probably predating loading=lazy I have implemented this optimization here: https://vbresults.com/downloads/speed-optimizations-ip-community-4 — and the IPS team can merge it into the core if they see fit.  I'd like to expand on this by dis-intermediating the iframe where possible, but understand there are other reasons for it like the layout.
×
×
  • Create New...