tgs-shaun Posted January 27, 2022 Posted January 27, 2022 Hi @Runar Moving over to here. It works fine, I see the "Mark Topic" button, I just thought it would be useful to "premark" topics when they are created, as that is the usual flow of things. For example if a user lists something for sale, they would wish to mark it as for sale at the time of thread creation. Runar 1
Runar Posted January 27, 2022 Author Posted January 27, 2022 1 minute ago, tgs-shaun said: It works fine, I see the "Mark Topic" button, I just thought it would be useful to "premark" topics when they are created, as that is the usual flow of things. For example if a user lists something for sale, they would wish to mark it as for sale at the time of thread creation. I know what you mean, and I've actually been thinking about adding a similar feature as I need something like this for my own community. I just need to figure out the best way to, as in your example with listing something for sale, unmark the topic as for sale and "remark" it as sold. Any suggestions?
tgs-shaun Posted January 27, 2022 Posted January 27, 2022 8 minutes ago, Runar said: I know what you mean, and I've actually been thinking about adding a similar feature as I need something like this for my own community. I just need to figure out the best way to, as in your example with listing something for sale, unmark the topic as for sale and "remark" it as sold. Any suggestions? Ah, I hadn't realised that once the item was sold you had to unmark then remark, that's fine I guess I just need to explain that in a pinned topic. The main point I was making was to mark it at creation time, just saves a confusing additional step I think.
Runar Posted January 27, 2022 Author Posted January 27, 2022 I have a few ideas for this feature, and I'll look closer into them this weekend!
Edjazoli Posted February 4, 2022 Posted February 4, 2022 (edited) n Edited February 4, 2022 by Edjazoli
Edjazoli Posted February 4, 2022 Posted February 4, 2022 (edited) Any chance you could add a key to this translation "unmark as %s" as you have with "marks as %s" As well I've got two "unmark" for rest of the members after choosing " Allow anyone to unmark the topic?↩️ Edited February 5, 2022 by Edjazoli Runar 1
Runar Posted February 5, 2022 Author Posted February 5, 2022 1 hour ago, Edjazoli said: Any chance you could add a key to this translation "unmark as %s" as you have with "marks as %s" Good idea, I’ll add it to the list of future features. It shouldn’t take too long! 1 hour ago, Edjazoli said: As well I've got two "unmark" for rest of the members after choosing " Allow anyone to unmark the topic?↩️ That doesn’t look right. Would you please translate the text to the left of the buttons, and tell me how the text ended up there? Are you using any plugins that do something with that part of the page?
Edjazoli Posted February 5, 2022 Posted February 5, 2022 (edited) 6 hours ago, Runar said: That doesn’t look right. Would you please translate the text to the left of the buttons, and tell me how the text ended up there? Are you using any plugins that do something with that part of the page? Hi please feel free to check forum yourself using login details below. As I said its happening only with another groups... This is the test topic that will you possibly of checking yourself. https://xbox-vibes.com/topic/2304-test-test/ Username: send pm Password: send pm Another plugin that is hooked here is a translation by @Nathan Explosion. Edited February 5, 2022 by Edjazoli Runar 1
Nathan Explosion Posted February 5, 2022 Posted February 5, 2022 (edited) 9 hours ago, Runar said: Are you using any plugins that do something with that part of the page? What is the selector you are using on your theme hook? Also, is your resource an application or is it a plugin? Edited February 5, 2022 by Nathan Explosion Edjazoli 1
Runar Posted February 5, 2022 Author Posted February 5, 2022 55 minutes ago, Nathan Explosion said: What is the selector you are using on your theme hook? I use the following selector (and the add_inside_start type) to target the <ul> element containing the topic action buttons: elClubContainer > div.ipsClearfix > ul.ipsToolList.ipsToolList_horizontal.ipsClearfix.ipsSpacer_both The issue in this case is that when a topic is closed, there are suddenly two <ul> lists. I don’t know if this is caused by your application or not, but it’s not normal behavior. Again, this only happens in closed topics. 55 minutes ago, Nathan Explosion said: Also, is your resource an application or is it a plugin? It's been an application since version 2.0.0. Edjazoli 1
Nathan Explosion Posted February 5, 2022 Posted February 5, 2022 (edited) I'll do some testing my side to see - I added something in the last version that may be influencing this. Edited February 5, 2022 by Nathan Explosion Edjazoli and Runar 1 1
Edjazoli Posted February 8, 2022 Posted February 8, 2022 (edited) Looks like after @Nathan Explosion latest update the button is disappearing after" marking as a sold"(mobiles only) so its not possible to unmark topic(mobiles only) Another question, its any chance that button "sold" "solved" will be visible as well in the "topic feeds" block? Its nice to have this as members can see badge in the main page as well... Edited February 8, 2022 by Edjazoli
Edjazoli Posted February 8, 2022 Posted February 8, 2022 As well, I cant find anywhere option to give my moderators an option to mark/unmark? Sorry for all the questions....
Runar Posted February 8, 2022 Author Posted February 8, 2022 1 hour ago, Edjazoli said: Looks like after @Nathan Explosion latest update the button is disappearing after" marking as a sold"(mobiles only) so its not possible to unmark topic(mobiles only) Indeed, it even hides the “Start new topic” button on mobile devices. Hopefully he’ll release another fix soon! 1 hour ago, Edjazoli said: Another question, its any chance that button "sold" "solved" will be visible as well in the "topic feeds" block? Good idea, I’ll add it to the list of future features. 1 hour ago, Edjazoli said: As well, I cant find anywhere option to give my moderators an option to mark/unmark? Sorry for all the questions.... This is a known issue and I’m working on a fix that’ll hopefully be released this week. And don’t apologize for asking questions or requesting new features! Keep them coming! 😊
Nathan Explosion Posted February 8, 2022 Posted February 8, 2022 9 minutes ago, Runar said: Indeed, it even hides the “Start new topic” button on mobile devices. Hopefully he’ll release another fix soon! This is the problem with theme hooks - one thing affects another. No idea why my modification to my own added HTML would result in what you guys are describing but there we go. I'll just avoid using hooks into an area that other people are already hooking into, sort the issue out.
Runar Posted February 8, 2022 Author Posted February 8, 2022 34 minutes ago, Nathan Explosion said: This is the problem with theme hooks - one thing affects another. No idea why my modification to my own added HTML would result in what you guys are describing but there we go. What selector are you using to add the translate button?
Nathan Explosion Posted February 8, 2022 Posted February 8, 2022 52 minutes ago, Runar said: What selector are you using to add the translate button? Same as you - don't worry, leave it with me...I'll just not use it.
Runar Posted February 8, 2022 Author Posted February 8, 2022 6 minutes ago, Nathan Explosion said: Same as you - don't worry, leave it with me...I'll just not use it. Thank you for making changes (even small) to your application to fix this issue, and for doing so quickly. I asked mainly because it’s weird that using this hook duplicates the <ul> element, so it could be worth reporting as a bug.
Nathan Explosion Posted February 8, 2022 Posted February 8, 2022 Just now, Runar said: Thank you for making changes (even small) to your application to fix this issue, and for doing so quickly. I asked mainly because it’s weird that using this hook duplicates the <ul> element, so it could be worth reporting as a bug. No need - I'm adding the extra UL, it's working as I intend it to work. The issue is that there are other things in that area (your application) that are affected by that. As I said...don't worry, leave it with me...I'll just not use it. Runar 1
Dave D Posted February 11, 2022 Posted February 11, 2022 (edited) Do you know of any reason why the Mark/Unmark button and the Marker would be hidden with a theme? I can see these in the default Invision Theme, but not when I try with a Custom Theme we have. Thanks! Edited February 11, 2022 by Dave D
Runar Posted February 12, 2022 Author Posted February 12, 2022 22 hours ago, Dave D said: I can see these in the default Invision Theme, but not when I try with a Custom Theme we have. Could you try clearing the cache in your AdminCP, and see if the buttons appear after?
Dave D Posted February 14, 2022 Posted February 14, 2022 Still cannot see them. I also tried a private window to make sure that the cache was completely new Here's some examples -Note Marketplace - PMG Note Collectors Chat Boards (pmgnotes.com) posts titled "test of sold/unsold" and "2nd test of sold/unsold" at the end of January. Marker shows up, but buttons do not for the author (until I change the theme back to default)
Runar Posted February 14, 2022 Author Posted February 14, 2022 48 minutes ago, Dave D said: Here's some examples -Note Marketplace - PMG Note Collectors Chat Boards (pmgnotes.com) Thank you for the examples. Would you be able to provide a test user for me? A normal user with permissions to post topics in the Note Marketplace forum.
balazsp Posted February 17, 2022 Posted February 17, 2022 @Runar thank you for your app, it works as exactly as advertised.. love it! 🙂 Runar 1
Recommended Posts