Hard code in Install/Upgrade System

[Ilya Hoilik]

Hello! I'm not sure that this is correct area for this request. Sorry about that.

I asked to move all language strings into special lang.php file here. But this bug was closed. I agree that it's not a bug, so I post it here.

Can you move these language strings to lang.php? File : strings with hard coded phrases:

Spoiler

admin/install/html/global/confWriteError.phtml : 3, 7, 8, 12
admin/install/html/global/globalTemplate.phtml : 28, 40, 61, 63, 66, 67, 69, 73, 76, 78, 83, 86
admin/install/html/global/healthcheck.phtml : 5, 14, 16, 26, 28
admin/install/html/global/manualStart.phtml : 3, 5
admin/upgrade/html/forms/apps.phtml : 11, 9
admin/upgrade/html/forms/noapps.phtml : 2, 4
admin/upgrade/html/global/confirm.phtml : 3
admin/upgrade/html/global/convertUtf8.phtml : 3, 7
admin/upgrade/html/global/error.phtml : 12, 15
admin/upgrade/html/global/globalTemplate.phtml : 28, 56, 67, 68, 70, 74, 79, 84, 87
admin/upgrade/html/global/healthcheck.phtml : 5, 9, 12, 13, 18, 27, 29, 40, 42
admin/upgrade/html/global/license.phtml : 3
admin/upgrade/html/global/unfinishedUpgrade.phtml : 5, 18, 19, 25, 26
admin/upgrade/html/global/upgradeError.phtml : 24, 27

Thanks in advance, guys!

 

[Mark]

I'll move this over to feedback

[Ilya Hoilik]

On 21.12.2015 at 11:50 AM, Mark said:

I'll move this over to feedback

No problem

I also have an idea how you can make Install and Upgrade systems fully translatable and without need to change original files.

Just check if /admin/install/lang-custom.php and /admin/upgrade/lang-custom.php files are exists (in functions setupLanguage() and upgraderLanguage() in system/Lang/Lang.php). If so, just use these files instead of original lang.php. This method will resolve problem with delta-upgrade, when upgrade is not possible because of changed lang.php files.

Hmm. Maybe my resolution can cause security issue. Ok, just convert lang.php into lang.xml (and lang-custom.php into lang-custom.xml) and all problems will be resolved.