Jump to content

Matt Finger

Invision Community Team
  • Joined

  • Last visited

Everything posted by Matt Finger

  1. Well 2 and 3 can be merged, but the separate steps are intentional. The existing badges from before 5.0.5 are the same as badges created with the size of 1, so when adding the column that is the default used. For 5.0.5 and up, the default size throughout the backend code and UI is 3 because it's a more universal size, however it can overflow in some shapes. So we change the default after adding the column so that database records for existing badges match the badge's SVG file and the badge content isn't altered.
  2. Can you please share the browser version and machine you are using? Yes, that's is correct. The issue ultimately lies in Chrome itself, but we are addressing it to the best of our ability, applying a fix whenever we identify a source of slowness. That said, it's one of those things that doesn't affect any of the devices used by members of our staff which makes it hard to track down.
  3. Matt Finger posted a post in a topic in Feedback
    Yes, as of 5.0.4 Native Emoji, Custom Emoji, and Font Awesome Icons can all be individually toggled. The setting is in AdminCP > System > Posting & Editor > Permissions Setting "Show Native Emoji in the Editor Icon Menu" will prevent them from being displayed.
  4. Hmm, maybe but that's a bit more complicated than it sounds since it also recognizes emails and phone numbers. I'd also argue it ends up being convenient more often than not across the board. Google.com GitHub.com, invisioncommunity.com, tiptap.dev are some examples. I think the real issue which we'll try to sort out is making it easier to undo the auto link without opening the link panel. For example , an automatic link message with a "revert to plaintext" option (like when automatically embedding content), and reverting when the user presses Escape. Yeah I agree.
  5. This is not a bug, but rather the expected behavior since ".py" is the country code top level domain for Paraguay.
  6. I can reproduce using cmd + shift + v (paste as plain text/paste and match style) Regular Paste If you want to copy and paste a text including emojis (✌🏻) from a editor or something else in the IPS Editor, everything after the first emoji will not be inserted and is cutting off. Plain Text If you want to copy and paste a text including emojis (✌🏻
  7. Matt Finger posted a post in a topic in Feedback
    Thanks for referencing your site, you have a space in the name "Libar Emoji ". Adding that space to the CSS does the trick, or it would probably be better to just rename on the backend to remove the space
  8. Matt Finger posted a post in a topic in Feedback
    Ah, I didn't see you have it called "Classic", but still if you just put "Classic" in the CSS it will bring them both up top. Here's an example where I created a custom set called "Libar Emoji" Now, if you need to sort them further, increasing the order one more like you did in the OP is the right idea, but you had conflicting orders set on the base category selector; this works for me .ipsIconPicker [data-role="icons"] { display:flex; flex-direction:column; } .ipsIconPicker__container [data-icon-category] { order: 2; flex: 0 0 auto; } /* List out any category titles you want up top here */ .ipsIconPicker__container :is([data-icon-category="Classic"]) { order: 0; } .ipsIconPicker__container :is([data-icon-category="Libar Emoji"]) { order: 1; }
  9. Matt Finger posted a post in a topic in Feedback
    This portion puts all categories at the same level as Libar emojis Should just be .ipsIconPicker [data-role="icons"] { display:flex; flex-direction:column; } .ipsIconPicker__container [data-icon-category] { order: 1; flex: 0 0 auto; } /* List out any category titles you want up top here */ .ipsIconPicker__container :is([data-icon-category="Emoticons"], [data-icon-category="Libar Emoji"]) { order: 0; }
  10. That would be because facebook.com is not whitelisted in the AdminCP "Allowed Domain Patterns" setting. While you're testing and getting used to it, you can just add a domain pattern that is just * to allow any secure URL to become an iframe, however we'd generally recommend people don't for security
  11. Well, in the case of W3 Schools, it looks like it cannot be embedded due to the frame ancestors policy they set. Have you tried using a domain and URL that you have embedded as an iframe elsewhere?
  12. Matt Finger posted a post in a topic in Feedback
    I can state we have a local branch where you will be able to toggle any of custom emojis, native emojis and Font Awesome Icons to come in a future release. For the time being, you can do this to show your custom emojis up top, just replace Emoticons in the last rule set with the name of your custom category. .ipsIconPicker [data-role="icons"] { display:flex; flex-direction:column; } .ipsIconPicker__container [data-icon-category] { order: 1; flex: 0 0 auto; } /* List out any category titles you want up top here */ .ipsIconPicker__container :is([data-icon-category="Emoticons"]) { order: 0; }It also should work with multiple custom categories by adding them inside the :is() clause, separated by commas .ipsIconPicker__container :is([data-icon-category="Emoticons"], [data-icon-category="Other Custom Icon Category"]) Applying to this site with dev tools, it looks like this
  13. Hmm, ok. I can reproduce the issue in your recording there, but it works if there's an actual link... e.g. if you add text to the text field Screen Recording 2025-02-21 at 11.29.19 AM.mp4
  14. Ah, sorry, you need https:// in the link panel, I meant you don't need it in the AdminCP Domain Whitelist
  15. That looks correct except you don't need the https:// as that's the protocol and only secure URLs for custom iframes are supported. www.w3schools.com should work fine
  16. Can confirm it's a bug affecting all third-party editor buttons, we'll be sure to have a fix by the next release
  17. Yeah, we're still working on more comprehensive documentation but I did post a basic guide in the Beta Testing Group Just to preface, I did spot a bug where custom buttons aren't actually added, so the following answer applies to the next release/patch For your questions specifically, Yes, it's possible but it's not something we're considering out of the box. It should actually do this when you press Backspace on an empty node already, but certainly something a custom button can handle. The hard part which you'd need to play around with is the selection handling to ensure it works smoothly, but the JS would be something roughly like ips.ui.editorv5.registerExtension('deleteButton', { addCommands() { return { deleteNodeInSelection: () => ({editor, chain}) => { const {$from} = editor.state.selection; const path = [...$from.path]; try { // if we're at the start of the document, or the current node is a paragraph, don't delete if (path.length <= 3 || path[3] < 2 || path[3].type.name === 'paragraph') { return false; } return chain().setNodeSelection(path[2]).deleteSelection(); } catch (e) {} return false; } } }, addButtons() { return { deleteNode: { html: '<span><i class="fa-solid fa-trash-can"></i></span>', command: ({chain}) => chain().deleteNodeInSelection().focus().run(), // This puts the button at the end of the toolbar locations: [null], isAvailable: editor => editor.can().deleteNodeInSelection(), isActive: editor => false } } } }) // OPTIONAL - create an AdminCP Restriction Option ips.setString({"ipsCustomExtension__deleteButton__": "Show Delete Button"}); // Make the title display properly ips.setString({"ipsCustomExtension__deleteButton_deleteNode": "Delete Current Node"});Here's a recording of it in action Screen Recording 2025-02-15 at 2.18.53 AM.mp4 Customizing the Icon Panel's inner HTML is not something we're considering, so the options are create a custom Editor Extension and build out your own panel, or just use CSS to hide. We are working on a local branch with performance improvements to that panel which will also allow for easy hiding using a CSS one-liner: .ipsEditor__toolbar .ipsIconPicker [data-icon-category]:not([data-icon-category="Custom Set 1"],[data-icon-category="Custom Set 2 (or whatever name you chose)"]/*, ...allTheOtherCategories*/) { display: none; } Once again, these are not something we're going to add in the standard release but there are built-in commands for tiptap which can be implemented in a custom extension. Good thing #1 is technically possible, since this is a definite "no" 😂. Not to be dismissive, but BBCode is incompatible with the current tiptap schema. Therefore, when converting between BBCode and tiptap nodes there will be content loss, not to mention an entire conversion library would need to be created to do this. Like Marc said, you really just need to paste the link and it will convert automatically. We may implement the manual "insert image from URL" dialog from v4 if there's enough demand for it, but it is also possible to do with extensions.
  18. Yeah, not really a major concern but fix queued for next release.
  19. The reason we require the sandbox attribute is for security purposes. Even though there are restrictions on who can use custom iframes, there are still other considerations we need to make. Cheifly, Not all admins may understand the full ramifications of allowing unsandboxed iframes. If the wrong member has access to it, it could lead to serious XSS leaks and a compromised site Different services require different permissions in the allow and sandbox attributes, so we'd really want support more granular options than include/exclude the attribute Even if the editor disallows it, we still need to be very careful that malicious actors cannot submit an embed that could compromise security using a manual HTTP Post. Since 5 has been officially released we are currently focused on making it stable and ironing out bugs and issues, however in a future 5.x point release we will likely add more configuration options for embeds. Given the complex nature of embed security policies it's a feature that will require significant time and consideration to implement.
  20. The content inside each table cell can be centered, however it isn't currently possible to center the table itself. This ensures certain UI elements, such as the column resizer, don't break.
  21. Additionally, any details on the browser you're using would be helpful so that we can attempt to reproduce.
  22. Lol we actually noticed this just yesterday internally and have a fix ready in the next release.
  23. It only takes effect when edited
  24. Yes that is correct, the HTML attributes supported by the editor are strictly defined, but creating an editor extension to apply Formatting Marks or wrap content inside a Containing Node should allow you to support the class names you’ve been using