[Bug] IndexNow submits an ACP URL when queue runs from ACP

[Martin A.]

When manually running the queue from the ACP, the keyLocation submitted to IndexNow uses the ACP base url.

Got errors like these:

422 invalid_url Array
(
    [host] => www.site.com/
    [key] => 6c076eb62f3b43e8cf6c62a8d69dff7a
    [keyLocation] => https://www.site.com/admin/<hash>.txt
    [urlList] => Array
        (
            [0] => https://www.site.com/<url>
        )

)

 

Issue is here:

$url = \IPS\Http\Url::internal('');
$data = array(
			'host'         => \IPS\Http\Url::baseUrl(\IPS\Http\Url::PROTOCOL_WITHOUT ),
			'key'          => \IPS\Settings::i()->indexnow_key,
			'keyLocation'  => (string) $url->setPath( $url->data[ \IPS\Http\Url::COMPONENT_PATH ] .  $this->getKeyFileName() ),
			'urlList'     => $urls,
);

$url should specify the 'front' base

$url = \IPS\Http\Url::internal( '', 'front' );

 

Error happened in 4.6, but this file is not touched in 4.7.

Edited July 2, 2022 by Martin A.

[Daniel F]

Thanks, we have fixed this recently.

[AlexWebsites]

53 minutes ago, Daniel F said:

Thanks, we have fixed this recently.

For 4.7 Beta? Does this issue exist on 4.6 currently?

[Stuart Silvester]

2 minutes ago, AlexWebsites said:

For 4.7 Beta? Does this issue exist on 4.6 currently?

It will be included in 4.7.1 at the earliest. The issue exists in 4.6.12 and 4.7 betas.

[AlexWebsites]

3 minutes ago, Stuart Silvester said:

It will be included in 4.7.1 at the earliest. The issue exists in 4.6.12 and 4.7 betas.

Thanks, I guess I can manually patch my sites in the interim. Thanks @Martin A.

[BertT]

 The issue exists in  Invision Community v4.7.0

 

422 invalid_url Array
(
    [host] => xxxxxxx.com/
    [key] => 7697d70b06e915dae27366f9da877a3d
    [keyLocation] => xxxxxxx.com/admin/7697d70b06e915dae27366f9da877a3d.txt
    [urlList] => Array
        (
            [0] => https://xxxxxxx.com/messenger/12051/
        )

)
 

Edited July 6, 2022 by BertT

[Daniel F]

 

1 minute ago, BertT said:

 The issue exists in  Invision Community v4.7.0
 

Stu confirmed that it will in 4.7.1 or later 

On 7/2/2022 at 1:11 PM, Stuart Silvester said:

It will be included in 4.7.1 at the earliest.