Jump to content

[5.0.2] Html ID value removed from Radio images template call

teraßyte

By teraßyte

  • Status: Moved to Github

The gridspan value was removed in 5.0.2 from the Radio helper form, but the PHP code also had the HTML ID (mistakenly?) removed.

5.0.1:

<ips:template parameters="$name, $value, $required, $options, $disabled=FALSE, $toggles=array(), $descriptions=array(), $warnings=array(), $userSuppliedInput='', $unlimited=NULL, $unlimitedLang=NULL, $htmlId=NULL, $gridspan=3" />

return Theme::i()->getTemplate( 'forms', 'core', 'global' )->radioImages( $this->name, $value, $this->required, $this->options['options'], $this->options['disabled'], $this->options['toggles'], $descriptions, $warnings, $this->options['userSuppliedInput'], $this->options['unlimited'], $this->options['unlimitedLang'], $this->htmlId, $this->options['gridspan'] );

5.0.2:

<ips:template parameters="$name, $value, $required, $options, $disabled=FALSE, $toggles=array(), $descriptions=array(), $warnings=array(), $userSuppliedInput='', $unlimited=NULL, $unlimitedLang=NULL, $htmlId=NULL" />

return Theme::i()->getTemplate( 'forms', 'core', 'global' )->radioImages( $this->name, $value, $this->required, $this->options['options'], $this->options['disabled'], $this->options['toggles'], $descriptions, $warnings, $this->options['userSuppliedInput'], $this->options['unlimited'], $this->options['unlimitedLang'] );

The $htmlId template parameter is always NULL because $this->htmlId was also removed from the PHP backend.

    •

    User Feedback

    Recommended Comments

    teraßyte Grand Master

    teraßyte

    Clients

    P.S.: You should also remove the gridspan value from the phpDoc comment in Select.php since it's no longer available:

    'gridspan'			=> 3,		// If 'parse' is set to 'image', this controls the gridspan to use when creating the option layout