Invision Community 4: SEO, prepare for v5 and dormant account notifications By Matt Monday at 02:04 PM
CodingJungle Posted November 15, 2015 Posted November 15, 2015 on the activerecord, static method load(), for the $idField parameter, can we have it a bit more consistent? if i define a $idField it has be the full columns name, so if prefix of say "mine_", i have to pass it "mine_key", same with the static::$databaseIdFields, i would have to have "mine_key" there as well...when the rest of the class i would just call $this->key.
Management Matt Posted November 16, 2015 Management Posted November 16, 2015 Yeah, although it would mean a lot of changes and potential bugs at this stage.
CodingJungle Posted November 16, 2015 Author Posted November 16, 2015 It doesn't have to be "right" away imho. something done for 4.2? where developers would expect game changing breakage like that :). I just found it odd, that there are a few places thru out the ActiveRecord things like this exist, and it trickles up into the content/item and node classes as well, so it seems way more numerous than it actually it is cause of the scope of how closely tied those two main components are to ActiveRecord. but thinks for looking (and understanding my very poorly constructed post, it was late after a long day :))
Recommended Posts
Archived
This topic is now archived and is closed to further replies.