Fierce God Posted June 18, 2017 Posted June 18, 2017 Don't know if you know this... But if you have custom theme, and have a Cover photo, after putting in the update, it moves the Cover photo down and takes away the option to position it again other that, works great @TheJackal84
TheJackal84 Posted June 18, 2017 Author Posted June 18, 2017 1 minute ago, FGN said: Don't know if you know this... But if you have custom theme, and have a Cover photo, after putting in the update, it moves the Cover photo down and takes away the option to position it again other that, works great @TheJackal84 Moves it down what do you mean? what version are you using? And create me a account on your site so I can see, Some themes use different elements or custom ones and it could be a simple custom.css edit for your theme
Fierce God Posted June 18, 2017 Posted June 18, 2017 your newest version you just updated a few minutes ago and ok will do I mean that it repositions the Cover photo, as in mine, it moved the photo down Edit Nvm i just ran the support tool and it fixed it Sry for that @TheJackal84 TheJackal84 1
TheJackal84 Posted June 18, 2017 Author Posted June 18, 2017 On 17/06/2017 at 1:18 PM, GregoryRasputin said: Is it working with Enhanced User Info yet? What version or IPS are you using?
GregoryRasputin Posted June 19, 2017 Posted June 19, 2017 20 hours ago, TheJackal84 said: What version or IPS are you using? v4.2.0 Beta 5a
TheJackal84 Posted June 19, 2017 Author Posted June 19, 2017 2 minutes ago, GregoryRasputin said: v4.2.0 Beta 5a That's better for me, I will release the update today
Fierce God Posted June 23, 2017 Posted June 23, 2017 @TheJackal84 The mobile view for the banner tab is being blocked by the profile pic, and members think its not on mobile view but it is, just being covered
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 9 hours ago, FGN said: @TheJackal84 The mobile view for the banner tab is being blocked by the profile pic, and members think its not on mobile view but it is, just being covered For the banner tab? can you screenshot a example? Fierce God 1
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 (edited) 13 minutes ago, FGN said: I think I get what you mean, The button what adds allows you to add it? Add this to your custom.css for now and I will sort it in a update, The avatar is sitting on top of the buttons so the code below will tell the buttons to site on top of the avatar #elEditProfile { z-index: 9999; } Edited June 24, 2017 by TheJackal84 Fierce God 1
Fierce God Posted June 24, 2017 Posted June 24, 2017 6 hours ago, TheJackal84 said: I think I get what you mean, The button what adds allows you to add it? Add this to your custom.css for now and I will sort it in a update, The avatar is sitting on top of the buttons so the code below will tell the buttons to site on top of the avatar #elEditProfile { z-index: 9999; } Worked like a charm! Thx @TheJackal84
Fierce God Posted June 24, 2017 Posted June 24, 2017 @TheJackal84 you may want to think about putting it back in the edit profile....... members are not recognizing it as a need to add the icons but you need to make sure it doesn't take over other tabs....... classifieds has a tab called "member store"...... and i noticed the first time before you changed the tab, that it took over the classifieds tab in edit profile
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 3 hours ago, FGN said: @TheJackal84 you may want to think about putting it back in the edit profile....... members are not recognizing it as a need to add the icons but you need to make sure it doesn't take over other tabs....... classifieds has a tab called "member store"...... and i noticed the first time before you changed the tab, that it took over the classifieds tab in edit profile I will put a choice of where to show it. You could always change the language of the button to add/edit social info. And with classifieds if they are hooking into the same code as mine then it will conflict and only show one of them as you can't hook a hook Fierce God 1
Fierce God Posted June 24, 2017 Posted June 24, 2017 i agree with the option part also, i dont know who made the hook first.......i just know i had classifieds 4.2 before social info.....you both have tabs for the edit profile but if you add the option part in the admincp.....that will work,
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 (edited) 1 hour ago, FGN said: i agree with the option part also, i dont know who made the hook first.......i just know i had classifieds 4.2 before social info.....you both have tabs for the edit profile but if you add the option part in the admincp.....that will work, Its not who made first if both are trying to override something only 1 will work, if it was both plugins then the plugin sitting at the top of the list will be the one what it will use, but a plugin and a app then it's pot luck, the button works with both installed because the button is my own code where the edit profile is my code injected into IPS' code Edited June 24, 2017 by TheJackal84
Adriano Faria Posted June 24, 2017 Posted June 24, 2017 10 minutes ago, TheJackal84 said: Its not who made first if both are trying to override something only 1 will work, if it was both plugins then the plugin sitting at the top of the list will be the one what it will use, but a plugin and a app then it's pot luck, the button works with both installed because the button is my own code where the edit profile is my code injected into IPS' code No. If you extend the class correctly, you can have hundreds of hooks in same class. Your plugin probably isn't returning the parent class, which will kill any ither plugin in same class.
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 (edited) 7 minutes ago, Adriano Faria said: No. If you extend the class correctly, you can have hundreds of hooks in same class. Your plugin probably isn't returning the parent class, which will kill any ither plugin in same class. its to go in the edit profile settings on the profiles \IPS\core\modules\front\members\profile hooking into protected function edit() I made my own and placed it in it's own button but he wants it back in the edit profile settings, I ain't found a way to do it keeping IPS settings there as well without replacing the whole code, while adding my own Edited June 24, 2017 by TheJackal84
Fierce God Posted June 24, 2017 Posted June 24, 2017 Sry, didn't mean to cause confusion, what ever works best for you as the dev, I was just suggesting as to a lot of my members have to go back to add the new icons......but if it works best in the banner, then keep it
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 Just now, FGN said: Sry, didn't mean to cause confusion, what ever works best for you as the dev, I was just suggesting as to a lot of my members have to go back to add the new icons......but if it works best in the banner, then keep it That's cool, I will add the option of where to show it, What do you mean go back to add new icons?
Adriano Faria Posted June 24, 2017 Posted June 24, 2017 15 minutes ago, TheJackal84 said: its to go in the edit profile settings on the profiles \IPS\core\modules\front\members\profile hooking into protected function edit() I made my own and placed it in it's own button but he wants it back in the edit profile settings, I ain't found a way to do it keeping IPS settings there as well without replacing the whole code, while adding my own Sorry if I misunderstood. Thought you were talking about add a new tab with a form in Edit Profile. If so, that's what I do in Classifieds: Hook in \IPS\core\modules\front\members\profile::buildEditForm(): /** * Build Edit Form * * @return \IPS\Helpers\Form */ protected function buildEditForm() { $form = call_user_func_array( 'parent::buildEditForm', func_get_args() ); $form->addTab( 'your_tab_title' ); $form->add( new \IPS\Helpers\Form\YesNo... return $form; } /** * Save Member * * @param $form * @param array $values */ protected function _saveMember( $form, array $values ) { $member = parent::_saveMember( $form, $values ); $this->member->YOUR_COLUMN = $values['YOUR_FIELD']; $this->member->save(); return $member; }
TheJackal84 Posted June 24, 2017 Author Posted June 24, 2017 (edited) 2 minutes ago, Adriano Faria said: Sorry if I misunderstood. Thought you were talking about add a new tab with a form in Edit Profile. If so, that's what I do in Classifieds: Hook in \IPS\core\modules\front\members\profile::buildEditForm(): /** * Build Edit Form * * @return \IPS\Helpers\Form */ protected function buildEditForm() { $form = call_user_func_array( 'parent::buildEditForm', func_get_args() ); $form->addTab( 'your_tab_title' ); $form->add( new \IPS\Helpers\Form\YesNo... return $form; } /** * Save Member * * @param $form * @param array $values */ protected function _saveMember( $form, array $values ) { $member = parent::_saveMember( $form, $values ); $this->member->YOUR_COLUMN = $values['YOUR_FIELD']; $this->member->save(); return $member; } No worries, that was the first thing I done and it replaced it with only the stuff I added (removing all IPS settings) I had to add IPS plus mine to get it to show, Plus I had to edit the save value bits too Edited June 24, 2017 by TheJackal84
Adriano Faria Posted June 24, 2017 Posted June 24, 2017 Works fine for me: You said you hooked in edit(). I'm hooking in buildEditForm to add new fields in the form. TheJackal84 1
Recommended Posts