Adding columns to existing tables for application

[GriefCode]

Hey,

i ran into a small issue.
I've added extensions for GroupForm & MemberForm to add new permission sets.

For that I need to extend the table of core_groups & core_members afaik.

How can I do that? The only solution I found was the installer query, or is that actually the solution?

[Daniel F]

8 minutes ago, Michael Schneider said:

The only solution I found was the installer query, or is that actually the solution?

Exactly

And please don't forget to remove the custom columns via an uninstall extension (Please also take a look at https://invisionpower.com/forums/topic/423254-dev-hint-uninstall-extension-best-practice/ )

 

[Adriano Faria]

For apps, you should add your queries in Versions tab. Those columns will be dropped when you uninstall the app.

[GriefCode]

4 minutes ago, Daniel F said:

Exactly

And please don't forget to remove the custom columns via an uninstall extension (Please also take a look at https://invisionpower.com/forums/topic/423254-dev-hint-uninstall-extension-best-practice/ )

Cool. Good to know, thanks for the hint :-) But I'm not able to view it :-(

[Daniel F]

6 minutes ago, Michael Schneider said:

Cool. Good to know, thanks for the hint :-) But I'm not able to view it :-(

 

Ignore my reply. Adriano is correct, you don't need to take care of this if you use the queries.json file.

[GriefCode]

Just now, Daniel F said:

Ignore my reply. Adriano is correct, you don't need to take care of this if you use the queries.json file.

Okay, thanks 

[GriefCode]

1 hour ago, Adriano Faria said:

For apps, you should add your queries in Versions tab. Those columns will be dropped when you uninstall the app.

I got still an issue.

I have added the queries, build the application and deployed it, but for some reason the queries where not deployed.

Some minor code parts:

The repository is also up to date and here: https://github.com/gamershost/Forum-Report-Archive

[Adriano Faria]

The error is about core_members. Your queries are for core_groups.

[GriefCode]

1 minute ago, Adriano Faria said:

The error is about core_members. Your queries are for core_groups.

No, sorry that image was really bad choosen.

Here is the whole file with core_members queries:

https://github.com/gamershost/Forum-Report-Archive/blob/master/setup/upg_10000/queries.json#L281-L392

[newbie LAC]

9 hours ago, Michael Schneider said:

No, sorry that image was really bad choosen.

Here is the whole file with core_members queries:

https://github.com/gamershost/Forum-Report-Archive/blob/master/setup/upg_10000/queries.json#L281-L392

These queries (for core_members, core_groups) should be in setup/install/queries.json not upgrade

ACP - System - Applications - your app - Developer center - Versions - Installation Routine - Add SQL Query

[bfarber]

You indicated you built the application and deployed it, which leaves some gray area here. Are you testing against a test install, but pushing your code to a production installation once you are happy with it? Does it share the same database? If not, you will need to run the upgrader (siteUrl/admin/upgrade/ by default) and upgrade your application on your production installation to run the database changes.

[GriefCode]

3 hours ago, bfarber said:

You indicated you built the application and deployed it, which leaves some gray area here. Are you testing against a test install, but pushing your code to a production installation once you are happy with it? Does it share the same database? If not, you will need to run the upgrader (siteUrl/admin/upgrade/ by default) and upgrade your application on your production installation to run the database changes.

Hey,

thanks for following up, yes i develop on a local test install and once im happy i install it on my production server.
Of course the databases are fully split up. Who develops on a production database? 
So far the solution @newbie LAC noted is working for me as expected.

Or is there anything wrong with what i am doing at the moment?

 

[bfarber]

The post from newbie LAC outlines how to add the columns on the development install, but that wouldn't adjust the production install based on my understanding. Nevertheless if you have a working setup, that's great.