Jump to content

Runar

Clients
  • Posts

    386
  • Joined

  • Last visited

  • Days Won

    2

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Posts posted by Runar

  1. 3 minutes ago, MNOfficial said:

    I've tried in Chrome (default), Chrome Incognito and Safari. All three fail to connect to the website. I've cleared cache/cookies, my DNS cache. Gone in to see if I have firewall settings (I don't), proxy settings (I don't).

    Since you’ve tested in Safari I assume you’re using macOS. Would you open Terminal and enter the following command?

    traceroute ddg.com

    Replace ddg.com with your own domain name, and paste the result here or send it to me me in a message.

  2. I’m having the same issue, and I’ve traced it to this function on line 4353 in system/Content/Controller.php:

    protected function sendModerationAlert( array $values, \IPS\Content\Item|\IPS\Content\Comment $content ) : \IPS\core\Alerts\Alert
    { }

    More specifically, the second argument, the union types, causes issues for the editForm function in system/Plugin/Hook.php. On line 370, the editForm function loops through parameters and tries to get their types and names:

    $parameters[] = ( $parameter->getType() ? ( ( ( $parameter->allowsNull() ) ? '?' : '' ). '\\' . $parameter->getType()->getName() . ' ' ) : '' ) . ( $parameter->isPassedByReference() ? '&' : '' ) . '$' . $parameter->name . ( $parameter->isOptional() ? ( '=' . var_export( $parameter->getDefaultValue(), TRUE ) ) : '' );

    This works with single types, but not with union types.

    A single type returns a ReflectionNamedType, while union types return ReflectionUnionType, and trying to call getName() on a ReflectionUnionType will not work. I assume a simple check for ReflectionUnionType inside the try block would solve the issue.

    As far as I can tell, this issue affects all hooks to \IPS\Content\Controller and every class extending that class.

    For the record, I’m using PHP 8.1.16.

  3. I’m not dead! I’ve read all replies made the last few days, and I’ll post a longer update later this week.

    But to summarize: An update to make the app compatible with the latest Invision version will be submitted for approval this weekend. Bugfixes and new features will follow later.

    I’m also considering open sourcing this application and my other plugins (most are already open source), allowing anyone to make their own changes, but there’s some license stuff that must be taken into consideration. For instance, it will not be possible for anyone using my code to commercialize it, meaning any changes will have to be released for free. Also, at this time I’m not considering passing the application on to any other developer.

  4. 4 minutes ago, Edjazoli said:

    I don't know if the author is available atm??

    I’m replying to your post but my reply is meant to everyone here. I’m available and I’m reading all of your posts, and the next version is in progress, but I needed to prioritize real life during the last weeks. The next version will most likely be released around Easter, I won’t promise it’ll be ready any earlier.

    But I haven’t forgotten about you all, so all I ask is your patience and understanding.

  5. 22 hours ago, Dave D said:

    I can see these in the default Invision Theme, but not when I try with a Custom Theme we have.

    Could you try clearing the cache in your AdminCP, and see if the buttons appear after?

  6. 12 minutes ago, Marc Stridgen said:

    Hope you get to the bottom of the issues 🙂 

    Daniel found some interesting things earlier this week, so hopefully the solution is not too far away! 🙂

    I’ve already mentioned this to him, but I’ll repeat it here in case someone else has the same issues: I managed to replicate the issue on a local installation, so to me it seems the issue should exist for everyone (or at least more than just me) using Elasticsearch and the Gallery. I don’t know if it affects earlier versions of Invision Community, though, as I only started using the Gallery with version 4.6.9.

  7. 10 hours ago, Marc Stridgen said:

    I see Daniel managed to get that sorted for you. Please let us know if you have any further issues of course

    The issue is not yet fixed, unless you know something I don’t. Daniel has been really helpful, but as far as I know he’s still working on finding the issue and a solution. I’ll mark the solution when the issue is fixed, hopefully in not too long.

  8. 6 minutes ago, Nathan Explosion said:

    Same as you - don't worry, leave it with me...I'll just not use it.

    Thank you for making changes (even small) to your application to fix this issue, and for doing so quickly.

    I asked mainly because it’s weird that using this hook duplicates the <ul> element, so it could be worth reporting as a bug.

  9. The Samsung Internet browser is based on Chromium (the same browser engine as Chrome), so it should work fine if they’re using the latest version. Would you be able to find out what version of Samsung Internet, and what device, they’re using?

  10. 34 minutes ago, Nathan Explosion said:

    This is the problem with theme hooks - one thing affects another. No idea why my modification to my own added HTML would result in what you guys are describing but there we go.

    What selector are you using to add the translate button?

  11. 1 hour ago, Edjazoli said:

    Looks like  after @Nathan Explosion latest update the button is disappearing after" marking as a sold"(mobiles only) so its not possible to unmark topic(mobiles only)

    Indeed, it even hides the “Start new topic” button on mobile devices. Hopefully he’ll release another fix soon!

    1 hour ago, Edjazoli said:

    Another question, its any chance that button "sold" "solved" will be visible as well in the "topic feeds" block?

    Good idea, I’ll add it to the list of future features.

    1 hour ago, Edjazoli said:

    As well, I cant find anywhere option to give my moderators an option to mark/unmark? Sorry for all the questions....

    This is a known issue and I’m working on a fix that’ll hopefully be released this week.

    And don’t apologize for asking questions or requesting new features! Keep them coming! 😊

  12. 55 minutes ago, Nathan Explosion said:

    What is the selector you are using on your theme hook?

    I use the following selector (and the add_inside_start type) to target the <ul> element containing the topic action buttons:

    elClubContainer > div.ipsClearfix > ul.ipsToolList.ipsToolList_horizontal.ipsClearfix.ipsSpacer_both

    The issue in this case is that when a topic is closed, there are suddenly two <ul> lists. I don’t know if this is caused by your application or not, but it’s not normal behavior. Again, this only happens in closed topics.

    55 minutes ago, Nathan Explosion said:

    Also, is your resource an application or is it a plugin?

    It's been an application since version 2.0.0.

  13. 1 hour ago, Edjazoli said:

    Any chance you could add a key to this translation "unmark as %s" as you have with "marks as %s"

    Good idea, I’ll add it to the list of future features. It shouldn’t take too long!

    1 hour ago, Edjazoli said:

    As well I've got two "unmark" for rest of the members after choosing " Allow anyone to unmark the topic?↩️

    That doesn’t look right. Would you please translate the text to the left of the buttons, and tell me how the text ended up there? Are you using any plugins that do something with that part of the page?

  14. On 2/1/2022 at 8:23 PM, Edjazoli said:

    Any chance for signup registration page message with maybe possibility of adding image etc ?

    I would separate these into two features, but both are possible! I’ll see what I can do.

×
×
  • Create New...