Jump to content

sulervo

Clients
  • Posts

    113
  • Joined

  • Last visited

Reputation Activity

  1. Like
    sulervo got a reaction from Jim M in acp log out   
    Thanks, it helped. I have used CF for years and now this started..
  2. Like
    sulervo reacted to teraßyte in [4.7.15] Cloning a custom Commerce package throws an "Access to undeclared static property" error   
    I created a new type of Commerce package for a client, and when trying to clone it an error is thrown.
    Here's the stacktrace:
    Error thrown with message "Access to undeclared static property IPS\premium\Package\Premium::$packageDatabaseColumns" Stacktrace: #6 Error in \applications\nexus\sources\Package\Package.php:264 #5 IPS\nexus\_Package:__clone in \system\Node\Controller.php:915 #4 IPS\Node\_Controller:copy in \system\Dispatcher\Controller.php:107 #3 IPS\Dispatcher\_Controller:execute in \system\Node\Controller.php:69 #2 IPS\Node\_Controller:execute in \applications\nexus\modules\admin\store\packages.php:46 #1 IPS\nexus\modules\admin\store\_packages:execute in \system\Dispatcher\Dispatcher.php:153 #0 IPS\_Dispatcher:run in \init.php:934  
    The issue is caused by the __clone() method in applications/nexus/sources/Package/Package.php which is missing the isset() check:
    foreach ( $this->_data as $k => $v ) { if ( !\in_array( $k, array( 'id', 'reviews', 'unapproved_reviews', 'hidden_reviews' ) ) ) { if ( \in_array( "p_{$k}", static::$packageDatabaseColumns ) ) { $secondaryTable[ "p_{$k}" ] = $v; } else { $primaryTable[ "p_{$k}" ] = $v; } } } Every other method properly checks if the variable is set before using it, but the __clone() method doesn't.
     
    Here's an example from the save() method where the isset() check is properly implemented:
    foreach ( $this->changed as $k => $v ) { if ( isset( static::$packageDatabaseColumns ) and \in_array( "p_{$k}", static::$packageDatabaseColumns ) ) { $secondaryTable[ "p_{$k}" ] = $v; unset( $this->changed[ $k ] ); } elseif ( !\in_array( "p_{$k}", array( [...] ) ) ) { unset( $this->changed[ $k ] ); } }
  3. Like
    sulervo reacted to Marc Stridgen in Menu manager - Commerce items   
    Glad to hear you managed to get the issue resolved 🙂
  4. Like
    sulervo got a reaction from IPCommerceFan in Missing Commerce Support   
    Stipe works now in production environment. Probably server host blocks in the test environment, incident opened. Cloudflare pause didn't help.
     
  5. Thanks
    sulervo reacted to teraßyte in Missing Commerce Support   
    The Nexus support module is installed hidden by default, and there's a code check to add it to the ACP menu on the fly only if it's set as visible. Basically, fresh installations won't even show it since it's been deprecated. I don't remember in which version the change was made, though.
     
    Here's the code I'm talking about in \nexus\Application.php:
    public function acpMenu() { $menu = parent::acpMenu(); if( $m = \IPS\Application\Module::get( 'nexus', 'support', 'admin' ) AND $m->visible ) { $menu['support'] = array( ... ); } return $menu; }  
  6. Agree
    sulervo reacted to teraßyte in Mandatory checkboxes in Commerce custom fields   
    A required checkbox field should always require a 1 value IMO. I consider it a bug.
    Or at least add a new setting that allows you to require it to be actually checked on submission. 🤷‍♂️
  7. Like
    sulervo reacted to opentype in Mandatory checkboxes in Commerce custom fields   
    A checkbox allows for “0” and “1” and “0” is technically a valid choice. 
    By the way: the “Checkbox Set” field does work as you request it here, even if there is just one choice given. In this case, it’s “at least one field must be checked”. I use this option to create a mandatory license agreement in one of my stores. 
  8. Like
    sulervo reacted to DawPi in (NB41) Enhanced Advertisements   
    If someone has issues with that app I happy to announce that I've upgraded it to newest version of the IPS4/PHP8.
    I can't release it of course and must be done foe everyone separated.
    PM me for more details if you're interested.
  9. Agree
    sulervo reacted to TheWorldNewsMedia.org in Everybody is choosing "Night Mode" nowadays....   
    I think we need to include this functionality as well.
  10. Like
    sulervo reacted to Marc Stridgen in Background Processes in stuck   
    Glad to hear my colleague managed to get that sorted for you 🙂 
  11. Thanks
    sulervo reacted to stoo2000 in Trader Feedback System   
    Notifications can only be linked to one place and that's the feedback that has been left.
  12. Like
    sulervo got a reaction from Ibai in iPad/iPhone image browse   
    It's terrible to try browse images in vertical view. Arrows are not working at all.
    In horizontal view all is fine.
    Maybe this can fix?

  13. Thanks
    sulervo reacted to stoo2000 in Trader Feedback System   
    Sure, I can change the 'require' setting to the options...
    Required Optional Hide content linking
  14. Like
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    CSS selector
    [data-pageapp="forums"][data-pagemodule="forums"][data-pagecontroller="topic"] .ipsType_pageTitle
  15. Like
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
    Use CSS selector
    [data-pageapp="forums"][data-pagemodule="forums"][data-pagecontroller="forums"] [data-tableid="topics"]  
  16. Like
    sulervo got a reaction from CoffeeCake in Search result improvements   
    1. Search results: Condensed and expanded view.

    Like in "All activity":
    https://invisioncommunity.com/discover/?&view=condensed
    https://invisioncommunity.com/discover/?&view=expanded
    2. Search result links: "Go to the first post of topic" instead of "Go to the post". This could be ACP setting.
    Search results: https://invisioncommunity.com/search/?&q=forum&type=forums_topic&nodes=499&search_and_or=or&sortby=relevancy
    -> the first link: https://invisioncommunity.com/forums/topic/456558-when-will-the-ipb-45-forum-be-ready/?tab=comments#comment-2817447
    -> the link could be: https://invisioncommunity.com/forums/topic/456558-when-will-the-ipb-45-forum-be-ready/
     
  17. Like
    sulervo reacted to InvisionHQ in Pre-defined Topic Fields - IP.Board 4.x   
    Thanks for reporting. I update you later today.
  18. Thanks
    sulervo got a reaction from InvisionHQ in Pre-defined Topic Fields - IP.Board 4.x   
    This plugin needs an update.
    Users can't post a new topic when the plugin is enabled.
  19. Thanks
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
     
    // Topic view var forum_id = {expression="(request.app == 'forums' and request.module == 'forums'and request.controller == 'topic') ? \IPS\Output::i()->hiddenElements['nbenhadverts_node_id'] : 0"};  
  20. Like
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
     
  21. Thanks
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
    var forum_id = {expression="(request.app == 'forums' and request.module == 'forums'and request.controller == 'forums' and isset(request.id)) ? request.id : 0"};  
  22. Like
    sulervo reacted to stoo2000 in Trader Feedback System   
    Sorry, I'm not convinced that it would be something worth working on for the general product. I don't see that it's something that many customers would want/need.
    I would recommend submitting a support ticket (see the support info in the file listing), I cannot reproduce what you are seeing.
  23. Thanks
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
    CSS selector 
    [data-pageapp="forums"][data-pagemodule="forums"][data-pagecontroller="forums"] .cTopicList .ipsDataItem:eq(9) Position 
    Insert advert after the chosen element(s)  
  24. Thanks
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
    Add in Extra condition field 
    {{if request.app == 'forums' and request.module == 'forums' and request.controller == 'index'}}1{{endif}}  
  25. Thanks
    sulervo reacted to newbie LAC in (NB41) Enhanced Advertisements   
    Hello,
     
×
×
  • Create New...