Jump to content

Gabriel Torres

Clients
  • Posts

    1,748
  • Joined

  • Last visited

  • Days Won

    4

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Posts posted by Gabriel Torres

  1. @Jim M I was facing the same issue (we had literally thousands of those errors in our logs), and your advice to disable the template disk caching solved the issue for me. I only wonder if this is something more serious that must be addressed.

    For those looking for this option: Advanced Configuration > Server Environment > Performance > Enable template disk caching?

  2. BTW, the last issue is actually throwing an error:

    TypeError: Cannot access offset of type string on string in [redacted]/applications/core/extensions/core/MemberHistory/Core.php:767
    Stack trace:
    #0 [redacted]/system/Member/History.php(157): IPS\core\extensions\core\MemberHistory\_Core->parseLogData()
    #1 [redacted]/system/Helpers/Table/Db.php(444): IPS\Member\_History->IPS\Member\{closure}()
    #2 [internal function]: IPS\Helpers\Table\_Db->getRows()
    #3 [redacted]/init.php(932) : eval()'d code(138): call_user_func_array()
    #4 [redacted]/system/Helpers/Table/Table.php(504): IPS\Helpers\Table\hook2489->getRows()
    #5 [redacted]/system/Theme/Theme.php(885) : eval()'d code(2507): IPS\Helpers\Table\_Table->__toString()
    #6 [redacted]/system/Theme/SandboxedTemplate.php(61): IPS\Theme\class_core_admin_memberprofile->history()
    #7 [redacted]/applications/core/modules/admin/members/members.php(1257): IPS\Theme\_SandboxedTemplate->__call()
    #8 [redacted]/system/Dispatcher/Controller.php(107): IPS\core\modules\admin\members\_members->view()
    #9 [redacted]/system/Dispatcher/Dispatcher.php(153): IPS\Dispatcher\_Controller->execute()
    #10 [redacted]/[redacted]/index.php(13): IPS\_Dispatcher->run()
    #11 {main}
    #0 [redacted]/system/Member/History.php(162): IPS\_Log::log()
    #1 [redacted]/system/Helpers/Table/Db.php(444): IPS\Member\_History->IPS\Member\{closure}()
    #2 [internal function]: IPS\Helpers\Table\_Db->getRows()
    #3 [redacted]/init.php(932) : eval()'d code(138): call_user_func_array()
    #4 [redacted]/system/Helpers/Table/Table.php(504): IPS\Helpers\Table\hook2489->getRows()
    #5 [redacted]/system/Theme/Theme.php(885) : eval()'d code(2507): IPS\Helpers\Table\_Table->__toString()
    #6 [redacted]/system/Theme/SandboxedTemplate.php(61): IPS\Theme\class_core_admin_memberprofile->history()
    #7 [redacted]/applications/core/modules/admin/members/members.php(1257): IPS\Theme\_SandboxedTemplate->__call()
    #8 [redacted]/system/Dispatcher/Controller.php(107): IPS\core\modules\admin\members\_members->view()
    #9 [redacted]/system/Dispatcher/Dispatcher.php(153): IPS\Dispatcher\_Controller->execute()
    #10 [redacted]/[redacted]/index.php(13): IPS\_Dispatcher->run()
    #11 {main}

    After manually deleting the log entry "account_deletion_cancelled", the error is not thrown anymore. So, there is a bug that must be addressed!

    Cheers.

  3. In ACP > Notification Settings

    Could contain: Page, Text

    I have no clue why this acp_notification_Maxmind is there (this string doesn't exist) and why ACP_NOTIFICATION_GROUP_COMMERCE is duplicated (it shows again right below, but correctly replaced with "COMMERCE").

    In a user profile inside the ACP:

    Could contain: Page, Text

    I have no clue  on why this is happening, as the account_deletion_cancelled string does exist. Maybe something to do with those "quotes"?

    Cheers

  4. Hello,

    Today I noticed that the byline_itemprop language string defaults to: By %s,

    Could contain: Text, Page

    The presence of this comma causes a visual issue in topics, as the name of the author is incorrectly followed by a comma:

    Could contain: Text, Page, Symbol

    This comma, however, is used for separating the username from the date/time string in the topic list:

    Could contain: Page, Text

    So, if we edit the byline_itemprop string to remove the comma, it fixes the issue in the topic, but create another issue in the topic list:

    Could contain: Text, Symbol

    Here at invisioncommunity.com, I noticed that this language string was edited and the comma was removed, so the username isn't followed by a comma in topics, but the username and the date/time are not separated by a comma in the topic list.

    Proposed solution: add a new language string that defaults to By %s (without a comma) and use this new language string in the forums > front > topics > topic template.

    I know this is a very silly visual bug, but I had to mention it.

    Cheers,

    Gabe.

  5. @Adriano Faria

    I've read the other topic from @CodingJungle where you guys were discussing the infamous parent error with PHP8:

    Quote

    PHP Fatal error:  Cannot use "parent" when current class scope has no parent in /system/Theme/Theme.php(2703) : eval()'d code on line 137

    Our install has several custom-made apps and plugins, and the developer @newbie LAC is MIA since the beginning of the Covid pandemic (and I fear for the worst, as I tried, unsuccessfully, contacting him via email a few times). Since we want to preserve all these plugins, I have to fix all of these errors myself before moving to PHP8 in production, which is quite annoying. I will post below the issue I am having with one specific plugin, so maybe you guys can help me out fixing the issue and, hopefuly, once I understand how to fix this, I will be able to replicate the fix to all other plugins that are throwing the same error.

    As seen in the log above, the error is thrown in line 137, which reads as:

    $whosOnline = parent::whosOnline($members, $memberCount, $guests, $anonymous, $orientation);

    I've tried to surround this statement with what you suggested in the other topic, at no avail:

    if( \is_callable( 'parent::whosOnline' ) )
    	{
    	$whosOnline = parent::whosOnline($members, $memberCount, $guests, $anonymous, $orientation);
    	return $whosOnline;
        }

    If you could help me out it would be super.

    I am attaching the hook file to this post for your evaluation.

    Thanks.

    nbBotsInOnlineListTplWhosOnline.php

  6. 23 hours ago, Matt said:

    Run the following query, and check to see if the Collation is 'utf8mb4_unicode_ci'

    Yes, it is:

    +------------------------+--------+---------+------------+------+----------------+-------------+-----------------+--------------+-----------+----------------+---------------------+-------------+------------+--------------------+----------+--------------------+---------+
    | Name                   | Engine | Version | Row_format | Rows | Avg_row_length | Data_length | Max_data_length | Index_length | Data_free | Auto_increment | Create_time         | Update_time | Check_time | Collation          | Checksum | Create_options     | Comment |
    +------------------------+--------+---------+------------+------+----------------+-------------+-----------------+--------------+-----------+----------------+---------------------+-------------+------------+--------------------+----------+--------------------+---------+
    | core_profanity_filters | InnoDB |      10 | Dynamic    | 2095 |             62 |      131072 |               0 |        49152 |         0 |           9604 | 2022-08-19 13:21:53 | NULL        | NULL       | utf8mb4_unicode_ci |     NULL | row_format=DYNAMIC |         |
    +------------------------+--------+---------+------------+------+----------------+-------------+-----------------+--------------+-----------+----------------+---------------------+-------------+------------+--------------------+----------+--------------------+---------+

     

  7. On 9/6/2022 at 7:56 AM, Andy Millne said:

    Are these different letters or the same letter with a different case?

    Technically different letters, but I don't know how they are treated in PHP/MySQL, is as different letters or the same letter with a different accent, similarly to what happens with a/ã/á/à, for example.

    On 9/6/2022 at 7:56 AM, Andy Millne said:

    It sounds like this may be a MySQL case sensitivity issue.

    I wouldn't know.

    On 9/6/2022 at 7:56 AM, Andy Millne said:

    If you keep just the single entry do both variants match when you try to add a post with the word? 

    No, they don't match. Hence the issue and the need to add a new entry in the word filters for that variant.

    Cheers.

  8. Just a quick follow-up on this, I tried upgrading from 7.4 directly to 8.1, however, we started getting 500 errors, apparently due to a few of the plugins not being compatible with 8.1. Some of them are not maintained anymore, however, very useful in our community. Therefore, I am halting the upgrade to 8.1 for the time being, until I have the time to debug each plugin.

    For example:

    2022/07/30 16:38:14 [error] 3477#0: *12148 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Declaration of IPS\hook3800::link($warningRef = null, $groupFormatting = null) must be compatible with IPS\_Member::link($warningRef = null, $groupFormatting = null, $anonymous = false) in [redacted]/init.php(927) : eval()'d code on line 84" while reading response header from upstream, client: [redacted], server: [redacted], request: "GET /forums/topic/1334466-compatibilidade-de-componentes-placa-de-video-e-placa-m%C3%A3e/ HTTP/2.0", upstream: "fastcgi://127.0.0.1:9000", host: "[redacted]"

    Cheers.

  9. Hi,

    I am testing the new Alert feature introduced in version 4.7.0. I created a test alert to a single user, with no replies. When I log in as that user, the alert is displayed, but clicking on the DIsmiss button does nothing. The popup is kept on the screen.

    Could someone perform this test, so we can know whether this is a local problem or a general bug?

    Note: tested with all third-party apps and plugins disabled and using the default, unmodified theme, and clearing the cache.

    Thanks.

  10. Hi guys,

    As usual, we face limitations when translating certain strings since in English there is no male/male words like in Portuguese, Spanish etc.

    In addition, some words in English don't change regardless of singular/plural.

    Right now, the following strings that are giving us trouble.

    notification__unapproved_content_bulk_title

    notification__unapproved_content_title

    These two strings default to: ⚠️ New %s awaiting approval

    There are two problems here:

    1. We don't know deforehand whether "%s" will be a male or a female word. "New", in English, doesn't have gender, but in Portuguese/Spanish/etc the adjective changes depending on the noun: Nova (female) / Novo (male). And we have a mix here! Some examples:

    Male: post, tópico (topic)

    Female: avaliação (review), respostas (reply)

    2. We don't know beforehand wether "%s" will be a singular or plural word. In English, "New" doesn't change with singular/plural, but in Portuguese/Spanish/etc it does. So, if we translate "New" as "Novo", when %s is plural, the grammar is incorrect (ex: "Novo posts" instead of "Novos posts").

    I tried to use the {!#[1:novo][?:novos]} trick, but it didn't work here. But this would fail the male/female problem anyway.

    I got a little creative here and solved this by translating this string as:

    ⚠️ Há %s aguardando aprovação

    Instead of using the adjective "New", I changed it to the verb "Há" (There is/There are). So we have "There is/there are %s awaiting approval". The meaning is slightly different from the original string, but it does the trick.

    Even though I have found a solution, I thought it would be interesting to tell you this, so you understand the challenges we face when running non-English communities.

    However, the major issue now is with the following string:

    notification__unapproved_content_grouped

    Which defaults to:

    There are {count} new %s requiring approval %s

    Here, since we have the {count}, we can correctly apply the singular/plural trick, so I translated it to:

    Há {count} {!#[1:novo][?:novos]} %s aguardando aprovação %s

    The problem now is, we don't know whether the first "%s" will be a male or a female word. So we have a gender mismatch whenever it is a female noun.

    Now, another issue we have is when it is a review in Pages that is pending approval. It is pulling the string "avaliação" (review), in the singular form, even when more than one is present. See the screenshot below. This may be a bug, maybe the system is pulling __defart_content_record_reviews_title instead of __defart_content_record_reviews_title_plural, and I kindly ask you to take a look into this. In other words, which string is being used in the first %s when the this notification is about reviews in Pages.

    I hope I was clear enough for you to undertand what I mean, and let me know if you need any additional information.

    Best regards,

    Gabriel Torres

    Could contain: Business Card, Paper, Text

  11. Hi,

    We have the word "configuracoes" configured in our word filter to replace it with its correct form: "configurações".

    Now we are trying to add the word "configuraçoes", however, the system doesn't allow it, saying "there is an existing filter for this word".

    So, the system doesn't differentiate "c" from "ç", which are different letters.

    Please advise.

    Gabe.

  12. Hi @Marc Stridgen

    Sure. Scroll down to the Overclock forum at: https://www.clubedohardware.com.br/forums/

    See how the counter is 0/2. Click on the "2". You will see that there is only one pending post.

    I created this posted and the counter jumped straight to "2". See my original post with the full explanation.

    Note: I cleared all caches, restarted PHP/redis, disabled all apps/plugins, tested with an unmodified, default template.

     

×
×
  • Create New...