Jump to content

phpony

Members
  • Posts

    448
  • Joined

  • Last visited

  • Days Won

    1

Reputation Activity

  1. Like
    phpony got a reaction from Haku2 in Settings for using SOCKS proxy for all CURL requests   
    Hi fellow developers and members of community. I'm here with a small quality of life suggestion that can slightly improve the usability of forum software in some cases.
    The forum software I'm supporting is installed on server without direct internet access. Yes, that's weird, I know. And there's nothing I can do about. But there's a proxy server on internal network that may and should be used for all external connections. As for now I'm bound to implement a hardcode fix after each system's upgrade. All I do is editing the file system\Http\Request\Curl.php around lines 139-145 from this:
    curl_setopt_array( $this->curl, array( CURLOPT_HEADER => TRUE, // Specifies that we want the headers CURLOPT_HTTP_VERSION => $httpVersion, // Sets the HTTP version CURLOPT_RETURNTRANSFER => TRUE, // Specifies that we want the response ... To this:
    curl_setopt_array( $this->curl, array( CURLOPT_PROXY => "10.0.0.33", CURLOPT_PROXYPORT => "1080", CURLOPT_PROXYTYPE => CURLPROXY_SOCKS5, CURLOPT_PROXYUSERPWD => "forum:password", CURLOPT_HEADER => TRUE, // Specifies that we want the headers CURLOPT_HTTP_VERSION => $httpVersion, // Sets the HTTP version CURLOPT_RETURNTRANSFER => TRUE, // Specifies that we want the response ... After this change everything works as intended - oembed codes, updates check, marketplace, etc.
    So I'm here with a suggestion - I understand that I may be a single one user with such a problem, but maybe developers would find it useful to make their system a bit better by creating a group of system settings named "Proxy" with "Use a proxy for external connections" checkbox and "Proxy IP", "Proxy port", "Proxy type", "Proxy login", "Proxy password" strings, that could be passed into curl settings right there? That wouldn't break anything for existing customers but will provide additional opportunities for others in cost of few additional code lines and one `if` check.
    Thanks in advance!
  2. Like
    phpony reacted to Jan Krohn in Fix "share by email" feature   
    Hi,
    This morning I woke up to find that tens of thousands of spam emails were sent through the "share by email" feature.
    The support's brilliant suggestion was to disabling that feature.
    So instead of taking the responsibility to fix or remove a easily abusible feature, it's the customer's responsibility to disable it.
    Bravo!
    If the content that is to be shared can be removed and replaced by a spam message, then the feature is clearly broken. If this happens tens of thousands of times, and the system doesn't catch that, then the system is broken too.
×
×
  • Create New...