Everything posted by teraßyte
-
Since the client couldn't wait for a future version with the fix, I made this change for them: /* Reindex the now hidden content - if this is a content item with comments or reviews, then make sure to do those too. */ if ( $this instanceof \IPS\Content\Searchable ) { if ( $this instanceof \IPS\Content\Item AND ( isset( static::$commentClass ) OR isset( static::$reviewClass ) ) ) { \IPS\Content\Search\Index::i()->index( ( static::$firstCommentRequired ) ? $this->firstComment() : $this ); \IPS\Content\Search\Index::i()->indexSingleItem( $this ); } else { /* Either this is a comment / review, or the item doesn't support comments or reviews, so we can just reindex it now. */ \IPS\Content\Search\Index::i()->index( $this ); } }I simply added an extra IF check on \IPS\Content\Searchable. Posted it here in case someone else needs it. -
Maybe the auto-linking could be changed to work only if the word starts with a protocol (http/https)? Also, the current conversion changes these filenames into HTTP links rather than HTTPS. All links should use HTTPS by default, IMO.
-
Safari has been having a lot of problems lately. 🙄
-
There is no specific date yet. Just a generic 2025/2026 date in the Deprecation Tracker:
-
Maybe the email had a space in it somehow, and re-entering it fixed the issue. I've seen it happen a couple of times after upgrades from old versions. 🤔
-
Not sure. 🤷♂️ Do you also have the correct variables in the conf_global.php file? 'sql_charset' => 'utf8mb4', 'sql_utf8mb4' => true, If you still get the same error you can force a re-conversion using the CLI script. That should fix it once and for all.
-
I wish I knew that beforehand. Next time I'll let the v4 tasks run before upgrading to v5. 😅
-
Don't convert the tables through direct queries. Invision Community includes a tool to convert the data to UTF8MB4, and it even has a CLI script you can run from the command line. Restore a backup and then use that tool. You can find it in the folder /admin/convertutf8.
-
Not sure if other queue extensions are possibly missing, too. 🤔
-
The upgrade from 3.4 to 4.7 adds a RecountPollVotes background process in the ACP dashboard, but the extension is gone in v5 and the poll votes are not properly recounted when the task tries to run it, it's simply removed from the database without any specific error or warning. The upgrade was done with the following steps: 3.4.9 => 4.7.20 4.7.20 => 5.0.3
-
Concerning this other bug report: The ACP > Support page does NOT detect that I edited the Poll.php file. 🤨
-
I helped upgrade a 3.4 forum to 5.0.3 (passing through 4.7.20) and loading an old topic with a poll threw this error: TypeError: IPS\Poll::get_choices(): Return value must be of type array, null returned (0) #0 /home/nuovo/public_html/invision/system/Patterns/ActiveRecord.php(360): IPS\Poll->get_choices() #1 /home/nuovo/public_html/invision/system/Poll/Poll.php(528): IPS\Patterns\ActiveRecord->__get() #2 /home/nuovo/public_html/invision/static/templates/forums_front_topics.php(3898): IPS\Poll->__toString() #3 /home/nuovo/public_html/invision/system/Theme/SandboxedTemplate.php(68): IPS\Theme\class_forums_front_topics->topic() #4 /home/nuovo/public_html/invision/applications/forums/modules/front/forums/topic.php(724): IPS\Theme\SandboxedTemplate->__call() #5 /home/nuovo/public_html/invision/system/Dispatcher/Controller.php(139): IPS\forums\modules\front\forums\topic->manage() #6 /home/nuovo/public_html/invision/system/Content/Controller.php(124): IPS\Dispatcher\Controller->execute() #7 /home/nuovo/public_html/invision/applications/forums/modules/front/forums/topic.php(82): IPS\Content\Controller->execute() #8 /home/nuovo/public_html/invision/system/Dispatcher/Dispatcher.php(169): IPS\forums\modules\front\forums\topic->execute() #9 /home/nuovo/public_html/invision/index.php(16): IPS\Dispatcher->run() #10 {main} After looking into it I discovered the poll choices in the database were saved in the old serialized data instead of the new JSON format. To temporarily fix the issue for them until a fix is included in a future upgrade I add an unserialize fallback in the get_choices() function for them. Original code: /** * Get choices * * @return array */ public function get_choices(): array { return json_decode( $this->_data['choices'], TRUE ); }My change: /** * Get choices * * @return array */ public function get_choices(): array { $choices = json_decode($this->_data['choices'], true); # If json_decode fails, try unserialize as a fallback if (json_last_error() !== JSON_ERROR_NONE) { $choices = @unserialize($this->_data['choices']); # If the result is a proper array update the database to use JSON if ( is_array($choices) ) { $this->choices = $choices; $this->save(); } } return $choices; }
-
As per title. Here's what the widget looks like right now on v5.0.3: The second line of text is not centered and needs some padding/margin, too.
-
You can specify the port with a different variable: 'sql_host' => 'localhost', 'sql_port' => 3306,
-
Indeed. The tables not being utf8mb4 is causing that "incorrect string value" issue above. Make sure to do a database backup before running it, though. Always best to be safe.
-
Step 7 of the upgrade to version 4 should NOT reference any upg_500001 class/folder because that's the 5.0.0 Alpha 1 upgrade step. Did you upload the v5 files, and then upload the v4 files above them to redo the upgrade? Your best option here in order is to: Restore a 4.2.7 backup (remove any new files too, don't restore just the database) Upgrade to 4.7.20 Upgrade to 5.0.3
-
I'm replying from my phone so I can't check right now, but I don't remember seeing that wording about Apache servers. 🤔 Is v5 installed on the same server? It's possible PHP or Apache are configured differently if it's a different one.
-
v5 provides the same downloadable file as v4 in the same location.
-
The problem is caused by the media tag: <media:content medium="image" url="https://pbs.twimg.com/media/GkWmYMeacAADdLR.jpg"/>The XML parser strips any tag that includes a colon in its name. The above won't work, but this code below would for example: <media medium="image" url="https://pbs.twimg.com/media/GkWmYMeacAADdLR.jpg"/> I know because a client had the same issue on v4 and I made a modification for them to work around that. Without hooks, I can't update the app as-is for v5, though. I'd need to create a custom controller that retrieves the XML file, replaces the tags with colons, and then passes it over to the RSS Import class. In any case, the image inside the <media> element still won't be imported because the RSS Import code does NOT check that specific tag. The blog import only imports data from the <description> tag. Part of the modification I made was also to convert that element into an enclosure and then import it as a blog entry photo.
-
That is a problem in how IPS uses hook points inside foreach cycles. Before we could still access the data with the old theme hooks, but not anymore. They need to split the HTML into a separate template and call it inside the foreach so we have access to $row. They already made the change for some templates reported before.
-
Yep. The filters on that page have been broken since the v5 upgrade. It's been reported a few times already.
-
There's no API for that. Either IPS adds it or you make a custom application to implement the API yourself.
-
Yep. The only way would be to make a completely new app/widget that extends the old one (or copy/paste in some cases).
-
Yep. I can confirm the HTML editor for ads defaults to plaintext and there's no way to change it.
-
You probably have the Post Before Registering setting enabled. It allows guests to reply, but they have to register/validate an account before the comment appears: Allowed where Members group can post Guests will see the ability to submit content and then will immediately be prompted to register an account before the content is actually submitted and viewable. This is useful for encouraging guests to register. Guest users will have up to one week to complete their registration before their content will be permanently removed. If the guest user does not complete their registration immediately, they will be sent a reminder email shortly after making the post.
