Jump to content

teraßyte

Clients

  • Joined

View Profile Find content

v5 Bug Comments posted by teraßyte

    IN_DEV mode loads the data from different locations/files (js, CSS, templates, etc) and requires uploading a separate zip package with the extra files.

    You really shouldn't enable it on a production site. If you need it, setup a test site somewhere else not accessible by everyone (either locally or behind a htaccess check maybe).

    ·

    Edited by teraßyte
    typo

    You probably have the Post Before Registering setting enabled. It allows guests to reply, but they have to register/validate an account before the comment appears:

    Allowed where Members group can post

    Guests will see the ability to submit content and then will immediately be prompted to register an account before the content is actually submitted and viewable. This is useful for encouraging guests to register.

    Guest users will have up to one week to complete their registration before their content will be permanently removed. If the guest user does not complete their registration immediately, they will be sent a reminder email shortly after making the post.

    ·

    Edited by teraßyte

    Another related issue to this location is that the code should not return the whole ipsBadge ipsBadge--intermediary CSS, but only intermediary because the code already automatically adds the ipsBadge ipsBadge-- part:

    	protected function get__badge(): ?array
	{
		if ( $this->deleteOrMoveQueued() === TRUE )
		{
			return array(
				0	=> 'intermediary',
				1	=> 'mass_change_purchases_in_progress',
			);
		}

		if( $this->locked )
		{
			return array(
				0	=> 'negative',
				1 	=> 'product_locked'
			);
		}
		
		/* Check extensions for a possible badge */
		return $this->ui( 'rowBadge', array(), true );
	}

    With the current code, the output is the following with a non-existent ipsBadge--ipsBadge CSS class:

    <span class="ipsBadge ipsBadge--ipsBadge ipsBadge--negative">Locked</span>

    After my change above the output is as expected:

    <span class="ipsBadge ipsBadge--negative">Locked</span>

    EDIT

    This issue is present in a lot of other get__badge() functions from other classes, not just this one.

    The restricted moderator permissions also caused all sorts of template issues all over the place (userBar, WidgetContainer at the top, Sidebar, WidgetContainer at the bottom, etc.).

    Once I edited the moderator and made it unrestricted, (despite the error above) all issues went away.

    I believe some code assumes a certain moderator permission always exists while in fact, it's not there.

    I'm saying this because this was a test upgrade from version 3.4.9 to 5.0.2 (passing through 4.7.20) and moderator permissions like posting topics in the future were not included in v3.