Crystal V

@marklcfc The issue is not with this app. There's no javascript loaded. It's simply a link. A link wouldn't cause that error.

@marklcfc Do you use caching? Does running the support function fix it?

There should be no difference since all there is in whatsapp_cvh.css is:

.cShareLink_whatsapp {
	background-color: #3C8A38;
}

ul[data-controller="core.front.core.sharelink"] > li:empty {
  display: none;
}

@sobrenome Glad you got it working.

8 hours ago, sobrenome said:

It was not found.

Do you mean there's none or only one?

1 hour ago, sobrenome said:

How can I completely remove everything to do a fresh install? I have no other sharing plugin/app.

?

Make sure plugin is uninstalled in the admin CP. 

Does the table core_share_links have an entry (or more) with a share_key of whatsappcvh, whatsapp, or some variant thereof? If so, a screenshot would be helpful. 

If there is no entry then download the contents of your /plugins folder and see if there's a folder with a file with somewhere within the lines "if ( $this->key != 'whatsappcvh' )" and "class _Whatsappcvh".

Also do a search of /system/Content/ShareServices/ and see if there's more than one file with "class _Whatsappcvh". If there's only one then it's as it should be.

@sobrenome

I think perhaps another plugin/app is conflicting or perhaps even stuff in the DB from the previous install? I even compared share plugins from other developers to see if there was some issue with how I was using it and they used the same setup.

@Safety1st

Thanks for reporting.  I'll look into the encoding. I did a side by side comparison of javascript's encodeURIComponent encoding of a url with an ampersand and the way it's done server side via the plugin but I'll check around to see if differences on Windows Phone 8.1 are mentioned.

@sobrenome I've compared to other share services in the marketplace and confirmed we do use the same sort of class in the same folder. I've attempted to clean up any code ambiguities in this new version (1.0.10) I just released to see if it does the trick. I am waiting to see if IPS changes the way they discover share services.

Do you currently have a copy of 1.0.8 if the new version still does not work for you? I can attach a copy for you if you don't.  

@sobrenome I'm going to be switching back to using only the plugin and no extra files per the upcoming IPS guidelines that were announced. Will update when it's ready. Hopefully that fixes the issue.  

50 minutes ago, sobrenome said:

Fatal error: Class '\IPS\Content\ShareServices\Whatsappcvh' not found in /home/xxx/public_html/forum/applications/core/sources/ShareLinks/Service.php on line 205

Yes. That error means it can't read the file or that the Whatsappcvh.php file isn't in the proper folder. I've run the file through the IDE again and can't see anything.

Let's try this. Uninstall the plugin via the interface. Upload the contents of the /upload folder. If the file is in the proper place it should show up in Admin CP > Sharing though don't enable, it's just to see if it's there.

If it's not there, to look further into this I'd need some form of access.

14 minutes ago, sobrenome said:

I have uninstalled and installed again. Not showing in sharing though. 

Are you sure you have the file at /your-ips-folder/system/Content/ShareServices/Whatsappcvh.php? I uninstalled the app, deleted the file on my system, and then uploaded the file again. Simply by doing that it shows up as 'Whatsappcvh' in Admin CP > System > Sharing. I downloaded the plugin and installed from there so the zip doesn't seem corrupt.

The plugin install itself is for the template, language strings, and settings rather than making it show up in Admin CP > System > Sharing.

13 hours ago, Ebrahim Azizpoor_546852 said:

Hello
There are no files to install the downloaded file?

What do you mean? I just downloaded the zip and see both the xml file and the /upload folder. The file that is necessary should be at /your-ips-folder/system/Content/ShareServices/Whatsappcvh.php on your server after you upload the contents of the /upload folder.

1 hour ago, sobrenome said:

Ok, I have uninstalled and installed again.

Now it does not show up in sharing.

Did you upload the file in the /upload folder?

@sobrenome I don't use an index.html file in the plugin nor do I do anything with the file system. I've seen issues with the file system sometimes caused by Opcache but that's not controlled by my plugin. What does uninstalling and reinstalling do?

Updated the description to point out uploading the file is necessary.  

2 hours ago, Mike John said:

I'm not able to reproduce this locally. I'll need acp and ftp login details to troubleshoot further.

The issue is that it's trying to save the member object instead of just the member id. Should be something like this in \applications\autowelcome\modules\admin\settings\settings.php:

			if ( !empty( $values[ 'aw_pm_from' ] ) and $values[ 'aw_pm_from' ]->member_id )
			{
				$values[ 'aw_pm_from' ] = $values[ 'aw_pm_from' ]->member_id;
			}

			if ( !empty( $values[ 'aw_email_from' ] ) and $values[ 'aw_email_from' ]->member_id )
			{
				$values[ 'aw_email_from' ] = $values[ 'aw_email_from' ]->member_id;
			}

			if ( !empty( $values[ 'aw_topic_author' ] ) and $values[ 'aw_topic_author' ]->member_id )
			{
				$values[ 'aw_topic_author' ] = $values[ 'aw_topic_author' ]->member_id;
			}

			$form->saveAsSettings( $values );

What is the URL? What version of IPS are you on?

I just tested on Android and it seems to work for me.

@sobrenome

Thanks for testing the accents.

Some more small performance tweaks. Also, if you use memcached and full page caching there was a bug for guests that would cache visibility server-side rather than just using the CSS.

@sobrenome The issue with the gap has been fixed.  

Yes, it does. Unfortunately with full-page caching for guests available I cannot hide it server-side. For now, you can choose to turn it on for everyone if it's an issue.

It's possible with javascript. I'll look into providing some example code or maybe adding a small js file.

Thanks.

@sobrenome I've released the new version (1.0.6).

I've removed the custom text string that was being used for now but added an example of customization on the plugin page since the template does allow for access to the title and URL. The rest of the changes are just adding static variables and removing the call to the WhatsApp class if not on mobile/tablet and if the desktop view setting has not been toggled.

None of the other IPS share links seem to have custom text strings and I figured the performance improvements would be worth it. Hopefully you see some improvement in speed.  

This plugin has no javascript. It does have a CSS file to change the color of the share link.

I was able to optimize my test install of WhatsApp and on average saved about 2% of load time or about 10,000 microseconds on a full page on a topic with thousands of posts. Will release within the next few days.  

@sobrenome I was able to recreate the encoding bug on iPhone and in the new version I just released both reported bugs are fixed. The templates are changed so reverting is important to fix the iPhone-related bug. Thanks for reporting!

​It's under Core > Global > Plugins in the Theme editor.

I will try testing on an iPhone over the weekend. It's working on my Android phone so it may be iOS-specific.

The wrong positioning is a bug and I've created a fix for it on my test install. I will release the fix after I test the WhatsApp plugin on iPhone. 

Thanks.

I'm able to install fine on 4.0.2. Created a fresh install to test.

Is the button not appearing? If so, you need to be in mobile/tablet though you do have ability to toggle 'Hide in desktop mode?' in System > Sharing > WhatsApp > Edit. It's set to off by default because WhatsApp Web didn't support sharing last time I checked.

What's the error you're getting if that's not the issue?

Okay, finally I can reply.

This plugin would not have caused issues with memcached but, yes, at the time it would have caused issues after having disabled via plugin rather than System > WhatsApp > Sharing.

I've released version 1.0.4 which completely changes how this plugin functions so this issue should be resolved.

​That issue is generally caused by a missing template. There is an IN_DEV specific template (which is uploaded to /applications/core/dev/html/front/sharelinks/whatsapp_cvh.phtml) and then there's the one saved by IPS when installing the plugin. 

I'll make a note in the zip of how to uninstall the plugin correctly (which, yes, you have to delete the physical file in /system/content/shareservice before uninstalling the plugin).

Thank you for bringing this to my attention and I'm sorry it caused you issue. :/

edit: I have some ideas how to make this a non-issue in the future (by somehow piggy-backing on a hook).