Jump to content
  • [Beta 9.1] Issues with gallery comment/review templates


    Gallery uses a custom template compared to the global comments template: applications/gallery/dev/html/front/global/comment.phtml

    There are some issues with it:

    1. This custom template has only 1 hook point compared to the 7 available in the original template from the core application: applications/core/dev/html/front/global/comment.phtml
    2. Hardcoded label to toggle the mini profile => Toggle mini profile
    3. Missing code to highlight the reply based on the user's group.
    4. Some IDs/aria controls seem different or missing parts.

     

    ===

    There are also issues with the review template in the same folder: applications/gallery/dev/html/front/global/review.phtml

    1. This custom template has only 1 hook point. The default core template is the same, but it would help a lot if you could implement the same hook points as the comment template. Otherwise, we'll be unable to add the same template hooks for reviews.
    2. The template uses the old "manually crafted" review menu instead of using the new $review->menu() code. Without it, we cannot add new items to it through extensions.
    3. A cloud app call is missing. It affects only cloud customers and not self-hosted, though.

     

    ===

    I'm unsure why the Gallery uses custom (worse) templates instead of the default ones like the Downloads application since the output is the same. 🤨


    User Feedback

    Recommended Comments

    teraßyte

    Posted

    Confirmed fixed in beta 10.

     

    ===

    Rather than fixing the gallery templates, I would have changed the code to use the default templates (like Downloads does) since they're the same, but that will do anyway. I'll just have to duplicate the core template hooks for the gallery templates. 😅


×
×
  • Create New...